2023-08-10 13:27:50

by Arnd Bergmann

Subject: [PATCH 1/2] ethernet: ldmvsw: mark ldmvsw_open() static

From: Arnd Bergmann <[email protected]>

The function is exported for no reason and should just be static:

drivers/net/ethernet/sun/ldmvsw.c:127:5: error: no previous prototype for 'ldmvsw_open' [-Werror=missing-prototypes]

Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/net/ethernet/sun/ldmvsw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ldmvsw.c
index 734a817d3c945..a9a6670b5ff1f 100644
--- a/drivers/net/ethernet/sun/ldmvsw.c
+++ b/drivers/net/ethernet/sun/ldmvsw.c
@@ -124,7 +124,7 @@ static void vsw_set_rx_mode(struct net_device *dev)
return sunvnet_set_rx_mode_common(dev, port->vp);
}

-int ldmvsw_open(struct net_device *dev)
+static int ldmvsw_open(struct net_device *dev)
{
struct vnet_port *port = netdev_priv(dev);
struct vio_driver_state *vio = &port->vio;
@@ -136,7 +136,6 @@ int ldmvsw_open(struct net_device *dev)

return 0;
}
-EXPORT_SYMBOL_GPL(ldmvsw_open);

#ifdef CONFIG_NET_POLL_CONTROLLER
static void vsw_poll_controller(struct net_device *dev)
--
2.39.2

2023-08-10 21:20:25

by Simon Horman

Subject: Re: [PATCH 1/2] ethernet: ldmvsw: mark ldmvsw_open() static

On Thu, Aug 10, 2023 at 02:25:15PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> The function is exported for no reason and should just be static:
>
> drivers/net/ethernet/sun/ldmvsw.c:127:5: error: no previous prototype for 'ldmvsw_open' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <[email protected]>

Reviewed-by: Simon Horman <[email protected]>
Tested-by: Simon Horman <[email protected]> # build-tested

2023-08-12 02:45:30

by patchwork-bot+netdevbpf

Subject: Re: [PATCH 1/2] ethernet: ldmvsw: mark ldmvsw_open() static

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Thu, 10 Aug 2023 14:25:15 +0200 you wrote:
> From: Arnd Bergmann <[email protected]>
>
> The function is exported for no reason and should just be static:
>
> drivers/net/ethernet/sun/ldmvsw.c:127:5: error: no previous prototype for 'ldmvsw_open' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <[email protected]>
>
> [...]

Here is the summary with links:
- [1/2] ethernet: ldmvsw: mark ldmvsw_open() static
https://git.kernel.org/netdev/net-next/c/ea6f782fe584
- [2/2] ethernet: atarilance: mark init function static
https://git.kernel.org/netdev/net-next/c/7191c140faa2

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html