2023-09-20 04:56:38

by Herbert Xu

Subject: Re: [PATCH v3 1/3] drivers: rng: meson: add support for S4

On Mon, Sep 11, 2023 at 01:11:27PM +0300, Alexey Romanov wrote:
>
> +struct meson_rng_priv {
> + int (*read)(struct hwrng *rng, void *buf, size_t max, bool wait);
> +};
>
> struct meson_rng_data {
> void __iomem *base;
> struct hwrng rng;
> + struct device *dev;
> + const struct meson_rng_priv *priv;
> };

Is data->priv really necessary? It doesn't seem to be used anywhere
after the probe.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2023-09-22 10:05:59

by Alexey Romanov

Subject: Re: [PATCH v3 1/3] drivers: rng: meson: add support for S4

Hi Herbert,

On Wed, Sep 20, 2023 at 12:55:33PM +0800, Herbert Xu wrote:
> On Mon, Sep 11, 2023 at 01:11:27PM +0300, Alexey Romanov wrote:
> >
> > +struct meson_rng_priv {
> > + int (*read)(struct hwrng *rng, void *buf, size_t max, bool wait);
> > +};
> >
> > struct meson_rng_data {
> > void __iomem *base;
> > struct hwrng rng;
> > + struct device *dev;
> > + const struct meson_rng_priv *priv;
> > };
>
> Is data->priv really necessary? It doesn't seem to be used anywhere
> after the probe.
>

Are you suggesting remove meson_rng_priv and putting a pointer to read
function in meson_rng_data?


> Thanks,
> --
> Email: Herbert Xu <[email protected]>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

--
Thank you,
Alexey