2023-10-20 00:29:09

by Sean Christopherson

[permalink] [raw]
Subject: Re: [PATCH v4 0/9] KVM: selftests: Test the consistency of the PMU's CPUID and its features

On Mon, Sep 11, 2023, Jinrong Liang wrote:
> Jinrong Liang (9):
> KVM: selftests: Add vcpu_set_cpuid_property() to set properties
> KVM: selftests: Extend this_pmu_has() and kvm_pmu_has() to check arch
> events
> KVM: selftests: Add pmu.h for PMU events and common masks
> KVM: selftests: Test Intel PMU architectural events on gp counters
> KVM: selftests: Test Intel PMU architectural events on fixed counters
> KVM: selftests: Test consistency of CPUID with num of gp counters
> KVM: selftests: Test consistency of CPUID with num of fixed counters
> KVM: selftests: Test Intel supported fixed counters bit mask
> KVM: selftests: Test consistency of PMU MSRs with Intel PMU version

I've pushed a modified version to

https://github.com/sean-jc/linux/branches x86/pmu_counter_tests

which also has fixes for KVM's funky handling of fixed counters. I'll wait for
you to respond, but will tentatively plan on posting the above branch as v5
some time next week.


2023-10-20 09:12:22

by Jinrong Liang

[permalink] [raw]
Subject: Re: [PATCH v4 0/9] KVM: selftests: Test the consistency of the PMU's CPUID and its features

Sean Christopherson <[email protected]> 于2023年10月20日周五 08:28写道:
>
> On Mon, Sep 11, 2023, Jinrong Liang wrote:
> > Jinrong Liang (9):
> > KVM: selftests: Add vcpu_set_cpuid_property() to set properties
> > KVM: selftests: Extend this_pmu_has() and kvm_pmu_has() to check arch
> > events
> > KVM: selftests: Add pmu.h for PMU events and common masks
> > KVM: selftests: Test Intel PMU architectural events on gp counters
> > KVM: selftests: Test Intel PMU architectural events on fixed counters
> > KVM: selftests: Test consistency of CPUID with num of gp counters
> > KVM: selftests: Test consistency of CPUID with num of fixed counters
> > KVM: selftests: Test Intel supported fixed counters bit mask
> > KVM: selftests: Test consistency of PMU MSRs with Intel PMU version
>
> I've pushed a modified version to
>
> https://github.com/sean-jc/linux/branches x86/pmu_counter_tests
>
> which also has fixes for KVM's funky handling of fixed counters. I'll wait for
> you to respond, but will tentatively plan on posting the above branch as v5
> some time next week.

I truly appreciate your time and effort in reviewing my patches and
making the necessary modifications. I've carefully examined the
updated code in the branch you kindly provided:

https://github.com/sean-jc/linux/branches x86/pmu_counter_tests

I completely agree with the changes you made. Please feel free to post
the modified branch as v5 next week. I will add AMD counters related
selftests after this patch set is merged.

Thank you once again for your time and guidance.