2023-11-21 21:13:27

by kernel test robot

[permalink] [raw]
Subject: drivers/pinctrl/pinctrl-mcp23s08.c:1: warning: no structured comments found

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 98b1cc82c4affc16f5598d4fa14b1858671b2263
commit: d8f4494e70ae5fef159719bfbb6abedc53619bf1 pinctrl: mcp23s08: drop comment about missing irq support
date: 7 years ago
config: i386-randconfig-002-20231120 (https://download.01.org/0day-ci/archive/20231122/[email protected]/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231122/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

drivers/pinctrl/pinctrl-mcp23s08.c: In function 'mcp_pinconf_set':
drivers/pinctrl/pinctrl-mcp23s08.c:282:6: warning: variable 'val' set but not used [-Wunused-but-set-variable]
u16 val;
^~~
drivers/pinctrl/pinctrl-mcp23s08.c:281:11: warning: variable 'mask' set but not used [-Wunused-but-set-variable]
u32 arg, mask;
^~~~
>> drivers/pinctrl/pinctrl-mcp23s08.c:1: warning: no structured comments found


vim +1 drivers/pinctrl/pinctrl-mcp23s08.c

> 1 /* MCP23S08 SPI/I2C GPIO driver */
2

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


2023-12-02 00:56:39

by Randy Dunlap

[permalink] [raw]
Subject: Re: drivers/pinctrl/pinctrl-mcp23s08.c:1: warning: no structured comments found

Hi lkp,

On 11/21/23 13:12, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 98b1cc82c4affc16f5598d4fa14b1858671b2263
> commit: d8f4494e70ae5fef159719bfbb6abedc53619bf1 pinctrl: mcp23s08: drop comment about missing irq support
> date: 7 years ago
> config: i386-randconfig-002-20231120 (https://download.01.org/0day-ci/archive/20231122/[email protected]/config)
> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231122/[email protected]/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <[email protected]>
> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
>
> All warnings (new ones prefixed by >>):
>
> drivers/pinctrl/pinctrl-mcp23s08.c: In function 'mcp_pinconf_set':
> drivers/pinctrl/pinctrl-mcp23s08.c:282:6: warning: variable 'val' set but not used [-Wunused-but-set-variable]
> u16 val;
> ^~~
> drivers/pinctrl/pinctrl-mcp23s08.c:281:11: warning: variable 'mask' set but not used [-Wunused-but-set-variable]
> u32 arg, mask;
> ^~~~
>>> drivers/pinctrl/pinctrl-mcp23s08.c:1: warning: no structured comments found
>
>
> vim +1 drivers/pinctrl/pinctrl-mcp23s08.c
>
> > 1 /* MCP23S08 SPI/I2C GPIO driver */
> 2


What is the issue here?
I fail to see a problem.

I cannot reproduce the $Subject warning message.

--
~Randy

2023-12-05 06:48:26

by Yujie Liu

[permalink] [raw]
Subject: Re: drivers/pinctrl/pinctrl-mcp23s08.c:1: warning: no structured comments found

Hi Randy,

On Fri, Dec 01, 2023 at 04:53:22PM -0800, Randy Dunlap wrote:
> Hi lkp,
>
> On 11/21/23 13:12, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: 98b1cc82c4affc16f5598d4fa14b1858671b2263
> > commit: d8f4494e70ae5fef159719bfbb6abedc53619bf1 pinctrl: mcp23s08: drop comment about missing irq support
> > date: 7 years ago
> > config: i386-randconfig-002-20231120 (https://download.01.org/0day-ci/archive/20231122/[email protected]/config)
> > compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231122/[email protected]/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <[email protected]>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> >
> > All warnings (new ones prefixed by >>):
> >
> > drivers/pinctrl/pinctrl-mcp23s08.c: In function 'mcp_pinconf_set':
> > drivers/pinctrl/pinctrl-mcp23s08.c:282:6: warning: variable 'val' set but not used [-Wunused-but-set-variable]
> > u16 val;
> > ^~~
> > drivers/pinctrl/pinctrl-mcp23s08.c:281:11: warning: variable 'mask' set but not used [-Wunused-but-set-variable]
> > u32 arg, mask;
> > ^~~~
> >>> drivers/pinctrl/pinctrl-mcp23s08.c:1: warning: no structured comments found
> >
> >
> > vim +1 drivers/pinctrl/pinctrl-mcp23s08.c
> >
> > > 1 /* MCP23S08 SPI/I2C GPIO driver */
> > 2
>
>
> What is the issue here?
> I fail to see a problem.
>
> I cannot reproduce the $Subject warning message.

Please ignore this false report of kernel-doc warning.
Sorry for the noise.

Best Regards,
Yujie