2023-11-25 21:55:32

by Gustavo A. R. Silva

Subject: [PATCH][next] gcc-plugins: randstruct: Update code comment in relayout_struct()

Update code comment to clarify that the only element whose layout is
not randomized is a proper C99 flexible-array member. This update is
complementary to commit 1ee60356c2dc ("gcc-plugins: randstruct: Only
warn about true flexible arrays")

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
scripts/gcc-plugins/randomize_layout_plugin.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/scripts/gcc-plugins/randomize_layout_plugin.c b/scripts/gcc-plugins/randomize_layout_plugin.c
index 910bd21d08f4..746ff2d272f2 100644
--- a/scripts/gcc-plugins/randomize_layout_plugin.c
+++ b/scripts/gcc-plugins/randomize_layout_plugin.c
@@ -339,8 +339,7 @@ static int relayout_struct(tree type)

/*
* enforce that we don't randomize the layout of the last
- * element of a struct if it's a 0 or 1-length array
- * or a proper flexible array
+ * element of a struct if it's a proper flexible array
*/
if (is_flexible_array(newtree[num_fields - 1])) {
has_flexarray = true;
--
2.34.1

2023-11-28 00:35:03

by Kees Cook

Subject: Re: [PATCH][next] gcc-plugins: randstruct: Update code comment in relayout_struct()

On Sat, 25 Nov 2023 15:49:12 -0600, Gustavo A. R. Silva wrote:
> Update code comment to clarify that the only element whose layout is
> not randomized is a proper C99 flexible-array member. This update is
> complementary to commit 1ee60356c2dc ("gcc-plugins: randstruct: Only
> warn about true flexible arrays")
>
>

Applied to for-linus/hardening, thanks!

[1/1] gcc-plugins: randstruct: Update code comment in relayout_struct()
https://git.kernel.org/kees/c/d71f22365a9c

Take care,

--
Kees Cook