2023-11-23 10:07:23

by Jim.Lin

Subject: [PATCH] Merge tag: Fixed an issue where it takes more than 20 mins for SK Hynix BC901 to switch to developer mode on Chromebook

SK Hynix BC901 drive write zero will cause Chromebook takes more than 20 mins to switch to developer mode
"disable wrtie zero" can fix this issue and Sk Hynix has been verified.

Signed-off-by: Jim.Lin <[email protected]>
---
drivers/nvme/host/pci.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 507bc149046d..f27202680741 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3394,6 +3394,8 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
{ PCI_DEVICE(0x1c5c, 0x174a), /* SK Hynix P31 SSD */
.driver_data = NVME_QUIRK_BOGUS_NID, },
+ { PCI_DEVICE(0x1c5c, 0x1D59), /* SK Hynix BC901 */
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
{ PCI_DEVICE(0x15b7, 0x2001), /* Sandisk Skyhawk */
.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
{ PCI_DEVICE(0x1d97, 0x2263), /* SPCC */
--
2.25.1

2023-11-27 18:16:51

by Keith Busch

Subject: Re: [PATCH] Merge tag: Fixed an issue where it takes more than 20 mins for SK Hynix BC901 to switch to developer mode on Chromebook

On Thu, Nov 23, 2023 at 06:06:42PM +0800, Jim.Lin wrote:
> SK Hynix BC901 drive write zero will cause Chromebook takes more than 20 mins to switch to developer mode
> "disable wrtie zero" can fix this issue and Sk Hynix has been verified.
>
> Signed-off-by: Jim.Lin <[email protected]>

For the changelog, let's abbreviate the subject to something like:

"nvme-pci: disable write zeroes for SK Hynix BC901"

> @@ -3394,6 +3394,8 @@ static const struct pci_device_id nvme_id_table[] = {
> .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
> { PCI_DEVICE(0x1c5c, 0x174a), /* SK Hynix P31 SSD */
> .driver_data = NVME_QUIRK_BOGUS_NID, },
> + { PCI_DEVICE(0x1c5c, 0x1D59), /* SK Hynix BC901 */
> + .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },

Could we get an "Ack" from the vendor?