2023-11-28 08:27:56

by Wilken Gottwalt

Subject: [PATCH] lib: kstrtox: fix typo in comment

Delete one of the double f's in "iff".

Signed-off-by: Wilken Gottwalt <[email protected]>
---
lib/kstrtox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/kstrtox.c b/lib/kstrtox.c
index d586e6af5e5a..b0a9fdce15b3 100644
--- a/lib/kstrtox.c
+++ b/lib/kstrtox.c
@@ -340,7 +340,7 @@ EXPORT_SYMBOL(kstrtos8);
* @s: input string
* @res: result
*
- * This routine returns 0 iff the first character is one of 'YyTt1NnFf0', or
+ * This routine returns 0 if the first character is one of 'YyTt1NnFf0', or
* [oO][NnFf] for "on" and "off". Otherwise it will return -EINVAL. Value
* pointed to by res is updated upon finding a match.
*/
--
2.43.0

2023-11-28 16:26:44

by Randy Dunlap

Subject: Re: [PATCH] lib: kstrtox: fix typo in comment

On 11/28/23 00:27, Wilken Gottwalt wrote:
> Delete one of the double f's in "iff".
>
> Signed-off-by: Wilken Gottwalt <[email protected]>

Nope, see:
https://en.wikipedia.org/wiki/If_and_only_if

> ---
> lib/kstrtox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/kstrtox.c b/lib/kstrtox.c
> index d586e6af5e5a..b0a9fdce15b3 100644
> --- a/lib/kstrtox.c
> +++ b/lib/kstrtox.c
> @@ -340,7 +340,7 @@ EXPORT_SYMBOL(kstrtos8);
> * @s: input string
> * @res: result
> *
> - * This routine returns 0 iff the first character is one of 'YyTt1NnFf0', or
> + * This routine returns 0 if the first character is one of 'YyTt1NnFf0', or
> * [oO][NnFf] for "on" and "off". Otherwise it will return -EINVAL. Value
> * pointed to by res is updated upon finding a match.
> */

--
~Randy

2023-11-29 04:48:55

by Wilken Gottwalt

Subject: Re: [PATCH] lib: kstrtox: fix typo in comment

On Tue, 28 Nov 2023 08:26:03 -0800
Randy Dunlap <[email protected]> wrote:

> On 11/28/23 00:27, Wilken Gottwalt wrote:
> > Delete one of the double f's in "iff".
> >
> > Signed-off-by: Wilken Gottwalt <[email protected]>
>
> Nope, see:
> https://en.wikipedia.org/wiki/If_and_only_if

Oh, interesting. Never thought of this. Though, now I wonder: How often do such
"fixes" happen?

> > ---
> > lib/kstrtox.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/kstrtox.c b/lib/kstrtox.c
> > index d586e6af5e5a..b0a9fdce15b3 100644
> > --- a/lib/kstrtox.c
> > +++ b/lib/kstrtox.c
> > @@ -340,7 +340,7 @@ EXPORT_SYMBOL(kstrtos8);
> > * @s: input string
> > * @res: result
> > *
> > - * This routine returns 0 iff the first character is one of 'YyTt1NnFf0', or
> > + * This routine returns 0 if the first character is one of 'YyTt1NnFf0', or
> > * [oO][NnFf] for "on" and "off". Otherwise it will return -EINVAL. Value
> > * pointed to by res is updated upon finding a match.
> > */
>

2023-11-29 05:40:24

by Randy Dunlap

Subject: Re: [PATCH] lib: kstrtox: fix typo in comment

On 11/28/23 20:48, Wilken Gottwalt wrote:
> On Tue, 28 Nov 2023 08:26:03 -0800
> Randy Dunlap <[email protected]> wrote:
>
>> On 11/28/23 00:27, Wilken Gottwalt wrote:
>>> Delete one of the double f's in "iff".
>>>
>>> Signed-off-by: Wilken Gottwalt <[email protected]>
>>
>> Nope, see:
>> https://en.wikipedia.org/wiki/If_and_only_if
>
> Oh, interesting. Never thought of this. Though, now I wonder: How often do such
> "fixes" happen?

I think that I have seen 2 other patches for "iff", but I probably have missed some.



>>> ---
>>> lib/kstrtox.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lib/kstrtox.c b/lib/kstrtox.c
>>> index d586e6af5e5a..b0a9fdce15b3 100644
>>> --- a/lib/kstrtox.c
>>> +++ b/lib/kstrtox.c
>>> @@ -340,7 +340,7 @@ EXPORT_SYMBOL(kstrtos8);
>>> * @s: input string
>>> * @res: result
>>> *
>>> - * This routine returns 0 iff the first character is one of 'YyTt1NnFf0', or
>>> + * This routine returns 0 if the first character is one of 'YyTt1NnFf0', or
>>> * [oO][NnFf] for "on" and "off". Otherwise it will return -EINVAL. Value
>>> * pointed to by res is updated upon finding a match.
>>> */
>>
>

--
~Randy