2023-12-21 03:11:13

by Dmitry Torokhov

Subject: [PATCH] Input: da9063_onkey - avoid using OF-specific APIs

There is nothing OF-specific in the driver, so switch from OF properties
helpers to generic device helpers.

Signed-off-by: Dmitry Torokhov <[email protected]>
---
drivers/input/misc/da9063_onkey.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c
index a8b7f1cd0ec2..ce499c28a7b2 100644
--- a/drivers/input/misc/da9063_onkey.c
+++ b/drivers/input/misc/da9063_onkey.c
@@ -9,11 +9,12 @@
#include <linux/errno.h>
#include <linux/input.h>
#include <linux/interrupt.h>
+#include <linux/mod_devicetable.h>
#include <linux/platform_device.h>
#include <linux/pm_wakeirq.h>
+#include <linux/property.h>
#include <linux/workqueue.h>
#include <linux/regmap.h>
-#include <linux/of.h>
#include <linux/mfd/da9063/core.h>
#include <linux/mfd/da9063/registers.h>
#include <linux/mfd/da9062/core.h>
@@ -199,8 +200,8 @@ static int da9063_onkey_probe(struct platform_device *pdev)
return dev_err_probe(&pdev->dev, -ENXIO,
"Parent regmap unavailable.\n");

- onkey->key_power = !of_property_read_bool(pdev->dev.of_node,
- "dlg,disable-key-power");
+ onkey->key_power = !device_property_read_bool(&pdev->dev,
+ "dlg,disable-key-power");

onkey->input = devm_input_allocate_device(&pdev->dev);
if (!onkey->input)
--
2.43.0.195.gebba966016-goog


--
Dmitry

2024-01-04 19:09:24

by Biju Das

Subject: RE: [PATCH] Input: da9063_onkey - avoid using OF-specific APIs

Hi Dmitry Torokhov,

Thanks for the patch.

> -----Original Message-----
> From: Dmitry Torokhov <[email protected]>
> Sent: Thursday, December 21, 2023 3:09 AM
> To: Support Opensource <[email protected]>; Biju Das
> <[email protected]>
> Cc: [email protected]; [email protected]
> Subject: [PATCH] Input: da9063_onkey - avoid using OF-specific APIs
>
> There is nothing OF-specific in the driver, so switch from OF properties
> helpers to generic device helpers.
>
> Signed-off-by: Dmitry Torokhov <[email protected]>

Reviewed-by: Biju Das <[email protected]>

> ---
> drivers/input/misc/da9063_onkey.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/misc/da9063_onkey.c
> b/drivers/input/misc/da9063_onkey.c
> index a8b7f1cd0ec2..ce499c28a7b2 100644
> --- a/drivers/input/misc/da9063_onkey.c
> +++ b/drivers/input/misc/da9063_onkey.c
> @@ -9,11 +9,12 @@
> #include <linux/errno.h>
> #include <linux/input.h>
> #include <linux/interrupt.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/platform_device.h>
> #include <linux/pm_wakeirq.h>
> +#include <linux/property.h>
> #include <linux/workqueue.h>
> #include <linux/regmap.h>
> -#include <linux/of.h>
> #include <linux/mfd/da9063/core.h>
> #include <linux/mfd/da9063/registers.h> #include
> <linux/mfd/da9062/core.h> @@ -199,8 +200,8 @@ static int
> da9063_onkey_probe(struct platform_device *pdev)
> return dev_err_probe(&pdev->dev, -ENXIO,
> "Parent regmap unavailable.\n");
>
> - onkey->key_power = !of_property_read_bool(pdev->dev.of_node,
> - "dlg,disable-key-power");
> + onkey->key_power = !device_property_read_bool(&pdev->dev,
> + "dlg,disable-key-power");
>
> onkey->input = devm_input_allocate_device(&pdev->dev);
> if (!onkey->input)
> --
> 2.43.0.195.gebba966016-goog
>
>
> --
> Dmitry