2023-12-31 12:21:19

by Marcin Wojtas

Subject: [net-next: PATCH] net: mvpp2: initialize port fwnode pointer

Update the port's device structure also with its fwnode pointer
with a recommended device_set_node() helper routine.

Signed-off-by: Marcin Wojtas <[email protected]>
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index 1ca273f17d29..820b1fabe297 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -6877,7 +6877,7 @@ static int mvpp2_port_probe(struct platform_device *pdev,
dev->min_mtu = ETH_MIN_MTU;
/* 9704 == 9728 - 20 and rounding to 8 */
dev->max_mtu = MVPP2_BM_JUMBO_PKT_SIZE;
- dev->dev.of_node = port_node;
+ device_set_node(&dev->dev, port_fwnode);

port->pcs_gmac.ops = &mvpp2_phylink_gmac_pcs_ops;
port->pcs_gmac.neg_mode = true;
--
2.34.1

2024-01-02 06:36:29

by Suman Ghosh

Subject: RE: [EXT] [net-next: PATCH] net: mvpp2: initialize port fwnode pointer

Looks good to me.

>----------------------------------------------------------------------
>Update the port's device structure also with its fwnode pointer with a
>recommended device_set_node() helper routine.
>
>Signed-off-by: Marcin Wojtas <[email protected]>
[Suman] Reviewed-by: Suman Ghosh <[email protected]>
>---
> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>index 1ca273f17d29..820b1fabe297 100644
>--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>@@ -6877,7 +6877,7 @@ static int mvpp2_port_probe(struct platform_device
>*pdev,
> dev->min_mtu = ETH_MIN_MTU;
> /* 9704 == 9728 - 20 and rounding to 8 */
> dev->max_mtu = MVPP2_BM_JUMBO_PKT_SIZE;
>- dev->dev.of_node = port_node;
>+ device_set_node(&dev->dev, port_fwnode);
>
> port->pcs_gmac.ops = &mvpp2_phylink_gmac_pcs_ops;
> port->pcs_gmac.neg_mode = true;
>--
>2.34.1
>

2024-01-02 12:03:16

by Russell King (Oracle)

Subject: Re: [net-next: PATCH] net: mvpp2: initialize port fwnode pointer

On Sun, Dec 31, 2023 at 12:20:19PM +0000, Marcin Wojtas wrote:
> Update the port's device structure also with its fwnode pointer
> with a recommended device_set_node() helper routine.
>
> Signed-off-by: Marcin Wojtas <[email protected]>

Reviewed-by: Russell King (Oracle) <[email protected]>

Thanks!

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

2024-01-04 01:01:52

by patchwork-bot+netdevbpf

Subject: Re: [net-next: PATCH] net: mvpp2: initialize port fwnode pointer

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Sun, 31 Dec 2023 12:20:19 +0000 you wrote:
> Update the port's device structure also with its fwnode pointer
> with a recommended device_set_node() helper routine.
>
> Signed-off-by: Marcin Wojtas <[email protected]>
> ---
> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [net-next:] net: mvpp2: initialize port fwnode pointer
https://git.kernel.org/netdev/net-next/c/5fe65375e3d4

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html