2023-06-14 07:01:39

by baomingtong001

Subject: [PATCH] perf tools:remove unneeded variable from perf_event_attr__fprintf()

fix the following coccicheck warning:

tools/perf/util/perf_event_attr_fprintf.c:97:5-8: Unneeded variable:
"ret". Return "0".

Signed-off-by: Mingtong Bao <[email protected]>
---
tools/perf/util/perf_event_attr_fprintf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/perf/util/perf_event_attr_fprintf.c
b/tools/perf/util/perf_event_attr_fprintf.c
index 7e5e7b30510d..4a8f625b80c7 100644
--- a/tools/perf/util/perf_event_attr_fprintf.c
+++ b/tools/perf/util/perf_event_attr_fprintf.c
@@ -94,7 +94,6 @@ int perf_event_attr__fprintf(FILE *fp, struct
perf_event_attr *attr,
attr__fprintf_f attr__fprintf, void *priv)
{
char buf[BUF_SIZE];
- int ret = 0;

PRINT_ATTRf(type, p_unsigned);
PRINT_ATTRf(size, p_unsigned);
@@ -155,5 +154,5 @@ int perf_event_attr__fprintf(FILE *fp, struct
perf_event_attr *attr,
PRINT_ATTRf(aux_sample_size, p_unsigned);
PRINT_ATTRf(sig_data, p_unsigned);

- return ret;
+ return 0;
}

2023-07-13 01:50:52

by Ian Rogers

Subject: Re: [PATCH] perf tools:remove unneeded variable from perf_event_attr__fprintf()

On Tue, Jun 13, 2023 at 11:25 PM <[email protected]> wrote:
>
> fix the following coccicheck warning:
>
> tools/perf/util/perf_event_attr_fprintf.c:97:5-8: Unneeded variable:
> "ret". Return "0".
>
> Signed-off-by: Mingtong Bao <[email protected]>

Acked-by: Ian Rogers <[email protected]>

Thanks,
Ian

> ---
> tools/perf/util/perf_event_attr_fprintf.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/perf_event_attr_fprintf.c
> b/tools/perf/util/perf_event_attr_fprintf.c
> index 7e5e7b30510d..4a8f625b80c7 100644
> --- a/tools/perf/util/perf_event_attr_fprintf.c
> +++ b/tools/perf/util/perf_event_attr_fprintf.c
> @@ -94,7 +94,6 @@ int perf_event_attr__fprintf(FILE *fp, struct
> perf_event_attr *attr,
> attr__fprintf_f attr__fprintf, void *priv)
> {
> char buf[BUF_SIZE];
> - int ret = 0;
>
> PRINT_ATTRf(type, p_unsigned);
> PRINT_ATTRf(size, p_unsigned);
> @@ -155,5 +154,5 @@ int perf_event_attr__fprintf(FILE *fp, struct
> perf_event_attr *attr,
> PRINT_ATTRf(aux_sample_size, p_unsigned);
> PRINT_ATTRf(sig_data, p_unsigned);
>
> - return ret;
> + return 0;
> }

2024-01-03 21:20:01

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf tools:remove unneeded variable from perf_event_attr__fprintf()

Em Wed, Jul 12, 2023 at 06:20:12PM -0700, Ian Rogers escreveu:
> On Tue, Jun 13, 2023 at 11:25 PM <[email protected]> wrote:
> >
> > fix the following coccicheck warning:
> >
> > tools/perf/util/perf_event_attr_fprintf.c:97:5-8: Unneeded variable:
> > "ret". Return "0".
> >
> > Signed-off-by: Mingtong Bao <[email protected]>
>
> Acked-by: Ian Rogers <[email protected]>

util/perf_event_attr_fprintf.c: In function ‘perf_event_attr__fprintf’:
util/perf_event_attr_fprintf.c:256:17: error: ‘ret’ undeclared (first use in this function)
256 | ret += attr__fprintf(fp, _n, buf, priv);\
| ^~~
util/perf_event_attr_fprintf.c:267:9: note: in expansion of macro ‘PRINT_ATTRn’
267 | PRINT_ATTRn("type", type, p_type_id, true);
| ^~~~~~~~~~~

All those PRINT_ATTRf use that ret variable:

#define PRINT_ATTRn(_n, _f, _p, _a) \
do { \
if (_a || attr->_f) { \
_p(attr->_f); \
ret += attr__fprintf(fp, _n, buf, priv);\
} \
} while (0)

#define PRINT_ATTRf(_f, _p) PRINT_ATTRn(#_f, _f, _p, false

- Arnaldo

> Thanks,
> Ian
>
> > ---
> > tools/perf/util/perf_event_attr_fprintf.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/tools/perf/util/perf_event_attr_fprintf.c
> > b/tools/perf/util/perf_event_attr_fprintf.c
> > index 7e5e7b30510d..4a8f625b80c7 100644
> > --- a/tools/perf/util/perf_event_attr_fprintf.c
> > +++ b/tools/perf/util/perf_event_attr_fprintf.c
> > @@ -94,7 +94,6 @@ int perf_event_attr__fprintf(FILE *fp, struct
> > perf_event_attr *attr,
> > attr__fprintf_f attr__fprintf, void *priv)
> > {
> > char buf[BUF_SIZE];
> > - int ret = 0;
> >
> > PRINT_ATTRf(type, p_unsigned);
> > PRINT_ATTRf(size, p_unsigned);
> > @@ -155,5 +154,5 @@ int perf_event_attr__fprintf(FILE *fp, struct
> > perf_event_attr *attr,
> > PRINT_ATTRf(aux_sample_size, p_unsigned);
> > PRINT_ATTRf(sig_data, p_unsigned);
> >
> > - return ret;
> > + return 0;
> > }

--

- Arnaldo