2024-01-07 00:40:00

by Mirsad Todorovac

[permalink] [raw]
Subject: [PATCH v1 1/1] selftests: net: increase timeout value for tests

In particular, fcnal-test.sh timed out on slower hardware after
some new permutations of tests were added.

This single test ran for almost an hour instead of the expected
25 min (1500s). 75 minutes should suffice for most systems.

Cc: David Ahern <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Eric Dumazet <[email protected]>
Cc: Jakub Kicinski <[email protected]>
Cc: Paolo Abeni <[email protected]>
Cc: Shuah Khan <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Mirsad Todorovac <[email protected]>
---
tools/testing/selftests/net/settings | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/settings b/tools/testing/selftests/net/settings
index dfc27cdc6c05..ed8418e8217a 100644
--- a/tools/testing/selftests/net/settings
+++ b/tools/testing/selftests/net/settings
@@ -1 +1 @@
-timeout=1500
+timeout=4500
--
2.40.1



2024-01-07 12:50:10

by Hangbin Liu

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] selftests: net: increase timeout value for tests

On Sun, Jan 07, 2024 at 01:39:29AM +0100, Mirsad Todorovac wrote:
> In particular, fcnal-test.sh timed out on slower hardware after
> some new permutations of tests were added.
>
> This single test ran for almost an hour instead of the expected
> 25 min (1500s). 75 minutes should suffice for most systems.
>
> Cc: David Ahern <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Eric Dumazet <[email protected]>
> Cc: Jakub Kicinski <[email protected]>
> Cc: Paolo Abeni <[email protected]>
> Cc: Shuah Khan <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Mirsad Todorovac <[email protected]>
> ---
> tools/testing/selftests/net/settings | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/settings b/tools/testing/selftests/net/settings
> index dfc27cdc6c05..ed8418e8217a 100644
> --- a/tools/testing/selftests/net/settings
> +++ b/tools/testing/selftests/net/settings
> @@ -1 +1 @@
> -timeout=1500
> +timeout=4500
> --
> 2.40.1
>

FYI, the net-next patch 779283b7770f ("selftests/net: convert fcnal-test.sh
to run it in unique namespace") has extended the timeout to 3600s.

Thanks
Hangbin

2024-01-07 15:22:35

by Mirsad Todorovac

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] selftests: net: increase timeout value for tests

On 07. 01. 2024. 13:49, Hangbin Liu wrote:
> On Sun, Jan 07, 2024 at 01:39:29AM +0100, Mirsad Todorovac wrote:
>> In particular, fcnal-test.sh timed out on slower hardware after
>> some new permutations of tests were added.
>>
>> This single test ran for almost an hour instead of the expected
>> 25 min (1500s). 75 minutes should suffice for most systems.
>>
>> Cc: David Ahern <[email protected]>
>> Cc: "David S. Miller" <[email protected]>
>> Cc: Eric Dumazet <[email protected]>
>> Cc: Jakub Kicinski <[email protected]>
>> Cc: Paolo Abeni <[email protected]>
>> Cc: Shuah Khan <[email protected]>
>> Cc: [email protected]
>> Cc: [email protected]
>> Signed-off-by: Mirsad Todorovac <[email protected]>
>> ---
>> tools/testing/selftests/net/settings | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/net/settings b/tools/testing/selftests/net/settings
>> index dfc27cdc6c05..ed8418e8217a 100644
>> --- a/tools/testing/selftests/net/settings
>> +++ b/tools/testing/selftests/net/settings
>> @@ -1 +1 @@
>> -timeout=1500
>> +timeout=4500
>> --
>> 2.40.1
>>
>
> FYI, the net-next patch 779283b7770f ("selftests/net: convert fcnal-test.sh
> to run it in unique namespace") has extended the timeout to 3600s.
>
> Thanks
> Hangbin

Copy that.

Haven't checked the net-next tree, sorry.

As your patch is prior art, then this commit is duplicate work.

Haven't yet found howto follow all the next-trees required to fix selftests,
though :-/

Best regards,
Mirsad


--
Mirsad Goran Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu

System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia
The European Union

"I see something approaching fast ... Will it be friends with me?"