2024-01-17 07:31:58

by Kunwu Chan

Subject: [PATCH v2] Input: synaptics-rmi4: Add a null pointer check to the rmi_driver_probe

devm_kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure. Ensure the allocation was successful
by checking the pointer validity.

Signed-off-by: Kunwu Chan <[email protected]>
Suggested-by: Dmitry Torokhov <[email protected]>
---
v2: Change title and remove dev_err
---
drivers/input/rmi4/rmi_driver.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
index 258d5fe3d395..8da104e99e7b 100644
--- a/drivers/input/rmi4/rmi_driver.c
+++ b/drivers/input/rmi4/rmi_driver.c
@@ -1197,6 +1197,10 @@ static int rmi_driver_probe(struct device *dev)
rmi_driver_set_input_params(rmi_dev, data->input);
data->input->phys = devm_kasprintf(dev, GFP_KERNEL,
"%s/input0", dev_name(dev));
+ if (!data->input->phys) {
+ retval = -ENOMEM;
+ goto err;
+ }
}

retval = rmi_init_functions(data);
--
2.39.2

2024-01-18 22:32:51

by Dmitry Torokhov

Subject: Re: [PATCH v2] Input: synaptics-rmi4: Add a null pointer check to the rmi_driver_probe

Hi Kunwu,

On Wed, Jan 17, 2024 at 03:31:24PM +0800, Kunwu Chan wrote:
> devm_kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure. Ensure the allocation was successful
> by checking the pointer validity.
>
> Signed-off-by: Kunwu Chan <[email protected]>
> Suggested-by: Dmitry Torokhov <[email protected]>

I did not suggest the patch, I merely provided feedback on it, so I
dropped this tag, reworded commit message slightly, and applied.

Thanks.

--
Dmitry