2024-01-28 05:54:37

by 梦龙董

[permalink] [raw]
Subject: [PATCH bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline

It seems that the field "mod" in struct bpf_trampoline is not used
anywhere after the commit 31bf1dbccfb0 ("bpf: Fix attaching
fentry/fexit/fmod_ret/lsm to modules"). So we can just remove it now.

Signed-off-by: Menglong Dong <[email protected]>
---
include/linux/bpf.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/linux/bpf.h b/include/linux/bpf.h
index b86bd15a051d..1ebbee1d648e 100644
--- a/include/linux/bpf.h
+++ b/include/linux/bpf.h
@@ -1189,7 +1189,6 @@ struct bpf_trampoline {
int progs_cnt[BPF_TRAMP_MAX];
/* Executable image of trampoline */
struct bpf_tramp_image *cur_image;
- struct module *mod;
};

struct bpf_attach_target_info {
--
2.39.2



2024-01-28 09:05:09

by Jiri Olsa

[permalink] [raw]
Subject: Re: [PATCH bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline

On Sun, Jan 28, 2024 at 01:54:43PM +0800, Menglong Dong wrote:
> It seems that the field "mod" in struct bpf_trampoline is not used
> anywhere after the commit 31bf1dbccfb0 ("bpf: Fix attaching
> fentry/fexit/fmod_ret/lsm to modules"). So we can just remove it now.
>
> Signed-off-by: Menglong Dong <[email protected]>

Fixes: 31bf1dbccfb0 ("bpf: Fix attaching fentry/fexit/fmod_ret/lsm to modules")

Acked-by: Jiri Olsa <[email protected]>

thanks,
jirka


> ---
> include/linux/bpf.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/bpf.h b/include/linux/bpf.h
> index b86bd15a051d..1ebbee1d648e 100644
> --- a/include/linux/bpf.h
> +++ b/include/linux/bpf.h
> @@ -1189,7 +1189,6 @@ struct bpf_trampoline {
> int progs_cnt[BPF_TRAMP_MAX];
> /* Executable image of trampoline */
> struct bpf_tramp_image *cur_image;
> - struct module *mod;
> };
>
> struct bpf_attach_target_info {
> --
> 2.39.2
>

2024-01-29 16:06:21

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <[email protected]>:

On Sun, 28 Jan 2024 13:54:43 +0800 you wrote:
> It seems that the field "mod" in struct bpf_trampoline is not used
> anywhere after the commit 31bf1dbccfb0 ("bpf: Fix attaching
> fentry/fexit/fmod_ret/lsm to modules"). So we can just remove it now.
>
> Signed-off-by: Menglong Dong <[email protected]>
> ---
> include/linux/bpf.h | 1 -
> 1 file changed, 1 deletion(-)

Here is the summary with links:
- [bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline
https://git.kernel.org/bpf/bpf-next/c/efaa47db9245

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html