2024-01-30 09:23:40

by Kunwu Chan

Subject: [PATCH net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers

commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
introduces a new macro.
Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
to simplify the creation of SLAB caches.

Signed-off-by: Kunwu Chan <[email protected]>
---
net/ipv4/inetpeer.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c
index e9fed83e9b3c..5bd759963451 100644
--- a/net/ipv4/inetpeer.c
+++ b/net/ipv4/inetpeer.c
@@ -81,10 +81,7 @@ void __init inet_initpeers(void)

inet_peer_threshold = clamp_val(nr_entries, 4096, 65536 + 128);

- peer_cachep = kmem_cache_create("inet_peer_cache",
- sizeof(struct inet_peer),
- 0, SLAB_HWCACHE_ALIGN | SLAB_PANIC,
- NULL);
+ peer_cachep = KMEM_CACHE(inet_peer, SLAB_HWCACHE_ALIGN | SLAB_PANIC);
}

/* Called with rcu_read_lock() or base->lock held */
--
2.39.2

2024-01-30 15:39:07

by Jiri Pirko

Subject: Re: [PATCH net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers

Tue, Jan 30, 2024 at 10:22:55AM CET, [email protected] wrote:
>commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
>introduces a new macro.
>Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
>to simplify the creation of SLAB caches.
>
>Signed-off-by: Kunwu Chan <[email protected]>
>---
> net/ipv4/inetpeer.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c
>index e9fed83e9b3c..5bd759963451 100644
>--- a/net/ipv4/inetpeer.c
>+++ b/net/ipv4/inetpeer.c
>@@ -81,10 +81,7 @@ void __init inet_initpeers(void)
>
> inet_peer_threshold = clamp_val(nr_entries, 4096, 65536 + 128);
>
>- peer_cachep = kmem_cache_create("inet_peer_cache",
>- sizeof(struct inet_peer),
>- 0, SLAB_HWCACHE_ALIGN | SLAB_PANIC,
>- NULL);
>+ peer_cachep = KMEM_CACHE(inet_peer, SLAB_HWCACHE_ALIGN | SLAB_PANIC);

The name is going to be different. Could it be a source of some issue?
My guess is not, just want to make sure.



> }
>
> /* Called with rcu_read_lock() or base->lock held */
>--
>2.39.2
>
>

2024-01-31 07:57:26

by Kunwu Chan

Subject: Re: [PATCH net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers

Thanks for your reply.

As the code say, the name is only for human beings and to identify a
cache, so it's ok.

"A string which is used in /proc/slabinfo to identify this cache."
--
Thanks,
Kunwu

2024-01-31 13:27:53

by Jiri Pirko

Subject: Re: [PATCH net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers

Tue, Jan 30, 2024 at 10:22:55AM CET, [email protected] wrote:
>commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
>introduces a new macro.
>Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
>to simplify the creation of SLAB caches.
>
>Signed-off-by: Kunwu Chan <[email protected]>

Reviewed-by: Jiri Pirko <[email protected]>

2024-02-01 00:50:43

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Tue, 30 Jan 2024 17:22:55 +0800 you wrote:
> commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
> introduces a new macro.
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
> Signed-off-by: Kunwu Chan <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers
https://git.kernel.org/netdev/net-next/c/57f2c6350f2d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html