2024-02-26 19:15:58

by Martin Kaiser

Subject: [PATCH 2/3] lib/test_vmalloc.c: drop empty exit function

The module is never loaded successfully. Therefore, it'll never be
unloaded and we can remove the exit function.

Signed-off-by: Martin Kaiser <[email protected]>
---
lib/test_vmalloc.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c
index 191b6bd5dff9..d0c0cbe1913d 100644
--- a/lib/test_vmalloc.c
+++ b/lib/test_vmalloc.c
@@ -600,12 +600,7 @@ static int vmalloc_test_init(void)
return -EAGAIN; /* Fail will directly unload the module */
}

-static void vmalloc_test_exit(void)
-{
-}
-
module_init(vmalloc_test_init)
-module_exit(vmalloc_test_exit)

MODULE_LICENSE("GPL");
MODULE_AUTHOR("Uladzislau Rezki");
--
2.39.2

2024-02-27 06:59:30

by Uladzislau Rezki

Subject: Re: [PATCH 2/3] lib/test_vmalloc.c: drop empty exit function

On Mon, Feb 26, 2024 at 08:11:58PM +0100, Martin Kaiser wrote:
> The module is never loaded successfully. Therefore, it'll never be
> unloaded and we can remove the exit function.
>
> Signed-off-by: Martin Kaiser <[email protected]>
> ---
> lib/test_vmalloc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c
> index 191b6bd5dff9..d0c0cbe1913d 100644
> --- a/lib/test_vmalloc.c
> +++ b/lib/test_vmalloc.c
> @@ -600,12 +600,7 @@ static int vmalloc_test_init(void)
> return -EAGAIN; /* Fail will directly unload the module */
> }
>
> -static void vmalloc_test_exit(void)
> -{
> -}
> -
> module_init(vmalloc_test_init)
> -module_exit(vmalloc_test_exit)
>
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Uladzislau Rezki");
> --
> 2.39.2
>
Reviewed-by: Uladzislau Rezki (Sony) <[email protected]>

--
Uladzislau Rezki