2024-02-24 00:50:19

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] crypto: ccp: Avoid discarding errors in psp_send_platform_access_msg()

On Tue, Feb 13, 2024 at 11:34:28AM -0600, Mario Limonciello wrote:
> Errors can potentially occur in the "processing" of PSP commands or
> commands can be processed successfully but still return an error code in
> the header.
>
> This second case was being discarded because PSP communication worked but
> the command returned an error code in the payload header.
>
> Capture both cases and return them to the caller as -EIO for the caller
> to investigate. The caller can detect the latter by looking at
> `req->header->status`.
>
> Reported-and-tested-by: Tim Van Patten <[email protected]>
> Fixes: 7ccc4f4e2e50 ("crypto: ccp - Add support for an interface for platform features")
> Signed-off-by: Mario Limonciello <[email protected]>
> ---
> v1->v2:
> * Update tag for Tim
> * Reword commit message
> ---
> drivers/crypto/ccp/platform-access.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)

All applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt