Hi,
thanks for your work getting the Intel IPU6 camera system - such as found
within my Dell Inc. XPS 9315 - to work with an upstream kernel. Much
appreciated!
On Linux 6.8.0-rc6+ (as of this morning, HEAD is at cf1182944c7c), though,
I get the following warning during boot with everything built into the
kernel:
------------[ cut here ]------------
do not call blocking ops when !TASK_RUNNING; state=2 set at [<000000003688dc79>] prepare_to_wait_event+0x54/0x1a0
WARNING: CPU: 5 PID: 122 at kernel/sched/core.c:10099 __might_sleep+0x59/0x60
Modules linked in:
CPU: 5 PID: 122 Comm: kworker/u24:3 Tainted: G T 6.8.0-rc6+ #2
Hardware name: Dell Inc. XPS 9315/00KRKP, BIOS 1.1.3 05/11/2022
Workqueue: events_unbound deferred_probe_work_func
RIP: 0010:__might_sleep+0x59/0x60
Code: ee 48 89 df 5b 31 d2 5d e9 24 fd ff ff 48 8b 90 80 15 00 00 48 c7 c7 a8 3f e3 a7 c6 05 03 9f 47 03 01 48 89 d1 e8 27 6b fb ff <0f> 0b eb d1 0f 1f 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90
RSP: 0018:ffffafd10122fa48 EFLAGS: 00010246
RAX: 0000000000000000 RBX: ffffffffa7d97bd7 RCX: 0000000000000000
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000000000eaa R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000001
R13: ffffa27506339628 R14: ffffa27505df3028 R15: 000000000122fb00
FS: 0000000000000000(0000) GS:ffffa27c6f680000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f44ac3df460 CR3: 0000000114480000 CR4: 0000000000f50ef0
PKRU: 55555554
Call Trace:
<TASK>
? __might_sleep+0x59/0x60
? __warn+0x80/0x170
? __might_sleep+0x59/0x60
? report_bug+0x182/0x1b0
? handle_bug+0x40/0x80
? exc_invalid_op+0x17/0x80
? asm_exc_invalid_op+0x1a/0x20
? __might_sleep+0x59/0x60
? __might_sleep+0x59/0x60
gpiod_get_value_cansleep+0x19/0x60
vsc_tp_xfer+0x177/0x570
? __pfx_autoremove_wake_function+0x10/0x10
mei_vsc_write+0xe5/0x1d0
mei_hbm_cl_connect_req+0x7d/0xd0
mei_cl_connect+0x399/0x460
mei_cldev_enable+0x97/0x1a0
mei_ace_probe+0x103/0x390
? kernfs_add_one+0x146/0x180
? really_probe+0x166/0x300
really_probe+0x166/0x300
? __pfx___device_attach_driver+0x10/0x10
__driver_probe_device+0x6e/0x120
driver_probe_device+0x1a/0x90
__device_attach_driver+0x8e/0xd0
bus_for_each_drv+0x90/0xf0
__device_attach+0xac/0x1a0
? process_one_work+0x19c/0x500
bus_probe_device+0x93/0xb0
? process_one_work+0x19c/0x500
deferred_probe_work_func+0x96/0xd0
process_one_work+0x205/0x500
worker_thread+0x1dc/0x3e0
? __pfx_worker_thread+0x10/0x10
kthread+0xea/0x120
? __pfx_kthread+0x10/0x10
ret_from_fork+0x2c/0x50
? __pfx_kthread+0x10/0x10
ret_from_fork_asm+0x1b/0x30
</TASK>
irq event stamp: 1179
hardirqs last enabled at (1185): [<ffffffffa50b61d8>] console_unlock+0x118/0x170
hardirqs last disabled at (1190): [<ffffffffa50b61bd>] console_unlock+0xfd/0x170
softirqs last enabled at (558): [<ffffffffa5012f8e>] irq_exit_rcu+0x7e/0xa0
softirqs last disabled at (551): [<ffffffffa5012f8e>] irq_exit_rcu+0x7e/0xa0
---[ end trace 0000000000000000 ]---
mei intel_vsc-5db76cf6-0a68-4ed6-9b78-0361635e2447: deferred probe pending: (reason unknown)
mei intel_vsc-92335fcf-3203-4472-af93-7b4453ac29da: deferred probe pending: (reason unknown)
Using modules for mei[_*], ivsc_ace and ivsc_csi, I get a slightly different
trace pointing to mei_vsc_probe():
------------[ cut here ]------------
do not call blocking ops when !TASK_RUNNING; state=2 set at [<00000000cd4cced5>] prepare_to_wait_event+0x54/0x1a0
WARNING: CPU: 3 PID: 335 at kernel/sched/core.c:10099 __might_sleep+0x59/0x60
Modules linked in: mei_vsc mei_hdcp mei_pxp mei_me mei mei_vsc_hw
CPU: 3 PID: 335 Comm: kworker/u24:5 Tainted: G T 6.8.0-rc6+ #1
Hardware name: Dell Inc. XPS 9315/00KRKP, BIOS 1.1.3 05/11/2022
Workqueue: events_unbound async_run_entry_fn
RIP: 0010:__might_sleep+0x59/0x60
Code: ee 48 89 df 5b 31 d2 5d e9 24 fd ff ff 48 8b 90 b8 15 00 00 48 c7 c7 38 b7 62 a9 c6 05 43 9b 47 03 01 48 89 d1 e8 67 6b fb ff <0f> 0b eb d1 0f 1f 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90
RSP: 0018:ffff9c2a86fa7b40 EFLAGS: 00010246
RAX: 0000000000000000 RBX: ffffffffa9590070 RCX: 0000000000000000
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000000000eaa R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000001
R13: ffff8fe0c6413028 R14: ffff8fe0ce4f2028 R15: 0000000086fa7c00
FS: 0000000000000000(0000) GS:ffff8fe82f580000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00005559a7dbc010 CR3: 000000031385c000 CR4: 0000000000f50ef0
PKRU: 55555554
Call Trace:
<TASK>
? __might_sleep+0x59/0x60
? __warn+0x80/0x170
? __might_sleep+0x59/0x60
? report_bug+0x182/0x1b0
? handle_bug+0x40/0x80
? exc_invalid_op+0x17/0x80
? asm_exc_invalid_op+0x1a/0x20
? __might_sleep+0x59/0x60
gpiod_get_value_cansleep+0x19/0x60
vsc_tp_xfer+0x177/0x570 [mei_vsc_hw]
? mei_me_cl_rm_all+0x25/0x90 [mei]
? __pfx_autoremove_wake_function+0x10/0x10
mei_vsc_write+0xe5/0x1d0 [mei_vsc]
mei_hbm_start_req+0x83/0xf0 [mei]
mei_reset+0x2af/0x4b0 [mei]
? mei_start+0x1c/0x110 [mei]
? rcu_read_lock_sched_held+0x42/0x80
mei_start+0x72/0x110 [mei]
mei_vsc_probe+0x9a/0x140 [mei_vsc]
platform_probe+0x3c/0x90
really_probe+0x166/0x300
? process_one_work+0x19c/0x500
__driver_probe_device+0x6e/0x120
driver_probe_device+0x1a/0x90
__driver_attach_async_helper+0x50/0xa0
async_run_entry_fn+0x24/0xc0
? process_one_work+0x19c/0x500
process_one_work+0x205/0x500
worker_thread+0x1dc/0x3e0
? __pfx_worker_thread+0x10/0x10
kthread+0xea/0x120
? __pfx_kthread+0x10/0x10
ret_from_fork+0x2c/0x50
? __pfx_kthread+0x10/0x10
ret_from_fork_asm+0x1b/0x30
</TASK>
irq event stamp: 1113943
hardirqs last enabled at (1113949): [<ffffffffa68b6308>] console_unlock+0x118/0x170
hardirqs last disabled at (1113954): [<ffffffffa68b62ed>] console_unlock+0xfd/0x170
softirqs last enabled at (1113130): [<ffffffffa68130be>] irq_exit_rcu+0x7e/0xa0
softirqs last disabled at (1113125): [<ffffffffa68130be>] irq_exit_rcu+0x7e/0xa0
---[ end trace 0000000000000000 ]---
Any ideas?
Best,
Dominik
Hi Dominik,
On Wed, Feb 28, 2024 at 06:41:38PM +0100, Dominik Brodowski wrote:
> Hi,
>
> thanks for your work getting the Intel IPU6 camera system - such as found
> within my Dell Inc. XPS 9315 - to work with an upstream kernel. Much
> appreciated!
>
> On Linux 6.8.0-rc6+ (as of this morning, HEAD is at cf1182944c7c), though,
> I get the following warning during boot with everything built into the
> kernel:
>
> ------------[ cut here ]------------
> do not call blocking ops when !TASK_RUNNING; state=2 set at [<000000003688dc79>] prepare_to_wait_event+0x54/0x1a0
> WARNING: CPU: 5 PID: 122 at kernel/sched/core.c:10099 __might_sleep+0x59/0x60
> Modules linked in:
> CPU: 5 PID: 122 Comm: kworker/u24:3 Tainted: G T 6.8.0-rc6+ #2
> Hardware name: Dell Inc. XPS 9315/00KRKP, BIOS 1.1.3 05/11/2022
> Workqueue: events_unbound deferred_probe_work_func
> RIP: 0010:__might_sleep+0x59/0x60
The issue should be fixed by this patch:
<URL:https://git.linuxtv.org/sailus/media_tree.git/commit/?h=ipu6&id=e2dc122949ce2efd05910c0c78617534c3258158>.
I've posted to the LKML, too, so hopefully we have it merged soon.
--
Regards,
Sakari Ailus
Hi Sakari,
many thanks, this patch helps. Another issue persists, though:
$ dmesg | cut -c16- | grep -E "(mei|vsc)"
mei_me 0000:00:16.0: enabling device (0000 -> 0002)
mei_hdcp 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops i915_hdcp_ops)
mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1: bound 0000:00:02.0 (ops i915_pxp_tee_component_ops)
intel_vsc intel_vsc: silicon stepping version is 0:2
mei intel_vsc-92335fcf-3203-4472-af93-7b4453ac29da: deferred probe pending: (reason unknown)
mei intel_vsc-5db76cf6-0a68-4ed6-9b78-0361635e2447: deferred probe pending: (reason unknown)
During suspend entry (s2idle), the following messages are emitted:
ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
intel_vsc intel_vsc: silicon stepping version is 0:2
PM: Some devices failed to suspend, or early wake event detected
ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
intel_vsc intel_vsc: silicon stepping version is 0:2
vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
intel_vsc intel_vsc: wait fw ready failed: -110
intel_vsc intel_vsc: hw_start failed ret = -110 fw status =
intel_vsc intel_vsc: unexpected reset: dev_state = RESETTING fw status =
ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
intel_vsc intel_vsc: silicon stepping version is 0:2
Any ideas?
Thanks,
Dominik
On Thu, Feb 29, 2024 at 08:21:42AM +0100, Dominik Brodowski wrote:
> Hi Sakari,
>
> many thanks, this patch helps. Another issue persists, though:
>
>
> $ dmesg | cut -c16- | grep -E "(mei|vsc)"
> mei_me 0000:00:16.0: enabling device (0000 -> 0002)
> mei_hdcp 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops i915_hdcp_ops)
> mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1: bound 0000:00:02.0 (ops i915_pxp_tee_component_ops)
> intel_vsc intel_vsc: silicon stepping version is 0:2
> mei intel_vsc-92335fcf-3203-4472-af93-7b4453ac29da: deferred probe pending: (reason unknown)
> mei intel_vsc-5db76cf6-0a68-4ed6-9b78-0361635e2447: deferred probe pending: (reason unknown)
You'll probably need the IPU bridge patches from that branch, too. Or you
can try removing the intel-ipu6 driver and modprobing it again.
>
>
> During suspend entry (s2idle), the following messages are emitted:
>
> ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> intel_vsc intel_vsc: silicon stepping version is 0:2
> PM: Some devices failed to suspend, or early wake event detected
> ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> intel_vsc intel_vsc: silicon stepping version is 0:2
> vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
> vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
> intel_vsc intel_vsc: wait fw ready failed: -110
> intel_vsc intel_vsc: hw_start failed ret = -110 fw status =
> intel_vsc intel_vsc: unexpected reset: dev_state = RESETTING fw status =
> ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> intel_vsc intel_vsc: silicon stepping version is 0:2
I haven't tried suspending. Is this while streaming or not?
--
Sakari Ailus
Hi Sakari,
Am Thu, Feb 29, 2024 at 07:30:33AM +0000 schrieb Sakari Ailus:
> On Thu, Feb 29, 2024 at 08:21:42AM +0100, Dominik Brodowski wrote:
> > Hi Sakari,
> >
> > many thanks, this patch helps. Another issue persists, though:
> >
> >
> > $ dmesg | cut -c16- | grep -E "(mei|vsc)"
> > mei_me 0000:00:16.0: enabling device (0000 -> 0002)
> > mei_hdcp 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops i915_hdcp_ops)
> > mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1: bound 0000:00:02.0 (ops i915_pxp_tee_component_ops)
> > intel_vsc intel_vsc: silicon stepping version is 0:2
> > mei intel_vsc-92335fcf-3203-4472-af93-7b4453ac29da: deferred probe pending: (reason unknown)
> > mei intel_vsc-5db76cf6-0a68-4ed6-9b78-0361635e2447: deferred probe pending: (reason unknown)
>
> You'll probably need the IPU bridge patches from that branch, too. Or you
> can try removing the intel-ipu6 driver and modprobing it again.
Everything is built into the kernel here - and the kernel I run is pure
upstream (plus your patch), therefore no intel-ipu6 driver is available
(yet) or active.
> > During suspend entry (s2idle), the following messages are emitted:
> >
> > ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> > intel_vsc intel_vsc: silicon stepping version is 0:2
> > PM: Some devices failed to suspend, or early wake event detected
> > ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> > intel_vsc intel_vsc: silicon stepping version is 0:2
> > vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
> > vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
> > intel_vsc intel_vsc: wait fw ready failed: -110
> > intel_vsc intel_vsc: hw_start failed ret = -110 fw status =
> > intel_vsc intel_vsc: unexpected reset: dev_state = RESETTING fw status =
> > ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> > intel_vsc intel_vsc: silicon stepping version is 0:2
>
> I haven't tried suspending. Is this while streaming or not?
No streaming - in fact, without intel-ipu6 available (upstream + your patch,
see above).
I have now tried upstream plus the ipu6 branch; there I get one message
indicating that something is amiss:
vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
And if I try to do a suspend&resume cycle, the machine hangs. A longer
snippet from dmesg from upstream+ipu6 branch:
mei_me 0000:00:16.0: enabling device (0000 -> 0002)
mei_hdcp 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops i915_hdcp_ops)
mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1: bound 0000:00:02.0 (ops i915_pxp_tee_component_ops)
intel-ipu6 0000:00:05.0: enabling device (0000 -> 0002)
intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
intel-ipu6 0000:00:05.0: FW version: 20230925
intel_vsc intel_vsc: silicon stepping version is 0:2
intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
intel-ipu6 0000:00:05.0: FW version: 20230925
intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
intel-ipu6 0000:00:05.0: FW version: 20230925
intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
intel-ipu6 0000:00:05.0: FW version: 20230925
intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
intel-ipu6 0000:00:05.0: FW version: 20230925
intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
intel-ipu6 0000:00:05.0: FW version: 20230925
intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
intel-ipu6 0000:00:05.0: FW version: 20230925
intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
intel-ipu6 0000:00:05.0: FW version: 20230925
intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
intel-ipu6 0000:00:05.0: FW version: 20230925
intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
intel-ipu6 0000:00:05.0: FW version: 20230925
vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
intel-ipu6 0000:00:05.0: FW version: 20230925
intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
intel-ipu6 0000:00:05.0: FW version: 20230925
intel-ipu6 0000:00:05.0: Found supported sensor OVTI01A0:00
intel-ipu6 0000:00:05.0: Connected 1 cameras
intel-ipu6 0000:00:05.0: IPU6-v3[465d] hardware version 5
Best,
Dominik
Hi Dominik,
On Thu, Feb 29, 2024 at 05:53:34PM +0100, Dominik Brodowski wrote:
> Hi Sakari,
>
> Am Thu, Feb 29, 2024 at 07:30:33AM +0000 schrieb Sakari Ailus:
> > On Thu, Feb 29, 2024 at 08:21:42AM +0100, Dominik Brodowski wrote:
> > > Hi Sakari,
> > >
> > > many thanks, this patch helps. Another issue persists, though:
> > >
> > >
> > > $ dmesg | cut -c16- | grep -E "(mei|vsc)"
> > > mei_me 0000:00:16.0: enabling device (0000 -> 0002)
> > > mei_hdcp 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops i915_hdcp_ops)
> > > mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1: bound 0000:00:02.0 (ops i915_pxp_tee_component_ops)
> > > intel_vsc intel_vsc: silicon stepping version is 0:2
> > > mei intel_vsc-92335fcf-3203-4472-af93-7b4453ac29da: deferred probe pending: (reason unknown)
> > > mei intel_vsc-5db76cf6-0a68-4ed6-9b78-0361635e2447: deferred probe pending: (reason unknown)
> >
> > You'll probably need the IPU bridge patches from that branch, too. Or you
> > can try removing the intel-ipu6 driver and modprobing it again.
>
> Everything is built into the kernel here - and the kernel I run is pure
> upstream (plus your patch), therefore no intel-ipu6 driver is available
> (yet) or active.
>
> > > During suspend entry (s2idle), the following messages are emitted:
> > >
> > > ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> > > intel_vsc intel_vsc: silicon stepping version is 0:2
> > > PM: Some devices failed to suspend, or early wake event detected
> > > ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> > > intel_vsc intel_vsc: silicon stepping version is 0:2
> > > vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
> > > vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
> > > intel_vsc intel_vsc: wait fw ready failed: -110
> > > intel_vsc intel_vsc: hw_start failed ret = -110 fw status =
> > > intel_vsc intel_vsc: unexpected reset: dev_state = RESETTING fw status =
> > > ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> > > intel_vsc intel_vsc: silicon stepping version is 0:2
> >
> > I haven't tried suspending. Is this while streaming or not?
>
> No streaming - in fact, without intel-ipu6 available (upstream + your patch,
> see above).
>
>
> I have now tried upstream plus the ipu6 branch; there I get one message
> indicating that something is amiss:
>
> vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
>
> And if I try to do a suspend&resume cycle, the machine hangs. A longer
> snippet from dmesg from upstream+ipu6 branch:
>
> mei_me 0000:00:16.0: enabling device (0000 -> 0002)
> mei_hdcp 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops i915_hdcp_ops)
> mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1: bound 0000:00:02.0 (ops i915_pxp_tee_component_ops)
> intel-ipu6 0000:00:05.0: enabling device (0000 -> 0002)
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel_vsc intel_vsc: silicon stepping version is 0:2
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: Found supported sensor OVTI01A0:00
> intel-ipu6 0000:00:05.0: Connected 1 cameras
> intel-ipu6 0000:00:05.0: IPU6-v3[465d] hardware version 5
I haven't tried suspending but I know Wentong has. So this is odd.
Which system do you have? Could you provide your .config?
--
Regards,
Sakari Ailus
Hi Sakari,
Am Tue, Mar 05, 2024 at 07:32:46AM +0000 schrieb Sakari Ailus:
> Hi Dominik,
>
> On Thu, Feb 29, 2024 at 05:53:34PM +0100, Dominik Brodowski wrote:
> > Hi Sakari,
> >
> > Am Thu, Feb 29, 2024 at 07:30:33AM +0000 schrieb Sakari Ailus:
> > > On Thu, Feb 29, 2024 at 08:21:42AM +0100, Dominik Brodowski wrote:
> > > > Hi Sakari,
> > > >
> > > > many thanks, this patch helps. Another issue persists, though:
> > > >
> > > >
> > > > $ dmesg | cut -c16- | grep -E "(mei|vsc)"
> > > > mei_me 0000:00:16.0: enabling device (0000 -> 0002)
> > > > mei_hdcp 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops i915_hdcp_ops)
> > > > mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1: bound 0000:00:02.0 (ops i915_pxp_tee_component_ops)
> > > > intel_vsc intel_vsc: silicon stepping version is 0:2
> > > > mei intel_vsc-92335fcf-3203-4472-af93-7b4453ac29da: deferred probe pending: (reason unknown)
> > > > mei intel_vsc-5db76cf6-0a68-4ed6-9b78-0361635e2447: deferred probe pending: (reason unknown)
> > >
> > > You'll probably need the IPU bridge patches from that branch, too. Or you
> > > can try removing the intel-ipu6 driver and modprobing it again.
> >
> > Everything is built into the kernel here - and the kernel I run is pure
> > upstream (plus your patch), therefore no intel-ipu6 driver is available
> > (yet) or active.
> >
> > > > During suspend entry (s2idle), the following messages are emitted:
> > > >
> > > > ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> > > > intel_vsc intel_vsc: silicon stepping version is 0:2
> > > > PM: Some devices failed to suspend, or early wake event detected
> > > > ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> > > > intel_vsc intel_vsc: silicon stepping version is 0:2
> > > > vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
> > > > vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
> > > > intel_vsc intel_vsc: wait fw ready failed: -110
> > > > intel_vsc intel_vsc: hw_start failed ret = -110 fw status =
> > > > intel_vsc intel_vsc: unexpected reset: dev_state = RESETTING fw status =
> > > > ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> > > > intel_vsc intel_vsc: silicon stepping version is 0:2
> > >
> > > I haven't tried suspending. Is this while streaming or not?
> >
> > No streaming - in fact, without intel-ipu6 available (upstream + your patch,
> > see above).
> >
> >
> > I have now tried upstream plus the ipu6 branch; there I get one message
> > indicating that something is amiss:
> >
> > vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
> >
> > And if I try to do a suspend&resume cycle, the machine hangs. A longer
> > snippet from dmesg from upstream+ipu6 branch:
> >
> > mei_me 0000:00:16.0: enabling device (0000 -> 0002)
> > mei_hdcp 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops i915_hdcp_ops)
> > mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1: bound 0000:00:02.0 (ops i915_pxp_tee_component_ops)
> > intel-ipu6 0000:00:05.0: enabling device (0000 -> 0002)
> > intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> > intel-ipu6 0000:00:05.0: FW version: 20230925
> > intel_vsc intel_vsc: silicon stepping version is 0:2
> > intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> > intel-ipu6 0000:00:05.0: FW version: 20230925
> > intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> > intel-ipu6 0000:00:05.0: FW version: 20230925
> > intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> > intel-ipu6 0000:00:05.0: FW version: 20230925
> > intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> > intel-ipu6 0000:00:05.0: FW version: 20230925
> > intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> > intel-ipu6 0000:00:05.0: FW version: 20230925
> > intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> > intel-ipu6 0000:00:05.0: FW version: 20230925
> > intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> > intel-ipu6 0000:00:05.0: FW version: 20230925
> > intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> > intel-ipu6 0000:00:05.0: FW version: 20230925
> > intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> > intel-ipu6 0000:00:05.0: FW version: 20230925
> > vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
> > intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> > intel-ipu6 0000:00:05.0: FW version: 20230925
> > intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> > intel-ipu6 0000:00:05.0: FW version: 20230925
> > intel-ipu6 0000:00:05.0: Found supported sensor OVTI01A0:00
> > intel-ipu6 0000:00:05.0: Connected 1 cameras
> > intel-ipu6 0000:00:05.0: IPU6-v3[465d] hardware version 5
>
> I haven't tried suspending but I know Wentong has. So this is odd.
>
> Which system do you have? Could you provide your .config?
Certainly! It's a Dell XPS 13 (9315), and the config is attached.
Best,
Dominik
Hi Dominik,
Did you try master branch (v6.8) without IPU6 driver? There
should be problems with the IPU6 driver you use as below:
> intel-ipu6 0000:00:05.0: Found supported sensor OVTI01A0:00
> intel-ipu6 0000:00:05.0: Connected 1 cameras
If not, could you please help try it on your side? Thanks a lot
BR,
Wentong
> From: Dominik Brodowski <[email protected]>
>
> Hi Sakari,
>
> Am Thu, Feb 29, 2024 at 07:30:33AM +0000 schrieb Sakari Ailus:
> > On Thu, Feb 29, 2024 at 08:21:42AM +0100, Dominik Brodowski wrote:
> > > Hi Sakari,
> > >
> > > many thanks, this patch helps. Another issue persists, though:
> > >
> > >
> > > $ dmesg | cut -c16- | grep -E "(mei|vsc)"
> > > mei_me 0000:00:16.0: enabling device (0000 -> 0002) mei_hdcp
> > > 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound
> > > 0000:00:02.0 (ops i915_hdcp_ops) mei_pxp
> > > 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1: bound
> > > 0000:00:02.0 (ops i915_pxp_tee_component_ops) intel_vsc intel_vsc:
> > > silicon stepping version is 0:2 mei
> > > intel_vsc-92335fcf-3203-4472-af93-7b4453ac29da: deferred probe
> > > pending: (reason unknown) mei
> > > intel_vsc-5db76cf6-0a68-4ed6-9b78-0361635e2447: deferred probe
> > > pending: (reason unknown)
> >
> > You'll probably need the IPU bridge patches from that branch, too. Or
> > you can try removing the intel-ipu6 driver and modprobing it again.
>
> Everything is built into the kernel here - and the kernel I run is pure
> upstream (plus your patch), therefore no intel-ipu6 driver is available
> (yet) or active.
>
> > > During suspend entry (s2idle), the following messages are emitted:
> > >
> > > ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments -
> > > Caller passed 0, method requires 1 (20230628/nsarguments-232)
> > > intel_vsc intel_vsc: silicon stepping version is 0:2
> > > PM: Some devices failed to suspend, or early wake event detected
> > > ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments -
> > > Caller passed 0, method requires 1 (20230628/nsarguments-232)
> > > intel_vsc intel_vsc: silicon stepping version is 0:2 vsc-tp
> > > spi-INTC1094:00: wakeup firmware failed ret: -110 vsc-tp
> > > spi-INTC1094:00: wakeup firmware failed ret: -110 intel_vsc
> > > intel_vsc: wait fw ready failed: -110 intel_vsc intel_vsc: hw_start
> > > failed ret = -110 fw status = intel_vsc intel_vsc: unexpected reset:
> > > dev_state = RESETTING fw status = ACPI Warning:
> > > \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed
> > > 0, method requires 1 (20230628/nsarguments-232) intel_vsc intel_vsc:
> > > silicon stepping version is 0:2
> >
> > I haven't tried suspending. Is this while streaming or not?
>
> No streaming - in fact, without intel-ipu6 available (upstream + your patch,
> see above).
>
>
> I have now tried upstream plus the ipu6 branch; there I get one message
> indicating that something is amiss:
>
> vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
>
> And if I try to do a suspend&resume cycle, the machine hangs. A longer
> snippet from dmesg from upstream+ipu6 branch:
>
> mei_me 0000:00:16.0: enabling device (0000 -> 0002) mei_hdcp 0000:00:16.0-
> b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops
> i915_hdcp_ops) mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-
> 1bab8cbe36b1: bound 0000:00:02.0 (ops i915_pxp_tee_component_ops)
> intel-ipu6 0000:00:05.0: enabling device (0000 -> 0002)
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925 intel_vsc intel_vsc: silicon
> stepping version is 0:2
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925 vsc-tp spi-INTC1094:00:
> wakeup firmware failed ret: -110
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: Found supported sensor OVTI01A0:00
> intel-ipu6 0000:00:05.0: Connected 1 cameras
> intel-ipu6 0000:00:05.0: IPU6-v3[465d] hardware version 5
>
>
> Best,
> Dominik
Hi Wetong,
Am Fri, Mar 08, 2024 at 11:45:44PM +0000 schrieb Wu, Wentong:
> Did you try master branch (v6.8) without IPU6 driver? There
> should be problems with the IPU6 driver you use as below:
>
> > intel-ipu6 0000:00:05.0: Found supported sensor OVTI01A0:00
> > intel-ipu6 0000:00:05.0: Connected 1 cameras
>
> If not, could you please help try it on your side?
Branch master from https://git.linuxtv.org/sailus/media_tree.git/ causes a
WARNING during boot; some extracts from dmesg:
mei_me 0000:00:16.0: enabling device (0000 -> 0002)
mei_hdcp 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops i915_hdcp_ops)
mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1: bound 0000:00:02.0 (ops i915_pxp_tee_component_ops)
intel_vsc intel_vsc: silicon stepping version is 0:2
------------[ cut here ]------------
do not call blocking ops when !TASK_RUNNING; state=2 set at [<000000001b97ea26>] prepare_to_wait_event+0x54/0x1a0
WARNING: CPU: 5 PID: 124 at kernel/sched/core.c:10099 __might_sleep+0x59/0x60
Modules linked in:
CPU: 5 PID: 124 Comm: kworker/u24:2 Tainted: G T 6.8.0-rc2+ #2
Hardware name: Dell Inc. XPS 9315/00KRKP, BIOS 1.1.3 05/11/2022
Workqueue: events_unbound deferred_probe_work_func
RIP: 0010:__might_sleep+0x59/0x60
Code: ee 48 89 df 5b 31 d2 5d e9 24 fd ff ff 48 8b 90 60 15 00 00 48 c7 c7 a8 3e aa 84 c6 05 6f b3 47 03 01 48 89 d1 e8 b7 6c fb ff <0f> 0b eb d1 0f 1f 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90
RSP: 0018:ffffbd3ec1287a98 EFLAGS: 00010246
RAX: 0000000000000000 RBX: ffffffff84a07d0f RCX: 0000000000000000
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000000000ea5 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000001
R13: ffffa224892a3028 R14: ffffa22494ac1028 R15: 00000000c1287b00
FS: 0000000000000000(0000) GS:ffffa22bef680000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000557ffdf03148 CR3: 00000002b645c000 CR4: 0000000000f50ef0
PKRU: 55555554
Call Trace:
<TASK>
? __might_sleep+0x59/0x60
? __warn+0x80/0x170
? __might_sleep+0x59/0x60
? report_bug+0x182/0x1b0
? handle_bug+0x40/0x80
? exc_invalid_op+0x17/0x80
? asm_exc_invalid_op+0x1a/0x20
? __might_sleep+0x59/0x60
? __might_sleep+0x59/0x60
gpiod_get_value_cansleep+0x19/0x60
vsc_tp_xfer+0x177/0x570
? __pfx_autoremove_wake_function+0x10/0x10
mei_vsc_write+0xe5/0x1d0
mei_hbm_cl_flow_control_req+0x84/0xd0
mei_cl_read_start+0x23b/0x330
mei_cldev_register_rx_cb+0xf5/0x140
mei_ace_probe+0x11f/0x390
? kernfs_add_one+0x146/0x180
? really_probe+0x166/0x300
really_probe+0x166/0x300
? __pfx___device_attach_driver+0x10/0x10
__driver_probe_device+0x6e/0x120
driver_probe_device+0x1a/0x90
__device_attach_driver+0x8e/0xd0
bus_for_each_drv+0x90/0xf0
__device_attach+0xac/0x1a0
? process_one_work+0x19c/0x500
bus_probe_device+0x93/0xb0
? process_one_work+0x19c/0x500
deferred_probe_work_func+0x96/0xd0
process_one_work+0x205/0x500
worker_thread+0x1dc/0x3e0
? __pfx_worker_thread+0x10/0x10
kthread+0xea/0x120
? __pfx_kthread+0x10/0x10
ret_from_fork+0x2c/0x50
? __pfx_kthread+0x10/0x10
ret_from_fork_asm+0x1b/0x30
</TASK>
irq event stamp: 1166879
hardirqs last enabled at (1166885): [<ffffffff81cb6348>] console_unlock+0x118/0x170
hardirqs last disabled at (1166890): [<ffffffff81cb632d>] console_unlock+0xfd/0x170
softirqs last enabled at (1166640): [<ffffffff81c1333e>] irq_exit_rcu+0x7e/0xa0
softirqs last disabled at (1166635): [<ffffffff81c1333e>] irq_exit_rcu+0x7e/0xa0
---[ end trace 0000000000000000 ]---
mei intel_vsc-5db76cf6-0a68-4ed6-9b78-0361635e2447: deferred probe pending: (reason unknown)
mei intel_vsc-92335fcf-3203-4472-af93-7b4453ac29da: deferred probe pending: (reason unknown)
Best,
Dominik
> From: Dominik Brodowski <[email protected]>
>
> Hi Wetong,
>
> Am Fri, Mar 08, 2024 at 11:45:44PM +0000 schrieb Wu, Wentong:
> > Did you try master branch (v6.8) without IPU6 driver? There should be
> > problems with the IPU6 driver you use as below:
> >
> > > intel-ipu6 0000:00:05.0: Found supported sensor OVTI01A0:00
> > > intel-ipu6 0000:00:05.0: Connected 1 cameras
> >
> > If not, could you please help try it on your side?
>
> Branch master from https://git.linuxtv.org/sailus/media_tree.git/ causes a
> WARNING during boot; some extracts from dmesg:
Thanks for your help, I think this has been fix by below patch:
<URL: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/misc/mei/vsc-tp.c?id=b8b19acfafdeacbedd4e2795cb18c81c4d8bb6cc>
how about the suspend and resume scenario with media_tree master
branch (which doesn't merge IPU6 driver) plus this patch?
I will test it as well next Monday I get to office.
BR,
Wentong
>
> mei_me 0000:00:16.0: enabling device (0000 -> 0002) mei_hdcp 0000:00:16.0-
> b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops
> i915_hdcp_ops) mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-
> 1bab8cbe36b1: bound 0000:00:02.0 (ops i915_pxp_tee_component_ops)
> intel_vsc intel_vsc: silicon stepping version is 0:2 ------------[ cut here ]------------
> do not call blocking ops when !TASK_RUNNING; state=2 set at
> [<000000001b97ea26>] prepare_to_wait_event+0x54/0x1a0
> WARNING: CPU: 5 PID: 124 at kernel/sched/core.c:10099
> __might_sleep+0x59/0x60 Modules linked in:
> CPU: 5 PID: 124 Comm: kworker/u24:2 Tainted: G T 6.8.0-rc2+ #2
> Hardware name: Dell Inc. XPS 9315/00KRKP, BIOS 1.1.3 05/11/2022
> Workqueue: events_unbound deferred_probe_work_func
> RIP: 0010:__might_sleep+0x59/0x60
> Code: ee 48 89 df 5b 31 d2 5d e9 24 fd ff ff 48 8b 90 60 15 00 00 48 c7 c7 a8
> 3e aa 84 c6 05 6f b3 47 03 01 48 89 d1 e8 b7 6c fb ff <0f> 0b eb d1 0f 1f 00 90
> 90 90 90 90 90 90 90 90 90 90 90 90 90 90
> RSP: 0018:ffffbd3ec1287a98 EFLAGS: 00010246
> RAX: 0000000000000000 RBX: ffffffff84a07d0f RCX: 0000000000000000
> RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
> RBP: 0000000000000ea5 R08: 0000000000000000 R09: 0000000000000000
> R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000001
> R13: ffffa224892a3028 R14: ffffa22494ac1028 R15: 00000000c1287b00
> FS: 0000000000000000(0000) GS:ffffa22bef680000(0000)
> knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 0000557ffdf03148 CR3: 00000002b645c000 CR4: 0000000000f50ef0
> PKRU: 55555554
> Call Trace:
> <TASK>
> ? __might_sleep+0x59/0x60
> ? __warn+0x80/0x170
> ? __might_sleep+0x59/0x60
> ? report_bug+0x182/0x1b0
> ? handle_bug+0x40/0x80
> ? exc_invalid_op+0x17/0x80
> ? asm_exc_invalid_op+0x1a/0x20
> ? __might_sleep+0x59/0x60
> ? __might_sleep+0x59/0x60
> gpiod_get_value_cansleep+0x19/0x60
> vsc_tp_xfer+0x177/0x570
> ? __pfx_autoremove_wake_function+0x10/0x10
> mei_vsc_write+0xe5/0x1d0
> mei_hbm_cl_flow_control_req+0x84/0xd0
> mei_cl_read_start+0x23b/0x330
> mei_cldev_register_rx_cb+0xf5/0x140
> mei_ace_probe+0x11f/0x390
> ? kernfs_add_one+0x146/0x180
> ? really_probe+0x166/0x300
> really_probe+0x166/0x300
> ? __pfx___device_attach_driver+0x10/0x10
> __driver_probe_device+0x6e/0x120
> driver_probe_device+0x1a/0x90
> __device_attach_driver+0x8e/0xd0
> bus_for_each_drv+0x90/0xf0
> __device_attach+0xac/0x1a0
> ? process_one_work+0x19c/0x500
> bus_probe_device+0x93/0xb0
> ? process_one_work+0x19c/0x500
> deferred_probe_work_func+0x96/0xd0
> process_one_work+0x205/0x500
> worker_thread+0x1dc/0x3e0
> ? __pfx_worker_thread+0x10/0x10
> kthread+0xea/0x120
> ? __pfx_kthread+0x10/0x10
> ret_from_fork+0x2c/0x50
> ? __pfx_kthread+0x10/0x10
> ret_from_fork_asm+0x1b/0x30
> </TASK>
> irq event stamp: 1166879
> hardirqs last enabled at (1166885): [<ffffffff81cb6348>]
> console_unlock+0x118/0x170 hardirqs last disabled at (1166890):
> [<ffffffff81cb632d>] console_unlock+0xfd/0x170 softirqs last enabled at
> (1166640): [<ffffffff81c1333e>] irq_exit_rcu+0x7e/0xa0 softirqs last disabled
> at (1166635): [<ffffffff81c1333e>] irq_exit_rcu+0x7e/0xa0 ---[ end trace
> 0000000000000000 ]--- mei intel_vsc-5db76cf6-0a68-4ed6-9b78-
> 0361635e2447: deferred probe pending: (reason unknown) mei intel_vsc-
> 92335fcf-3203-4472-af93-7b4453ac29da: deferred probe pending: (reason
> unknown)
>
>
> Best,
> Dominik
Am Sun, Mar 10, 2024 at 01:33:49AM +0000 schrieb Wu, Wentong:
> > From: Dominik Brodowski <[email protected]>
> >
> > Hi Wetong,
> >
> > Am Fri, Mar 08, 2024 at 11:45:44PM +0000 schrieb Wu, Wentong:
> > > Did you try master branch (v6.8) without IPU6 driver? There should be
> > > problems with the IPU6 driver you use as below:
> > >
> > > > intel-ipu6 0000:00:05.0: Found supported sensor OVTI01A0:00
> > > > intel-ipu6 0000:00:05.0: Connected 1 cameras
> > >
> > > If not, could you please help try it on your side?
> >
> > Branch master from https://git.linuxtv.org/sailus/media_tree.git/ causes a
> > WARNING during boot; some extracts from dmesg:
>
> Thanks for your help, I think this has been fix by below patch:
> <URL: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/misc/mei/vsc-tp.c?id=b8b19acfafdeacbedd4e2795cb18c81c4d8bb6cc>
.. which isn't in the master branch of git.linuxtv.org/sailus/media_tree.git
I've now taken Linus' tree of today, merged in char-misc-next, merged in
the media_tree, and applied a fixup patch (see bottom of the message).
Booting this kernel, there is no WARNING during boot, and I can suspend and
resume. However, please note the warnings/failures and the long delays
between suspend entry and exit during the first (two) suspend/resume cycles:
[ 107.696067] PM: suspend entry (s2idle)
[ 107.701258] Filesystems sync: 0.005 seconds
[ 107.818367] Freezing user space processes
[ 107.822954] Freezing user space processes completed (elapsed 0.004 seconds)
[ 107.822979] OOM killer disabled.
[ 107.822980] Freezing remaining freezable tasks
[ 107.825672] Freezing remaining freezable tasks completed (elapsed 0.002 seconds)
[ 107.825834] printk: Suspending console(s) (use no_console_suspend to debug)
[ 108.186987] ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
[ 108.192890] intel_vsc intel_vsc: silicon stepping version is 0:2
[ 119.661371] PM: Some devices failed to suspend, or early wake event detected
[ 119.696726] ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
[ 119.702358] intel_vsc intel_vsc: silicon stepping version is 0:2
[ 133.493790] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
[ 135.541436] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
[ 135.541823] intel_vsc intel_vsc: wait fw ready failed: -110
[ 135.541832] intel_vsc intel_vsc: hw_start failed ret = -110 fw status =
[ 135.543616] intel_vsc intel_vsc: unexpected reset: dev_state = RESETTING fw status =
[ 135.580522] ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
[ 135.584170] intel_vsc intel_vsc: silicon stepping version is 0:2
[ 135.635935] OOM killer enabled.
[ 135.635940] Restarting tasks ... done.
[ 135.863803] PM: suspend exit
I seem to have pressed the power butten often enough to initiate a second suspend/resume cycle immediately:
[ 135.864196] PM: suspend entry (s2idle)
[ 135.875238] Filesystems sync: 0.011 seconds
[ 135.879306] Freezing user space processes
[ 135.883869] Freezing user space processes completed (elapsed 0.004 seconds)
[ 135.883881] OOM killer disabled.
[ 135.883884] Freezing remaining freezable tasks
[ 135.886107] Freezing remaining freezable tasks completed (elapsed 0.002 seconds)
[ 135.886112] printk: Suspending console(s) (use no_console_suspend to debug)
[ 149.173274] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
[ 151.221491] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
[ 151.221784] intel_vsc intel_vsc: wait fw ready failed: -110
[ 151.221793] intel_vsc intel_vsc: hw_start failed ret = -110 fw status =
[ 151.222752] intel_vsc intel_vsc: unexpected reset: dev_state = RESETTING fw status =
[ 151.256758] ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
[ 151.262174] intel_vsc intel_vsc: silicon stepping version is 0:2
[ 164.853425] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
[ 166.901441] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
[ 166.901772] intel_vsc intel_vsc: wait fw ready failed: -110
[ 166.901779] intel_vsc intel_vsc: hw_start failed ret = -110 fw status =
[ 166.904282] intel_vsc intel_vsc: reset: reached maximal consecutive resets: disabling the device
[ 166.904290] intel_vsc intel_vsc: device disabled = -19
[ 166.904665] intel_vsc intel_vsc: reset: reached maximal consecutive resets: disabling the device
[ 166.904712] PM: Some devices failed to suspend, or early wake event detected
[ 166.940695] ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
[ 166.946175] intel_vsc intel_vsc: silicon stepping version is 0:2
[ 181.045504] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
[ 183.093514] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
[ 183.093898] intel_vsc intel_vsc: wait fw ready failed: -110
[ 183.093912] intel_vsc intel_vsc: hw_start failed ret = -110 fw status =
[ 183.094507] intel_vsc intel_vsc: unexpected reset: dev_state = RESETTING fw status =
[ 183.129467] ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
[ 183.132830] intel_vsc intel_vsc: silicon stepping version is 0:2
[ 183.135905] OOM killer enabled.
[ 183.135909] Restarting tasks ... done.
[ 183.372915] PM: suspend exit
Subsequent suspend/resume operations continue to emit warnings/failures related to intel_vsc:
[ 341.554095] PM: suspend entry (s2idle)
[ 341.559387] Filesystems sync: 0.005 seconds
[ 341.673175] Freezing user space processes
[ 341.679061] Freezing user space processes completed (elapsed 0.005 seconds)
[ 341.679069] OOM killer disabled.
[ 341.679071] Freezing remaining freezable tasks
[ 341.680652] Freezing remaining freezable tasks completed (elapsed 0.001 seconds)
[ 341.680656] printk: Suspending console(s) (use no_console_suspend to debug)
[ 341.861251] intel_vsc intel_vsc: reset: reached maximal consecutive resets: disabling the device
[ 342.065565] ACPI: EC: interrupt blocked
[ 342.855083] ACPI: EC: interrupt unblocked
[ 343.039446] i915 0000:00:02.0: [drm] GT0: GuC firmware i915/adlp_guc_70.bin version 70.20.0
[ 343.039458] i915 0000:00:02.0: [drm] GT0: HuC firmware i915/tgl_huc.bin version 7.9.3
[ 343.064550] i915 0000:00:02.0: [drm] GT0: HuC: authenticated for all workloads
[ 343.065807] i915 0000:00:02.0: [drm] GT0: GUC: submission enabled
[ 343.065811] i915 0000:00:02.0: [drm] GT0: GUC: SLPC enabled
[ 343.066305] i915 0000:00:02.0: [drm] GT0: GUC: RC enabled
[ 343.124628] nvme nvme0: 8/0/0 default/read/poll queues
[ 343.385084] ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
[ 343.389309] intel_vsc intel_vsc: silicon stepping version is 0:2
[ 356.946491] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
[ 358.996072] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
[ 358.996432] intel_vsc intel_vsc: wait fw ready failed: -110
[ 358.996446] intel_vsc intel_vsc: hw_start failed ret = -110 fw status =
[ 358.997008] intel_vsc intel_vsc: unexpected reset: dev_state = RESETTING fw status =
[ 359.031049] ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
[ 359.035795] intel_vsc intel_vsc: silicon stepping version is 0:2
[ 359.051336] mei_hdcp 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops i915_hdcp_ops)
[ 359.051432] OOM killer enabled.
[ 359.051435] Restarting tasks ...
[ 359.052195] mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1: bound 0000:00:02.0 (ops i915_pxp_tee_component_ops)
[ 359.056184] done.
[ 359.309627] PM: suspend exit
[ 372.188053] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
[ 374.364551] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
[ 374.364749] intel_vsc intel_vsc: wait fw ready failed: -110
[ 374.364755] intel_vsc intel_vsc: hw_start failed ret = -110 fw status =
[ 374.364778] intel_vsc intel_vsc: unexpected reset: dev_state = RESETTING fw status =
[ 374.399149] ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
[ 374.406099] intel_vsc intel_vsc: silicon stepping version is 0:2
[ 387.747776] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
[ 389.924474] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
[ 390.045250] intel_vsc intel_vsc: wait fw ready failed: -110
[ 390.045260] intel_vsc intel_vsc: hw_start failed ret = -110 fw status =
[ 390.045294] intel_vsc intel_vsc: unexpected reset: dev_state = RESETTING fw status =
[ 390.045297] intel_vsc intel_vsc: reset: reached maximal consecutive resets: disabling the device
[ 390.045324] intel_vsc intel_vsc: device disabled = -19
Best,
Dominik
---
Subject: [PATCH] media: v4l: async: remove unused variable
ret is unused in v4l2_async_nf_register()
Signed-off-by: Dominik Brodowski <[email protected]>
diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
index a722c5eb3230..3b43d6285dfe 100644
--- a/drivers/media/v4l2-core/v4l2-async.c
+++ b/drivers/media/v4l2-core/v4l2-async.c
@@ -620,8 +620,6 @@ static int __v4l2_async_nf_register(struct v4l2_async_notifier *notifier)
int v4l2_async_nf_register(struct v4l2_async_notifier *notifier)
{
- int ret;
-
if (WARN_ON(!notifier->v4l2_dev == !notifier->sd))
return -EINVAL;
> From: Dominik Brodowski <[email protected]>
> Am Sun, Mar 10, 2024 at 01:33:49AM +0000 schrieb Wu, Wentong:
> > > From: Dominik Brodowski <[email protected]>
> > >
> > > Hi Wetong,
> > >
> > > Am Fri, Mar 08, 2024 at 11:45:44PM +0000 schrieb Wu, Wentong:
> > > > Did you try master branch (v6.8) without IPU6 driver? There should
> > > > be problems with the IPU6 driver you use as below:
> > > >
> > > > > intel-ipu6 0000:00:05.0: Found supported sensor OVTI01A0:00
> > > > > intel-ipu6 0000:00:05.0: Connected 1 cameras
> > > >
> > > > If not, could you please help try it on your side?
> > >
> > > Branch master from https://git.linuxtv.org/sailus/media_tree.git/
> > > causes a WARNING during boot; some extracts from dmesg:
> >
> > Thanks for your help, I think this has been fix by below patch:
> > <URL:
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/co
> > mmit/drivers/misc/mei/vsc-
> tp.c?id=b8b19acfafdeacbedd4e2795cb18c81c4d8b
> > b6cc>
>
> ... which isn't in the master branch of git.linuxtv.org/sailus/media_treegit
> . I've now taken Linus' tree of today, merged in char-misc-next, merged in the
> media_tree, and applied a fixup patch (see bottom of the message).
>
> Booting this kernel, there is no WARNING during boot, and I can suspend
> and resume. However, please note the warnings/failures and the long delays
> between suspend entry and exit during the first (two) suspend/resume
> cycles:
Thanks
I believe this has been fixed by the patch
https://www.spinics.net/lists/kernel/msg5146202.html
and I have tested it on my setup, could you please try it (without IPU6 driver)
on your end to double confirm and ack the patch?
BR,
Wentong
>
> [ 107.696067] PM: suspend entry (s2idle) [ 107.701258] Filesystems sync:
> 0.005 seconds [ 107.818367] Freezing user space processes [ 107.822954]
> Freezing user space processes completed (elapsed 0.004 seconds)
> [ 107.822979] OOM killer disabled.
> [ 107.822980] Freezing remaining freezable tasks [ 107.825672] Freezing
> remaining freezable tasks completed (elapsed 0.002 seconds) [ 107.825834]
> printk: Suspending console(s) (use no_console_suspend to debug)
> [ 108.186987] ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient
> arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> [ 108.192890] intel_vsc intel_vsc: silicon stepping version is 0:2 [ 119.661371]
> PM: Some devices failed to suspend, or early wake event detected
> [ 119.696726] ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient
> arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> [ 119.702358] intel_vsc intel_vsc: silicon stepping version is 0:2 [ 133.493790]
> vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110 [ 135.541436] vsc-tp
> spi-INTC1094:00: wakeup firmware failed ret: -110 [ 135.541823] intel_vsc
> intel_vsc: wait fw ready failed: -110 [ 135.541832] intel_vsc intel_vsc:
> hw_start failed ret = -110 fw status = [ 135.543616] intel_vsc intel_vsc:
> unexpected reset: dev_state = RESETTING fw status = [ 135.580522] ACPI
> Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller
> passed 0, method requires 1 (20230628/nsarguments-232) [ 135.584170]
> intel_vsc intel_vsc: silicon stepping version is 0:2 [ 135.635935] OOM killer
> enabled.
> [ 135.635940] Restarting tasks ... done.
> [ 135.863803] PM: suspend exit
>
> I seem to have pressed the power butten often enough to initiate a second
> suspend/resume cycle immediately:
>
> [ 135.864196] PM: suspend entry (s2idle) [ 135.875238] Filesystems sync:
> 0.011 seconds [ 135.879306] Freezing user space processes [ 135.883869]
> Freezing user space processes completed (elapsed 0.004 seconds)
> [ 135.883881] OOM killer disabled.
> [ 135.883884] Freezing remaining freezable tasks [ 135.886107] Freezing
> remaining freezable tasks completed (elapsed 0.002 seconds) [ 135.886112]
> printk: Suspending console(s) (use no_console_suspend to debug)
> [ 149.173274] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
> [ 151.221491] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
> [ 151.221784] intel_vsc intel_vsc: wait fw ready failed: -110 [ 151.221793]
> intel_vsc intel_vsc: hw_start failed ret = -110 fw status = [ 151.222752]
> intel_vsc intel_vsc: unexpected reset: dev_state = RESETTING fw status =
> [ 151.256758] ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient
> arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> [ 151.262174] intel_vsc intel_vsc: silicon stepping version is 0:2 [ 164.853425]
> vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110 [ 166.901441] vsc-tp
> spi-INTC1094:00: wakeup firmware failed ret: -110 [ 166.901772] intel_vsc
> intel_vsc: wait fw ready failed: -110 [ 166.901779] intel_vsc intel_vsc:
> hw_start failed ret = -110 fw status = [ 166.904282] intel_vsc intel_vsc: reset:
> reached maximal consecutive resets: disabling the device [ 166.904290]
> intel_vsc intel_vsc: device disabled = -19 [ 166.904665] intel_vsc intel_vsc:
> reset: reached maximal consecutive resets: disabling the device [ 166.904712]
> PM: Some devices failed to suspend, or early wake event detected
> [ 166.940695] ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient
> arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> [ 166.946175] intel_vsc intel_vsc: silicon stepping version is 0:2 [ 181.045504]
> vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110 [ 183.093514] vsc-tp
> spi-INTC1094:00: wakeup firmware failed ret: -110 [ 183.093898] intel_vsc
> intel_vsc: wait fw ready failed: -110 [ 183.093912] intel_vsc intel_vsc:
> hw_start failed ret = -110 fw status = [ 183.094507] intel_vsc intel_vsc:
> unexpected reset: dev_state = RESETTING fw status = [ 183.129467] ACPI
> Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller
> passed 0, method requires 1 (20230628/nsarguments-232) [ 183.132830]
> intel_vsc intel_vsc: silicon stepping version is 0:2 [ 183.135905] OOM killer
> enabled.
> [ 183.135909] Restarting tasks ... done.
> [ 183.372915] PM: suspend exit
>
> Subsequent suspend/resume operations continue to emit warnings/failures
> related to intel_vsc:
>
> [ 341.554095] PM: suspend entry (s2idle) [ 341.559387] Filesystems sync:
> 0.005 seconds [ 341.673175] Freezing user space processes [ 341.679061]
> Freezing user space processes completed (elapsed 0.005 seconds)
> [ 341.679069] OOM killer disabled.
> [ 341.679071] Freezing remaining freezable tasks [ 341.680652] Freezing
> remaining freezable tasks completed (elapsed 0.001 seconds) [ 341.680656]
> printk: Suspending console(s) (use no_console_suspend to debug)
> [ 341.861251] intel_vsc intel_vsc: reset: reached maximal consecutive resets:
> disabling the device [ 342.065565] ACPI: EC: interrupt blocked [ 342.855083]
> ACPI: EC: interrupt unblocked [ 343.039446] i915 0000:00:02.0: [drm] GT0:
> GuC firmware i915/adlp_guc_70.bin version 70.20.0 [ 343.039458] i915
> 0000:00:02.0: [drm] GT0: HuC firmware i915/tgl_huc.bin version 7.9.3
> [ 343.064550] i915 0000:00:02.0: [drm] GT0: HuC: authenticated for all
> workloads [ 343.065807] i915 0000:00:02.0: [drm] GT0: GUC: submission
> enabled [ 343.065811] i915 0000:00:02.0: [drm] GT0: GUC: SLPC enabled
> [ 343.066305] i915 0000:00:02.0: [drm] GT0: GUC: RC enabled [ 343.124628]
> nvme nvme0: 8/0/0 default/read/poll queues [ 343.385084] ACPI Warning:
> \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0,
> method requires 1 (20230628/nsarguments-232) [ 343.389309] intel_vsc
> intel_vsc: silicon stepping version is 0:2 [ 356.946491] vsc-tp spi-INTC1094:00:
> wakeup firmware failed ret: -110 [ 358.996072] vsc-tp spi-INTC1094:00:
> wakeup firmware failed ret: -110 [ 358.996432] intel_vsc intel_vsc: wait fw
> ready failed: -110 [ 358.996446] intel_vsc intel_vsc: hw_start failed ret = -110
> fw status = [ 358.997008] intel_vsc intel_vsc: unexpected reset: dev_state =
> RESETTING fw status = [ 359.031049] ACPI Warning:
> \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed 0,
> method requires 1 (20230628/nsarguments-232) [ 359.035795] intel_vsc
> intel_vsc: silicon stepping version is 0:2 [ 359.051336] mei_hdcp
> 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0
> (ops i915_hdcp_ops) [ 359.051432] OOM killer enabled.
> [ 359.051435] Restarting tasks ...
> [ 359.052195] mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1:
> bound 0000:00:02.0 (ops i915_pxp_tee_component_ops) [ 359.056184] done.
> [ 359.309627] PM: suspend exit
> [ 372.188053] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
> [ 374.364551] vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
> [ 374.364749] intel_vsc intel_vsc: wait fw ready failed: -110 [ 374.364755]
> intel_vsc intel_vsc: hw_start failed ret = -110 fw status = [ 374.364778]
> intel_vsc intel_vsc: unexpected reset: dev_state = RESETTING fw status =
> [ 374.399149] ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient
> arguments - Caller passed 0, method requires 1 (20230628/nsarguments-232)
> [ 374.406099] intel_vsc intel_vsc: silicon stepping version is 0:2 [ 387.747776]
> vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110 [ 389.924474] vsc-tp
> spi-INTC1094:00: wakeup firmware failed ret: -110 [ 390.045250] intel_vsc
> intel_vsc: wait fw ready failed: -110 [ 390.045260] intel_vsc intel_vsc:
> hw_start failed ret = -110 fw status = [ 390.045294] intel_vsc intel_vsc:
> unexpected reset: dev_state = RESETTING fw status = [ 390.045297] intel_vsc
> intel_vsc: reset: reached maximal consecutive resets: disabling the device
> [ 390.045324] intel_vsc intel_vsc: device disabled = -19
>
> Best,
> Dominik
>
> ---
>
> Subject: [PATCH] media: v4l: async: remove unused variable
>
> ret is unused in v4l2_async_nf_register()
>
> Signed-off-by: Dominik Brodowski <[email protected]>
>
> diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-
> core/v4l2-async.c
> index a722c5eb3230..3b43d6285dfe 100644
> --- a/drivers/media/v4l2-core/v4l2-async.c
> +++ b/drivers/media/v4l2-core/v4l2-async.c
> @@ -620,8 +620,6 @@ static int __v4l2_async_nf_register(struct
> v4l2_async_notifier *notifier)
>
> int v4l2_async_nf_register(struct v4l2_async_notifier *notifier)
> {
> - int ret;
> -
> if (WARN_ON(!notifier->v4l2_dev == !notifier->sd))
> return -EINVAL;
>