2024-02-28 21:33:31

by Kees Cook

Subject: Re: [PATCH v4 1/8] overflow: Use POD in check_shl_overflow()

On Wed, Feb 28, 2024 at 10:41:31PM +0200, Andy Shevchenko wrote:
> The check_shl_overflow() uses u64 type that is defined in types.h.
> Instead of including that header, just switch to use POD type
> directly.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Acked-by: Kees Cook <[email protected]>

--
Kees Cook

2024-02-29 15:46:37

by Andy Shevchenko

Subject: Re: [PATCH v4 1/8] overflow: Use POD in check_shl_overflow()

On Wed, Feb 28, 2024 at 01:33:15PM -0800, Kees Cook wrote:
> On Wed, Feb 28, 2024 at 10:41:31PM +0200, Andy Shevchenko wrote:
> > The check_shl_overflow() uses u64 type that is defined in types.h.
> > Instead of including that header, just switch to use POD type
> > directly.
> >
> > Signed-off-by: Andy Shevchenko <[email protected]>
>
> Acked-by: Kees Cook <[email protected]>

Based on the further discussion this seems pretty independent. Can you take it
through your tree?

--
With Best Regards,
Andy Shevchenko