2024-03-04 18:03:55

by Andy Shevchenko

Subject: [PATCH v1 1/1] media: ir-spi: Remove unused of_gpio.h

of_gpio.h is deprecated and subject to remove.
The driver doesn't use it, simply remove the unused header.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/media/rc/ir-spi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/media/rc/ir-spi.c b/drivers/media/rc/ir-spi.c
index bbc81bed4f90..8afc3cd70b87 100644
--- a/drivers/media/rc/ir-spi.c
+++ b/drivers/media/rc/ir-spi.c
@@ -8,7 +8,6 @@
#include <linux/fs.h>
#include <linux/module.h>
#include <linux/mutex.h>
-#include <linux/of_gpio.h>
#include <linux/regulator/consumer.h>
#include <linux/spi/spi.h>
#include <media/rc-core.h>
--
2.43.0.rc1.1.gbec44491f096

2024-03-05 09:16:45

by Sean Young

Subject: Re: [PATCH v1 1/1] media: ir-spi: Remove unused of_gpio.h

On Mon, Mar 04, 2024 at 08:03:31PM +0200, Andy Shevchenko wrote:
> of_gpio.h is deprecated and subject to remove.
> The driver doesn't use it, simply remove the unused header.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/media/rc/ir-spi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/rc/ir-spi.c b/drivers/media/rc/ir-spi.c
> index bbc81bed4f90..8afc3cd70b87 100644
> --- a/drivers/media/rc/ir-spi.c
> +++ b/drivers/media/rc/ir-spi.c
> @@ -8,7 +8,6 @@
> #include <linux/fs.h>
> #include <linux/module.h>
> #include <linux/mutex.h>
> -#include <linux/of_gpio.h>

This does not build, I get errors saying of_property_read_bool() is undefined.
I think we need linux/of.h instead of linux/of_gpio.h.


Sean

> #include <linux/regulator/consumer.h>
> #include <linux/spi/spi.h>
> #include <media/rc-core.h>
> --
> 2.43.0.rc1.1.gbec44491f096

2024-03-05 17:38:05

by Andy Shevchenko

Subject: Re: [PATCH v1 1/1] media: ir-spi: Remove unused of_gpio.h

On Tue, Mar 05, 2024 at 09:15:28AM +0000, Sean Young wrote:
> On Mon, Mar 04, 2024 at 08:03:31PM +0200, Andy Shevchenko wrote:

..

> > -#include <linux/of_gpio.h>
>
> This does not build, I get errors saying of_property_read_bool() is undefined.
> I think we need linux/of.h instead of linux/of_gpio.h.

Oh, good catch! The header block there is a mess.
I will replace this patch by something better, I'll Cc you.

--
With Best Regards,
Andy Shevchenko