2024-03-03 10:06:04

by Jonathan Bergh

Subject: [PATCH 1/2] staging: vme_user: Fix misaligned closing comment */

This patch makes the following change:
* Ensures the trailing */ for comments is on the same line as the opening
/*

Signed-off-by: Jonathan Bergh <[email protected]>
---
drivers/staging/vme_user/vme_tsi148.h | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
index 4dd224d0b86e..2a92497c5570 100644
--- a/drivers/staging/vme_user/vme_tsi148.h
+++ b/drivers/staging/vme_user/vme_tsi148.h
@@ -691,8 +691,7 @@ static const int TSI148_GCSR_MBOX[4] = { TSI148_GCSR_MBOX0,

#define TSI148_LCSR_VMCTRL_RMWEN BIT(20) /* RMW Enable */

-#define TSI148_LCSR_VMCTRL_ATO_M (7 << 16) /* Master Access Time-out Mask
- */
+#define TSI148_LCSR_VMCTRL_ATO_M (7 << 16) /* Master Access Time-out Mask */
#define TSI148_LCSR_VMCTRL_ATO_32 (0 << 16) /* 32 us */
#define TSI148_LCSR_VMCTRL_ATO_128 BIT(16) /* 128 us */
#define TSI148_LCSR_VMCTRL_ATO_512 (2 << 16) /* 512 us */
@@ -753,8 +752,7 @@ static const int TSI148_GCSR_MBOX[4] = { TSI148_GCSR_MBOX0,
#define TSI148_LCSR_VCTRL_DLT_16384 (0xB << 24) /* 16384 VCLKS */
#define TSI148_LCSR_VCTRL_DLT_32768 (0xC << 24) /* 32768 VCLKS */

-#define TSI148_LCSR_VCTRL_NERBB BIT(20) /* No Early Release of Bus Busy
- */
+#define TSI148_LCSR_VCTRL_NERBB BIT(20) /* No Early Release of Bus Busy */

#define TSI148_LCSR_VCTRL_SRESET BIT(17) /* System Reset */
#define TSI148_LCSR_VCTRL_LRESET BIT(16) /* Local Reset */
--
2.40.1

2024-03-03 10:06:12

by Jonathan Bergh

Subject: [PATCH 2/2] staging: vme_user: Add a newline after variable declarations

This patch makes the following change:
* Adds a newline after the variable declarations as per checkpatch's
warning

Signed-off-by: Jonathan Bergh <[email protected]>
---
drivers/staging/vme_user/vme_tsi148.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
index 2a92497c5570..a1b8288b101a 100644
--- a/drivers/staging/vme_user/vme_tsi148.h
+++ b/drivers/staging/vme_user/vme_tsi148.h
@@ -34,6 +34,7 @@ struct tsi148_driver {
void __iomem *base; /* Base Address of device registers */
wait_queue_head_t dma_queue[2];
wait_queue_head_t iack_queue;
+
void (*lm_callback[4])(void *); /* Called in interrupt handler */
void *lm_data[4];
void *crcsr_kernel;
--
2.40.1

2024-03-05 14:39:35

by Greg Kroah-Hartman

Subject: Re: [PATCH 2/2] staging: vme_user: Add a newline after variable declarations

On Sun, Mar 03, 2024 at 11:05:47AM +0100, Jonathan Bergh wrote:
> This patch makes the following change:
> * Adds a newline after the variable declarations as per checkpatch's
> warning
>
> Signed-off-by: Jonathan Bergh <[email protected]>
> ---
> drivers/staging/vme_user/vme_tsi148.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
> index 2a92497c5570..a1b8288b101a 100644
> --- a/drivers/staging/vme_user/vme_tsi148.h
> +++ b/drivers/staging/vme_user/vme_tsi148.h
> @@ -34,6 +34,7 @@ struct tsi148_driver {
> void __iomem *base; /* Base Address of device registers */
> wait_queue_head_t dma_queue[2];
> wait_queue_head_t iack_queue;
> +
> void (*lm_callback[4])(void *); /* Called in interrupt handler */
> void *lm_data[4];
> void *crcsr_kernel;

Please always look at the change to see if checkpatch is correct or not
(hint, for this one, it is not.) Also see the archives for many people
who have done the same thing in the past :)

thanks,

greg k-h

2024-03-05 17:42:09

by Jonathan Bergh

Subject: Re: [PATCH 2/2] staging: vme_user: Add a newline after variable declarations

On Tue, Mar 05, 2024 at 02:13:23PM +0000, Greg KH wrote:
> On Sun, Mar 03, 2024 at 11:05:47AM +0100, Jonathan Bergh wrote:
> > This patch makes the following change:
> > * Adds a newline after the variable declarations as per checkpatch's
> > warning
> >
> > Signed-off-by: Jonathan Bergh <[email protected]>
> > ---
> > drivers/staging/vme_user/vme_tsi148.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
> > index 2a92497c5570..a1b8288b101a 100644
> > --- a/drivers/staging/vme_user/vme_tsi148.h
> > +++ b/drivers/staging/vme_user/vme_tsi148.h
> > @@ -34,6 +34,7 @@ struct tsi148_driver {
> > void __iomem *base; /* Base Address of device registers */
> > wait_queue_head_t dma_queue[2];
> > wait_queue_head_t iack_queue;
> > +
> > void (*lm_callback[4])(void *); /* Called in interrupt handler */
> > void *lm_data[4];
> > void *crcsr_kernel;
>
> Please always look at the change to see if checkpatch is correct or not
> (hint, for this one, it is not.) Also see the archives for many people
> who have done the same thing in the past :)

Got it, thanks for that.

>
> thanks,
>
> greg k-h