2024-03-16 23:19:53

by Mirsad Todorovac

[permalink] [raw]
Subject: [BUG] selftests/net: test_vxlan_mdb.sh: 84 out of 642 tests [FAIL]

Hi,

While running kselftest on vanilla torvalds tree kernel commit v6.8-11167-g4438a810f396,
the test suite reported a number of errors.

I was using the latest iproute2-next suite on an Ubuntu 22.04 LTS box.

# Tests passed: 558
# Tests failed: 84
not ok 90 selftests: net: test_vxlan_mdb.sh # exit=1

495:# TEST: Destination IP - match [FAIL]
496:# TEST: Destination IP - no match [FAIL]
497:# TEST: Default destination port - match [FAIL]
498:# TEST: Default destination port - no match [FAIL]
499:# TEST: Non-default destination port - match [FAIL]
500:# TEST: Non-default destination port - no match [FAIL]
501:# TEST: Default destination VNI - match [FAIL]
502:# TEST: Default destination VNI - no match [FAIL]
503:# TEST: Non-default destination VNI - match [FAIL]
504:# TEST: Non-default destination VNI - no match [FAIL]
521:# TEST: Destination IP - match [FAIL]
522:# TEST: Destination IP - no match [FAIL]
523:# TEST: Default destination port - match [FAIL]
524:# TEST: Default destination port - no match [FAIL]
525:# TEST: Non-default destination port - match [FAIL]
526:# TEST: Non-default destination port - no match [FAIL]
527:# TEST: Default destination VNI - match [FAIL]
528:# TEST: Default destination VNI - no match [FAIL]
529:# TEST: Non-default destination VNI - match [FAIL]
530:# TEST: Non-default destination VNI - no match [FAIL]
549:# TEST: Forward valid source - first VTEP [FAIL]
550:# TEST: Forward valid source - second VTEP [FAIL]
551:# TEST: Block excluded source after removal - first VTEP [FAIL]
552:# TEST: Block excluded source after removal - second VTEP [FAIL]
553:# TEST: Forward valid source after removal - first VTEP [FAIL]
554:# TEST: Forward valid source after removal - second VTEP [FAIL]
571:# TEST: Forward valid source - first VTEP [FAIL]
572:# TEST: Forward valid source - second VTEP [FAIL]
573:# TEST: Block excluded source after removal - first VTEP [FAIL]
574:# TEST: Block excluded source after removal - second VTEP [FAIL]
575:# TEST: Forward valid source after removal - first VTEP [FAIL]
576:# TEST: Forward valid source after removal - second VTEP [FAIL]
593:# TEST: Forward valid source - first VTEP [FAIL]
594:# TEST: Forward valid source - second VTEP [FAIL]
595:# TEST: Block excluded source after removal - first VTEP [FAIL]
596:# TEST: Block excluded source after removal - second VTEP [FAIL]
597:# TEST: Forward valid source after removal - first VTEP [FAIL]
598:# TEST: Forward valid source after removal - second VTEP [FAIL]
615:# TEST: Forward valid source - first VTEP [FAIL]
616:# TEST: Forward valid source - second VTEP [FAIL]
617:# TEST: Block excluded source after removal - first VTEP [FAIL]
618:# TEST: Block excluded source after removal - second VTEP [FAIL]
619:# TEST: Forward valid source after removal - first VTEP [FAIL]
620:# TEST: Forward valid source after removal - second VTEP [FAIL]
636:# TEST: Forward valid source [FAIL]
637:# TEST: Receive of valid source after removal from group [FAIL]
648:# TEST: Forward valid source [FAIL]
649:# TEST: Receive of valid source after removal from group [FAIL]
660:# TEST: Forward valid source [FAIL]
661:# TEST: Receive of valid source after removal from group [FAIL]
672:# TEST: Forward valid source [FAIL]
673:# TEST: Receive of valid source after removal from group [FAIL]
683:# TEST: Egress VNI translation - PVID configured [FAIL]
684:# TEST: Egress VNI translation - no PVID configured [FAIL]
685:# TEST: Egress VNI translation - PVID reconfigured [FAIL]
695:# TEST: Egress VNI translation - PVID configured [FAIL]
696:# TEST: Egress VNI translation - no PVID configured [FAIL]
697:# TEST: Egress VNI translation - PVID reconfigured [FAIL]
707:# TEST: Registered IPv4 multicast - first VTEP [FAIL]
709:# TEST: Unregistered IPv4 multicast - first VTEP [FAIL]
710:# TEST: Unregistered IPv4 multicast - second VTEP [FAIL]
711:# TEST: Link-local IPv4 multicast - first VTEP [FAIL]
712:# TEST: Link-local IPv4 multicast - second VTEP [FAIL]
713:# TEST: Registered IPv4 multicast with a unicast MAC - first VTEP [FAIL]
714:# TEST: Registered IPv4 multicast with a unicast MAC - second VTEP [FAIL]
715:# TEST: Registered IPv4 multicast with a broadcast MAC - first VTEP [FAIL]
716:# TEST: Registered IPv4 multicast with a broadcast MAC - second VTEP [FAIL]
734:# TEST: Registered IPv4 multicast - first VTEP [FAIL]
736:# TEST: Unregistered IPv4 multicast - first VTEP [FAIL]
737:# TEST: Unregistered IPv4 multicast - second VTEP [FAIL]
738:# TEST: Link-local IPv4 multicast - first VTEP [FAIL]
739:# TEST: Link-local IPv4 multicast - second VTEP [FAIL]
740:# TEST: Registered IPv4 multicast with a unicast MAC - first VTEP [FAIL]
741:# TEST: Registered IPv4 multicast with a unicast MAC - second VTEP [FAIL]
742:# TEST: Registered IPv4 multicast with a broadcast MAC - first VTEP [FAIL]
743:# TEST: Registered IPv4 multicast with a broadcast MAC - second VTEP [FAIL]
761:# TEST: IP multicast - first VTEP [FAIL]
763:# TEST: Broadcast - first VTEP [FAIL]
765:# TEST: IP multicast after removal - first VTEP [FAIL]
766:# TEST: IP multicast after removal - second VTEP [FAIL]
779:# TEST: IP multicast - first VTEP [FAIL]
781:# TEST: Broadcast - first VTEP [FAIL]
783:# TEST: IP multicast after removal - first VTEP [FAIL]
784:# TEST: IP multicast after removal - second VTEP [FAIL]

The problem is present at least since 6.8-rc7.

Please find attached the config and the full output of test_vxlan_mdb.sh.

Hope this helps.

Best regards,
Mirsad Todorovac


Attachments:
config-6.8.0-torv-11167-g4438a810f396-dirty.xz (58.22 kB)
test_vxlan_mdb.sh.log (55.49 kB)
Download all attachments

2024-03-18 03:36:33

by Hangbin Liu

[permalink] [raw]
Subject: Re: [BUG] selftests/net: test_vxlan_mdb.sh: 84 out of 642 tests [FAIL]

On Sun, Mar 17, 2024 at 12:19:12AM +0100, Mirsad Todorovac wrote:
> Hi,
>
> While running kselftest on vanilla torvalds tree kernel commit v6.8-11167-g4438a810f396,
> the test suite reported a number of errors.
>
> I was using the latest iproute2-next suite on an Ubuntu 22.04 LTS box.
>
> # Tests passed: 558
> # Tests failed: 84
> not ok 90 selftests: net: test_vxlan_mdb.sh # exit=1

FYI, I tested with 6.8 kernel with net tree. All passed.

Data path: MDB torture test - IPv6 overlay / IPv6 underlay
----------------------------------------------------------
TEST: Torture test [ OK ]

Tests passed: 642
Tests failed: 0

# uname -r
6.8.0-virtme

Thanks
Hangbin

2024-03-19 05:05:37

by Mirsad Todorovac

[permalink] [raw]
Subject: Re: [BUG] selftests/net: test_vxlan_mdb.sh: 84 out of 642 tests [FAIL]

On 3/18/24 04:35, Hangbin Liu wrote:
> On Sun, Mar 17, 2024 at 12:19:12AM +0100, Mirsad Todorovac wrote:
>> Hi,
>>
>> While running kselftest on vanilla torvalds tree kernel commit v6.8-11167-g4438a810f396,
>> the test suite reported a number of errors.
>>
>> I was using the latest iproute2-next suite on an Ubuntu 22.04 LTS box.
>>
>> # Tests passed: 558
>> # Tests failed: 84
>> not ok 90 selftests: net: test_vxlan_mdb.sh # exit=1
>
> FYI, I tested with 6.8 kernel with net tree. All passed.
>
> Data path: MDB torture test - IPv6 overlay / IPv6 underlay
> ----------------------------------------------------------
> TEST: Torture test [ OK ]
>
> Tests passed: 642
> Tests failed: 0
>
> # uname -r
> 6.8.0-virtme
>
> Thanks
> Hangbin

Hi, Hangbin,

I am running an Ubuntu 22.04 LTS configuration.

I tried it again with 6.8.0-net-next-05204-g237bb5f7f7f5 and iproute2-next
from this repo: https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git

RESULTS:

# Data path: MDB torture test - IPv6 overlay / IPv6 underlay
# ----------------------------------------------------------
# TEST: Torture test [ OK ]
#
# Tests passed: 558
# Tests failed: 84
not ok 90 selftests: net: test_vxlan_mdb.sh # exit=1

David said there may be something in sysctl.conf:

#
# /etc/sysctl.conf - Configuration file for setting system variables
# See /etc/sysctl.d/ for additional system variables.
# See sysctl.conf (5) for information.
#

#kernel.domainname = example.com

# Uncomment the following to stop low-level messages on console
#kernel.printk = 3 4 1 3

###################################################################
# Functions previously found in netbase
#

# Uncomment the next two lines to enable Spoof protection (reverse-path filter)
# Turn on Source Address Verification in all interfaces to
# prevent some spoofing attacks
#net.ipv4.conf.default.rp_filter=1
#net.ipv4.conf.all.rp_filter=1

# Uncomment the next line to enable TCP/IP SYN cookies
# See http://lwn.net/Articles/277146/
# Note: This may impact IPv6 TCP sessions too
#net.ipv4.tcp_syncookies=1

# Uncomment the next line to enable packet forwarding for IPv4
net.ipv4.ip_forward=1

# Uncomment the next line to enable packet forwarding for IPv6
# Enabling this option disables Stateless Address Autoconfiguration
# based on Router Advertisements for this host
#net.ipv6.conf.all.forwarding=1

net.ipv4.conf.default.rp_filter = 0
net.ipv4.conf.all.rp_filter = 0


###################################################################
# Additional settings - these settings can improve the network
# security of the host and prevent against some network attacks
# including spoofing attacks and man in the middle attacks through
# redirection. Some network environments, however, require that these
# settings are disabled so review and enable them as needed.
#
# Do not accept ICMP redirects (prevent MITM attacks)
net.ipv4.conf.all.accept_redirects = 0
net.ipv6.conf.all.accept_redirects = 0
net.ipv4.conf.default.accept_redirects = 0
net.ipv6.conf.default.accept_redirects = 0
# _or_
# Accept ICMP redirects only for gateways listed in our default
# gateway list (enabled by default)
# net.ipv4.conf.all.secure_redirects = 1
#
# Do not send ICMP redirects (we are not a router)
net.ipv4.conf.all.send_redirects = 0
net.ipv4.conf.default.send_redirects = 0
net.ipv4.icmp_ignore_bogus_error_responses = 1
#
# Do not accept IP source route packets (we are not a router)
net.ipv4.conf.all.accept_source_route = 0
net.ipv6.conf.all.accept_source_route = 0
#
# Log Martian Packets
net.ipv4.conf.all.log_martians = 0
net.ipv4.conf.default.log_martians = 0
#

###################################################################
# Magic system request Key
# 0=disable, 1=enable all, >1 bitmask of sysrq functions
# See https://www.kernel.org/doc/html/latest/admin-guide/sysrq.html
# for what other values do
#kernel.sysrq=438

Best regards,
Mirsad

2024-03-19 14:28:05

by Ido Schimmel

[permalink] [raw]
Subject: Re: [BUG] selftests/net: test_vxlan_mdb.sh: 84 out of 642 tests [FAIL]

On Tue, Mar 19, 2024 at 06:05:16AM +0100, Mirsad Todorovac wrote:
> On 3/18/24 04:35, Hangbin Liu wrote:
> > On Sun, Mar 17, 2024 at 12:19:12AM +0100, Mirsad Todorovac wrote:
> > > Hi,
> > >
> > > While running kselftest on vanilla torvalds tree kernel commit v6.8-11167-g4438a810f396,
> > > the test suite reported a number of errors.
> > >
> > > I was using the latest iproute2-next suite on an Ubuntu 22.04 LTS box.
> > >
> > > # Tests passed: 558
> > > # Tests failed: 84
> > > not ok 90 selftests: net: test_vxlan_mdb.sh # exit=1
> >
> > FYI, I tested with 6.8 kernel with net tree. All passed.
> >
> > Data path: MDB torture test - IPv6 overlay / IPv6 underlay
> > ----------------------------------------------------------
> > TEST: Torture test [ OK ]
> >
> > Tests passed: 642
> > Tests failed: 0
> >
> > # uname -r
> > 6.8.0-virtme
> >
> > Thanks
> > Hangbin
>
> Hi, Hangbin,
>
> I am running an Ubuntu 22.04 LTS configuration.

Didn't get your first mail for some reason. Anyway, it might be related
to the fact that Ubuntu is using an old version of libnet:

https://launchpad.net/ubuntu/+source/libnet

I remember fixing similar issues in the past:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cb034948ac292da82cc0e6bc1340f81be36e117d

Will look into it today or later this week.

2024-03-20 00:48:09

by Mirsad Todorovac

[permalink] [raw]
Subject: Re: [BUG] selftests/net: test_vxlan_mdb.sh: 84 out of 642 tests [FAIL]



On 3/19/24 15:25, Ido Schimmel wrote:
> On Tue, Mar 19, 2024 at 06:05:16AM +0100, Mirsad Todorovac wrote:
>> On 3/18/24 04:35, Hangbin Liu wrote:
>>> On Sun, Mar 17, 2024 at 12:19:12AM +0100, Mirsad Todorovac wrote:
>>>> Hi,
>>>>
>>>> While running kselftest on vanilla torvalds tree kernel commit v6.8-11167-g4438a810f396,
>>>> the test suite reported a number of errors.
>>>>
>>>> I was using the latest iproute2-next suite on an Ubuntu 22.04 LTS box.
>>>>
>>>> # Tests passed: 558
>>>> # Tests failed: 84
>>>> not ok 90 selftests: net: test_vxlan_mdb.sh # exit=1
>>>
>>> FYI, I tested with 6.8 kernel with net tree. All passed.
>>>
>>> Data path: MDB torture test - IPv6 overlay / IPv6 underlay
>>> ----------------------------------------------------------
>>> TEST: Torture test [ OK ]
>>>
>>> Tests passed: 642
>>> Tests failed: 0
>>>
>>> # uname -r
>>> 6.8.0-virtme
>>>
>>> Thanks
>>> Hangbin
>>
>> Hi, Hangbin,
>>
>> I am running an Ubuntu 22.04 LTS configuration.
>
> Didn't get your first mail for some reason.

Your organisation's Office 365 is configured against compressed attachments:

Diagnostic-Code: smtp;550 5.0.350 One or more of the attachments in your email is of a file type
that is NOT allowed by the recipient's organization.

I will try to remember this.

> Anyway, it might be related
> to the fact that Ubuntu is using an old version of libnet:
>
> https://launchpad.net/ubuntu/+source/libnet
>
> I remember fixing similar issues in the past:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cb034948ac292da82cc0e6bc1340f81be36e117d

I recall that last August.

> Will look into it today or later this week.

Thank you for considering this.

Best regards,
Mirsad Todorovac

2024-03-20 11:01:49

by Ido Schimmel

[permalink] [raw]
Subject: Re: [BUG] selftests/net: test_vxlan_mdb.sh: 84 out of 642 tests [FAIL]

On Wed, Mar 20, 2024 at 01:47:36AM +0100, Mirsad Todorovac wrote:
> On 3/19/24 15:25, Ido Schimmel wrote:
> > Will look into it today or later this week.
>
> Thank you for considering this.

Can you please try the following patch?

https://github.com/idosch/linux/commit/58f25dd8766dbe9ac50c76b44f9ba92350ebb5c6.patch

2024-03-21 20:08:55

by Mirsad Todorovac

[permalink] [raw]
Subject: Re: [BUG] selftests/net: test_vxlan_mdb.sh: 84 out of 642 tests [FAIL]



On 3/20/24 12:01, Ido Schimmel wrote:
> On Wed, Mar 20, 2024 at 01:47:36AM +0100, Mirsad Todorovac wrote:
>> On 3/19/24 15:25, Ido Schimmel wrote:
>>> Will look into it today or later this week.
>>
>> Thank you for considering this.
>
> Can you please try the following patch?
>
> https://github.com/idosch/linux/commit/58f25dd8766dbe9ac50c76b44f9ba92350ebb5c6.patch

Congratulations, apparently, your patch had fixed them all:

# TEST: Torture test [ OK ]
#
# Data path: MDB torture test - IPv6 overlay / IPv6 underlay
# ----------------------------------------------------------
# TEST: Torture test [ OK ]
#
# Tests passed: 642
# Tests failed: 0
ok 90 selftests: net: test_vxlan_mdb.sh

Please consider adding:

Tested-by: Mirsad Todorovac <[email protected]>

at your convenience.

Shalom, and have a great evening!

Best regards,
Mirsad Todorovac

2024-03-21 20:11:12

by Mirsad Todorovac

[permalink] [raw]
Subject: Re: [BUG] selftests/net: test_vxlan_mdb.sh: 84 out of 642 tests [FAIL]



On 3/20/24 12:01, Ido Schimmel wrote:
> On Wed, Mar 20, 2024 at 01:47:36AM +0100, Mirsad Todorovac wrote:
>> On 3/19/24 15:25, Ido Schimmel wrote:
>>> Will look into it today or later this week.
>>
>> Thank you for considering this.
>
> Can you please try the following patch?
>
> https://github.com/idosch/linux/commit/58f25dd8766dbe9ac50c76b44f9ba92350ebb5c6.patch

Congratulations, apparently, your patch had fixed them all:

# TEST: Torture test [ OK ]
#
# Data path: MDB torture test - IPv6 overlay / IPv6 underlay
# ----------------------------------------------------------
# TEST: Torture test [ OK ]
#
# Tests passed: 642
# Tests failed: 0
ok 90 selftests: net: test_vxlan_mdb.sh

Please consider adding:

Tested-by: Mirsad Todorovac <[email protected]>

at your convenience.

Shalom, and have a great evening!

Best regards,
Mirsad Todorovac