2024-03-20 19:32:56

by David Thompson

Subject: [PATCH net v1] mlxbf_gige: stop PHY during open() error paths

The mlxbf_gige_open() routine starts the PHY as part of normal
initialization. The mlxbf_gige_open() routine must stop the
PHY during its error paths.

Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
Signed-off-by: David Thompson <[email protected]>
Reviewed-by: Asmaa Mnebhi <[email protected]>
---
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
index 3d09fa54598f..cef0e2d3f1a7 100644
--- a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
+++ b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
@@ -157,7 +157,7 @@ static int mlxbf_gige_open(struct net_device *netdev)

err = mlxbf_gige_tx_init(priv);
if (err)
- goto free_irqs;
+ goto phy_deinit;
err = mlxbf_gige_rx_init(priv);
if (err)
goto tx_deinit;
@@ -185,6 +185,9 @@ static int mlxbf_gige_open(struct net_device *netdev)
tx_deinit:
mlxbf_gige_tx_deinit(priv);

+phy_deinit:
+ phy_stop(phydev);
+
free_irqs:
mlxbf_gige_free_irqs(priv);
return err;
--
2.30.1

2024-03-20 22:35:37

by Andrew Lunn

Subject: Re: [PATCH net v1] mlxbf_gige: stop PHY during open() error paths

On Wed, Mar 20, 2024 at 03:31:17PM -0400, David Thompson wrote:
> The mlxbf_gige_open() routine starts the PHY as part of normal
> initialization. The mlxbf_gige_open() routine must stop the
> PHY during its error paths.
>
> Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
> Signed-off-by: David Thompson <[email protected]>
> Reviewed-by: Asmaa Mnebhi <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2024-03-21 09:49:20

by Jiri Pirko

Subject: Re: [PATCH net v1] mlxbf_gige: stop PHY during open() error paths

Wed, Mar 20, 2024 at 08:31:17PM CET, [email protected] wrote:
>The mlxbf_gige_open() routine starts the PHY as part of normal
>initialization. The mlxbf_gige_open() routine must stop the
>PHY during its error paths.
>
>Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
>Signed-off-by: David Thompson <[email protected]>
>Reviewed-by: Asmaa Mnebhi <[email protected]>

Reviewed-by: Jiri Pirko <[email protected]>

2024-03-25 18:01:26

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net v1] mlxbf_gige: stop PHY during open() error paths

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

On Wed, 20 Mar 2024 15:31:17 -0400 you wrote:
> The mlxbf_gige_open() routine starts the PHY as part of normal
> initialization. The mlxbf_gige_open() routine must stop the
> PHY during its error paths.
>
> Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
> Signed-off-by: David Thompson <[email protected]>
> Reviewed-by: Asmaa Mnebhi <[email protected]>
>
> [...]

Here is the summary with links:
- [net,v1] mlxbf_gige: stop PHY during open() error paths
https://git.kernel.org/netdev/net/c/d6c30c5a168f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html