2024-04-29 23:46:46

by Edward Liaw

Subject: [PATCH] selftests/kcmp: Remove unused open mode

Android bionic warns that open modes are ignored if O_CREAT or O_TMPFILE
aren't specified. The permissions for the file are set above:

fd1 = open(kpath, O_RDWR | O_CREAT | O_TRUNC, 0644);

Fixes: d97b46a64674 ("syscalls, x86: add __NR_kcmp syscall")
Signed-off-by: Edward Liaw <[email protected]>
---
tools/testing/selftests/kcmp/kcmp_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/kcmp/kcmp_test.c b/tools/testing/selftests/kcmp/kcmp_test.c
index 25110c7c0b3e..d7a8e321bb16 100644
--- a/tools/testing/selftests/kcmp/kcmp_test.c
+++ b/tools/testing/selftests/kcmp/kcmp_test.c
@@ -91,7 +91,7 @@ int main(int argc, char **argv)
ksft_print_header();
ksft_set_plan(3);

- fd2 = open(kpath, O_RDWR, 0644);
+ fd2 = open(kpath, O_RDWR);
if (fd2 < 0) {
perror("Can't open file");
ksft_exit_fail();
--
2.44.0.769.g3c40516874-goog

2024-04-30 17:50:48

by Cyrill Gorcunov

Subject: Re: [PATCH] selftests/kcmp: Remove unused open mode

On Mon, Apr 29, 2024 at 11:46:09PM +0000, Edward Liaw wrote:
> Android bionic warns that open modes are ignored if O_CREAT or O_TMPFILE
> aren't specified. The permissions for the file are set above:
>
> fd1 = open(kpath, O_RDWR | O_CREAT | O_TRUNC, 0644);
>
> Fixes: d97b46a64674 ("syscalls, x86: add __NR_kcmp syscall")
> Signed-off-by: Edward Liaw <[email protected]>

Thanks!

Reviewed-by: Cyrill Gorcunov <[email protected]>