2024-05-08 00:30:47

by Ashok Raj

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] platform/x86/intel/ifs: Initialize AMX state for the scan test

On Tue, May 07, 2024 at 04:53:44PM -0700, Bae, Chang Seok wrote:
> In-Field Scan aborts if AMX state is not in initialized state. Use
> kernel_fpu_begin_mask(KFPU_AMX) to ensure AMX state is initialized.
>
> Introduce custom FPU handling wrappers to ensure compliance with the
> established FPU API semantics. This change follows the EFI case from
> commit b0dc553cfc9d ("x86/fpu: Make the EFI FPU calling convention
> explicit").
>
> Then, use these wrappers to surround the MSR_ACTIVATE_SCAN write to
> minimize the critical section. To prevent unnecessary delays, invoke
> ifs_fpu_begin() before entering the rendezvous loop.
>
> Signed-off-by: Chang S. Bae <[email protected]>
> Reviewed-by: Jithu Joseph <[email protected]>
> Tested-by: Jithu Joseph <[email protected]>
> Acked-by: Hans de Goede <[email protected]>

Reviewed-by: Ashok Raj <[email protected]>

for both patches.