2024-05-13 17:17:28

by Tejun Heo

[permalink] [raw]
Subject: Re: [RFC PATCH] workqueue: Fix rescuer task's name truncated

Hello

On Sat, May 11, 2024 at 03:15:11PM +0100, Aaron Tomlin wrote:
> > @@ -5439,6 +5439,8 @@ static int init_rescuer(struct workqueue_struct *wq)
> > return ret;
> > }
> >
> > + snprintf(rescuer->desc, sizeof(rescuer->desc), "%s", wq->name);

Can you please address the testbot reported warning?

> > wq->rescuer = rescuer;
> > if (wq->flags & WQ_UNBOUND)
> > kthread_bind_mask(rescuer->task, wq_unbound_cpumask);
> > @@ -6289,6 +6291,8 @@ void wq_worker_comm(char *buf, size_t size, struct task_struct *task)
> > worker->desc);
> > }
> > raw_spin_unlock_irq(&pool->lock);
> > + } else if (worker->desc[0] != '\0') {
> > + scnprintf(buf + off, size - off, "-%s", worker->desc);
> > }
> > }
> >
> > --
>
> Reviewed-by: Aaron Tomlin <[email protected]>

The patch looks fine to me otherwise.

Thanks.

--
tejun