2024-05-16 13:33:41

by Dr. David Alan Gilbert

Subject: [PATCH] dmaengine: moxart-dma: remove unused struct 'moxart_filter_data'

From: "Dr. David Alan Gilbert" <[email protected]>

'moxart_filter_data' never appears to have been used.
Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/dma/moxart-dma.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c
index c48d68cbff92..66dc6d31b603 100644
--- a/drivers/dma/moxart-dma.c
+++ b/drivers/dma/moxart-dma.c
@@ -148,11 +148,6 @@ struct moxart_dmadev {
unsigned int irq;
};

-struct moxart_filter_data {
- struct moxart_dmadev *mdc;
- struct of_phandle_args *dma_spec;
-};
-
static const unsigned int es_bytes[] = {
[MOXART_DMA_DATA_TYPE_S8] = 1,
[MOXART_DMA_DATA_TYPE_S16] = 2,
--
2.45.0

2024-05-16 14:54:33

by Frank Li

Subject: Re: [PATCH] dmaengine: moxart-dma: remove unused struct 'moxart_filter_data'

On Thu, May 16, 2024 at 02:32:50PM +0100, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'moxart_filter_data' never appears to have been used.
> Remove it.

You can duplicate subject.

Remove unused struct moxart_filter_data.

>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> ---
> drivers/dma/moxart-dma.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c
> index c48d68cbff92..66dc6d31b603 100644
> --- a/drivers/dma/moxart-dma.c
> +++ b/drivers/dma/moxart-dma.c
> @@ -148,11 +148,6 @@ struct moxart_dmadev {
> unsigned int irq;
> };
>
> -struct moxart_filter_data {
> - struct moxart_dmadev *mdc;
> - struct of_phandle_args *dma_spec;
> -};
> -
> static const unsigned int es_bytes[] = {
> [MOXART_DMA_DATA_TYPE_S8] = 1,
> [MOXART_DMA_DATA_TYPE_S16] = 2,
> --
> 2.45.0
>

2024-05-16 15:29:41

by Dr. David Alan Gilbert

Subject: Re: [PATCH] dmaengine: moxart-dma: remove unused struct 'moxart_filter_data'

* Frank Li ([email protected]) wrote:
> On Thu, May 16, 2024 at 02:32:50PM +0100, [email protected] wrote:
> > From: "Dr. David Alan Gilbert" <[email protected]>
> >
> > 'moxart_filter_data' never appears to have been used.
> > Remove it.
>
> You can duplicate subject.
>
> Remove unused struct moxart_filter_data.

V2 sent.

Dave

> >
> > Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> > ---
> > drivers/dma/moxart-dma.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c
> > index c48d68cbff92..66dc6d31b603 100644
> > --- a/drivers/dma/moxart-dma.c
> > +++ b/drivers/dma/moxart-dma.c
> > @@ -148,11 +148,6 @@ struct moxart_dmadev {
> > unsigned int irq;
> > };
> >
> > -struct moxart_filter_data {
> > - struct moxart_dmadev *mdc;
> > - struct of_phandle_args *dma_spec;
> > -};
> > -
> > static const unsigned int es_bytes[] = {
> > [MOXART_DMA_DATA_TYPE_S8] = 1,
> > [MOXART_DMA_DATA_TYPE_S16] = 2,
> > --
> > 2.45.0
> >
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/