2024-06-03 00:24:00

by Jeff Johnson

[permalink] [raw]
Subject: [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ublk_drv.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <[email protected]>
---
drivers/block/ublk_drv.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index 4e159948c912..59916895ee2e 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -3017,4 +3017,5 @@ module_param_cb(ublks_max, &ublk_max_ublks_ops, &ublks_max, 0644);
MODULE_PARM_DESC(ublks_max, "max number of ublk devices allowed to add(default: 64)");

MODULE_AUTHOR("Ming Lei <[email protected]>");
+MODULE_DESCRIPTION("Userspace block device");
MODULE_LICENSE("GPL");

---
base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
change-id: 20240602-md-block-ublk_drv-01507a0ba6fb



2024-06-03 00:54:29

by Ming Lei

[permalink] [raw]
Subject: Re: [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro

On Sun, Jun 02, 2024 at 05:23:26PM -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ublk_drv.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <[email protected]>
> ---
> drivers/block/ublk_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
> index 4e159948c912..59916895ee2e 100644
> --- a/drivers/block/ublk_drv.c
> +++ b/drivers/block/ublk_drv.c
> @@ -3017,4 +3017,5 @@ module_param_cb(ublks_max, &ublk_max_ublks_ops, &ublks_max, 0644);
> MODULE_PARM_DESC(ublks_max, "max number of ublk devices allowed to add(default: 64)");
>
> MODULE_AUTHOR("Ming Lei <[email protected]>");
> +MODULE_DESCRIPTION("Userspace block device");
> MODULE_LICENSE("GPL");

Reviewed-by: Ming Lei <[email protected]>

Thanks,
Ming