On Mon, Jun 03, 2024 at 07:38:33AM +0100, Ben Walsh wrote:
> @@ -484,6 +492,18 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
> }
> ACPI_COMPANION_SET(dev, adev);
> }
> +
> + if (quirks & CROS_EC_LPC_QUIRK_AML_MUTEX) {
> + const char *name
> + = driver_data->quirk_aml_mutex_name;
> + ret = cros_ec_lpc_mec_acpi_mutex(adev, name);
* Assuming the `adev = ACPI_COMPANION(dev);` didn't move in previous patch,
`adev` here could be uninitialized.
* Also, it shouldn't rely on CROS_EC_LPC_QUIRK_ACPI_ID to set the `adev`.
To keep it simple, I would suggest to use ACPI_COMPANION() instead.