From: "Dr. David Alan Gilbert" <[email protected]>
'prop_map' has been unused since the original
commit e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support").
Remove it.
Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/fpga/altera-fpga2sdram.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
index 6b60ca004345..f4de3fea0b2d 100644
--- a/drivers/fpga/altera-fpga2sdram.c
+++ b/drivers/fpga/altera-fpga2sdram.c
@@ -75,12 +75,6 @@ static int alt_fpga2sdram_enable_set(struct fpga_bridge *bridge, bool enable)
return _alt_fpga2sdram_enable_set(bridge->priv, enable);
}
-struct prop_map {
- char *prop_name;
- u32 *prop_value;
- u32 prop_max;
-};
-
static const struct fpga_bridge_ops altera_fpga2sdram_br_ops = {
.enable_set = alt_fpga2sdram_enable_set,
.enable_show = alt_fpga2sdram_enable_show,
--
2.45.1
On Thu, May 30, 2024 at 09:52:45PM +0100, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'prop_map' has been unused since the original
> commit e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
Reviewed-by: Russ Weight <[email protected]>
> ---
> drivers/fpga/altera-fpga2sdram.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
> index 6b60ca004345..f4de3fea0b2d 100644
> --- a/drivers/fpga/altera-fpga2sdram.c
> +++ b/drivers/fpga/altera-fpga2sdram.c
> @@ -75,12 +75,6 @@ static int alt_fpga2sdram_enable_set(struct fpga_bridge *bridge, bool enable)
> return _alt_fpga2sdram_enable_set(bridge->priv, enable);
> }
>
> -struct prop_map {
> - char *prop_name;
> - u32 *prop_value;
> - u32 prop_max;
> -};
> -
> static const struct fpga_bridge_ops altera_fpga2sdram_br_ops = {
> .enable_set = alt_fpga2sdram_enable_set,
> .enable_show = alt_fpga2sdram_enable_show,
> --
> 2.45.1
>
On Thu, May 30, 2024 at 09:52:45PM +0100, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
This is only needed if the person sending the patch is not the author.
>
> 'prop_map' has been unused since the original
> commit e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support").
Please use 'fixes:' tag.
Thanks,
Yilun
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> ---
> drivers/fpga/altera-fpga2sdram.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
> index 6b60ca004345..f4de3fea0b2d 100644
> --- a/drivers/fpga/altera-fpga2sdram.c
> +++ b/drivers/fpga/altera-fpga2sdram.c
> @@ -75,12 +75,6 @@ static int alt_fpga2sdram_enable_set(struct fpga_bridge *bridge, bool enable)
> return _alt_fpga2sdram_enable_set(bridge->priv, enable);
> }
>
> -struct prop_map {
> - char *prop_name;
> - u32 *prop_value;
> - u32 prop_max;
> -};
> -
> static const struct fpga_bridge_ops altera_fpga2sdram_br_ops = {
> .enable_set = alt_fpga2sdram_enable_set,
> .enable_show = alt_fpga2sdram_enable_show,
> --
> 2.45.1
>
>
* Xu Yilun ([email protected]) wrote:
> On Thu, May 30, 2024 at 09:52:45PM +0100, [email protected] wrote:
> > From: "Dr. David Alan Gilbert" <[email protected]>
>
> This is only needed if the person sending the patch is not the author.
>
> >
> > 'prop_map' has been unused since the original
> > commit e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support").
>
> Please use 'fixes:' tag.
I've avoided using fixes: on this series because it's not a bug;
stable and downstream maintainers use Fixes: to indicate that they
should pick up a patch on top of something they already have; there's
no need for anyone to backport this.
Dave
> Thanks,
> Yilun
>
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> > ---
> > drivers/fpga/altera-fpga2sdram.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
> > index 6b60ca004345..f4de3fea0b2d 100644
> > --- a/drivers/fpga/altera-fpga2sdram.c
> > +++ b/drivers/fpga/altera-fpga2sdram.c
> > @@ -75,12 +75,6 @@ static int alt_fpga2sdram_enable_set(struct fpga_bridge *bridge, bool enable)
> > return _alt_fpga2sdram_enable_set(bridge->priv, enable);
> > }
> >
> > -struct prop_map {
> > - char *prop_name;
> > - u32 *prop_value;
> > - u32 prop_max;
> > -};
> > -
> > static const struct fpga_bridge_ops altera_fpga2sdram_br_ops = {
> > .enable_set = alt_fpga2sdram_enable_set,
> > .enable_show = alt_fpga2sdram_enable_show,
> > --
> > 2.45.1
> >
> >
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
On Tue, Jun 11, 2024 at 10:41:23AM +0000, Dr. David Alan Gilbert wrote:
> * Xu Yilun ([email protected]) wrote:
> > On Thu, May 30, 2024 at 09:52:45PM +0100, [email protected] wrote:
> > > From: "Dr. David Alan Gilbert" <[email protected]>
> >
> > This is only needed if the person sending the patch is not the author.
> >
> > >
> > > 'prop_map' has been unused since the original
> > > commit e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support").
> >
> > Please use 'fixes:' tag.
>
> I've avoided using fixes: on this series because it's not a bug;
> stable and downstream maintainers use Fixes: to indicate that they
> should pick up a patch on top of something they already have; there's
> no need for anyone to backport this.
It's good to me.
Acked-by: Xu Yilun <[email protected]>
Applied to for-next.