2024-01-03 10:28:02

by Arnd Bergmann

Subject: [PATCH] soc/tegra: fix build failure on Tegra241

From: Arnd Bergmann <[email protected]>

If all the other SoCs are disabled, the driver fails to build:

drivers/soc/tegra/fuse/fuse-tegra30.c:684:17: error: 'tegra30_fuse_read' undeclared here (not in a function); did you mean 'tegra_fuse_readl'?
684 | .read = tegra30_fuse_read,
| ^~~~~~~~~~~~~~~~~
| tegra_fuse_readl
drivers/soc/tegra/fuse/fuse-tegra30.c:694:17: error: 'tegra30_fuse_init' undeclared here (not in a function); did you mean 'tegra_fuse_info'?
694 | .init = tegra30_fuse_init,
| ^~~~~~~~~~~~~~~~~

Fix the list of SoCs using this function to include the newly added one.

Fixes: dee509eb9cd5 ("soc/tegra: fuse: Add support for Tegra241")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/soc/tegra/fuse/fuse-tegra30.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c
index 2070d36c510d..eb14e5ff5a0a 100644
--- a/drivers/soc/tegra/fuse/fuse-tegra30.c
+++ b/drivers/soc/tegra/fuse/fuse-tegra30.c
@@ -38,7 +38,8 @@
defined(CONFIG_ARCH_TEGRA_210_SOC) || \
defined(CONFIG_ARCH_TEGRA_186_SOC) || \
defined(CONFIG_ARCH_TEGRA_194_SOC) || \
- defined(CONFIG_ARCH_TEGRA_234_SOC)
+ defined(CONFIG_ARCH_TEGRA_234_SOC) || \
+ defined(CONFIG_ARCH_TEGRA_241_SOC)
static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned int offset)
{
if (WARN_ON(!fuse->base))
--
2.39.2

2024-01-30 11:02:12

by Jon Hunter

Subject: Re: [PATCH] soc/tegra: fix build failure on Tegra241

On 03/01/2024 10:26, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> If all the other SoCs are disabled, the driver fails to build:
>
> drivers/soc/tegra/fuse/fuse-tegra30.c:684:17: error: 'tegra30_fuse_read' undeclared here (not in a function); did you mean 'tegra_fuse_readl'?
> 684 | .read = tegra30_fuse_read,
> | ^~~~~~~~~~~~~~~~~
> | tegra_fuse_readl
> drivers/soc/tegra/fuse/fuse-tegra30.c:694:17: error: 'tegra30_fuse_init' undeclared here (not in a function); did you mean 'tegra_fuse_info'?
> 694 | .init = tegra30_fuse_init,
> | ^~~~~~~~~~~~~~~~~
>
> Fix the list of SoCs using this function to include the newly added one.
>
> Fixes: dee509eb9cd5 ("soc/tegra: fuse: Add support for Tegra241")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/soc/tegra/fuse/fuse-tegra30.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c
> index 2070d36c510d..eb14e5ff5a0a 100644
> --- a/drivers/soc/tegra/fuse/fuse-tegra30.c
> +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c
> @@ -38,7 +38,8 @@
> defined(CONFIG_ARCH_TEGRA_210_SOC) || \
> defined(CONFIG_ARCH_TEGRA_186_SOC) || \
> defined(CONFIG_ARCH_TEGRA_194_SOC) || \
> - defined(CONFIG_ARCH_TEGRA_234_SOC)
> + defined(CONFIG_ARCH_TEGRA_234_SOC) || \
> + defined(CONFIG_ARCH_TEGRA_241_SOC)
> static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned int offset)
> {
> if (WARN_ON(!fuse->base))


Thanks for fixing!

Reviewed-by: Jon Hunter <[email protected]>

Jon

--
nvpublic

2024-01-30 12:13:50

by Kartik Rajput

Subject: Re: [PATCH] soc/tegra: fix build failure on Tegra241

On Wed, 2024-01-03 at 11:26 +0100, Arnd Bergmann wrote:
> External email: Use caution opening links or attachments
>
>
> From: Arnd Bergmann <[email protected]>
>
> If all the other SoCs are disabled, the driver fails to build:
>
> drivers/soc/tegra/fuse/fuse-tegra30.c:684:17: error:
> 'tegra30_fuse_read' undeclared here (not in a function); did you mean
> 'tegra_fuse_readl'?
>   684 |         .read = tegra30_fuse_read,
>       |                 ^~~~~~~~~~~~~~~~~
>       |                 tegra_fuse_readl
> drivers/soc/tegra/fuse/fuse-tegra30.c:694:17: error:
> 'tegra30_fuse_init' undeclared here (not in a function); did you mean
> 'tegra_fuse_info'?
>   694 |         .init = tegra30_fuse_init,
>       |                 ^~~~~~~~~~~~~~~~~
>
> Fix the list of SoCs using this function to include the newly added
> one.
>
> Fixes: dee509eb9cd5 ("soc/tegra: fuse: Add support for Tegra241")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
>  drivers/soc/tegra/fuse/fuse-tegra30.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c
> b/drivers/soc/tegra/fuse/fuse-tegra30.c
> index 2070d36c510d..eb14e5ff5a0a 100644
> --- a/drivers/soc/tegra/fuse/fuse-tegra30.c
> +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c
> @@ -38,7 +38,8 @@
>      defined(CONFIG_ARCH_TEGRA_210_SOC) || \
>      defined(CONFIG_ARCH_TEGRA_186_SOC) || \
>      defined(CONFIG_ARCH_TEGRA_194_SOC) || \
> -    defined(CONFIG_ARCH_TEGRA_234_SOC)
> +    defined(CONFIG_ARCH_TEGRA_234_SOC) || \
> +    defined(CONFIG_ARCH_TEGRA_241_SOC)
>  static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned
> int offset)
>  {
>         if (WARN_ON(!fuse->base))
> --
> 2.39.2
>

Thanks Arnd!

Reviewed-by: Kartik <[email protected]>