2016-11-16 03:00:09

by Stephen Rothwell

Subject: linux-next: build warning after merge of the phy-next tree

Hi Kishon,

After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/phy/phy-rockchip-inno-usb2.c: In function 'rockchip_chg_detect_work':
drivers/phy/phy-rockchip-inno-usb2.c:717:7: warning: 'tmout' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (tmout) {
^

Introduced by commit

0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399")

--
Cheers,
Stephen Rothwell

2016-11-16 13:29:09

by wlf

Subject: Re: linux-next: build warning after merge of the phy-next tree

Hi Stephen，

在 2016年11月16日 11:00, Stephen Rothwell 写道:
> Hi Kishon,
>
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/phy/phy-rockchip-inno-usb2.c: In function 'rockchip_chg_detect_work':
> drivers/phy/phy-rockchip-inno-usb2.c:717:7: warning: 'tmout' may be used uninitialized in this function [-Wmaybe-uninitialized]
> if (tmout) {
> ^
>
> Introduced by commit
>
> 0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399")
The variable "tmout" is initialized in the prior code "case
USB_CHG_STATE_WAIT_FOR_DCD",
and this case will be executed before "if (tmout)", so I think it's a
mis-warning for some
special compiler.

Could you provide me some suggestion about this warning? Should I upload
a new patch to
fix this compiler mis-warning or just ignore it ？ :-)

Best regards，
wulf

>

2016-11-16 16:39:56

by Kishon Vijay Abraham I

Subject: Re: linux-next: build warning after merge of the phy-next tree

Hi,

On Wednesday 16 November 2016 06:58 PM, wlf wrote:
> Hi Stephen，
>
> 在 2016年11月16日 11:00, Stephen Rothwell 写道:
>> Hi Kishon,
>>
>> After merging the phy-next tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> drivers/phy/phy-rockchip-inno-usb2.c: In function 'rockchip_chg_detect_work':
>> drivers/phy/phy-rockchip-inno-usb2.c:717:7: warning: 'tmout' may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
>> if (tmout) {
>> ^
>>
>> Introduced by commit
>>
>> 0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399")

Thank you for reporting this issue.

> The variable "tmout" is initialized in the prior code "case
> USB_CHG_STATE_WAIT_FOR_DCD",
> and this case will be executed before "if (tmout)", so I think it's a
> mis-warning for some
> special compiler.
>
> Could you provide me some suggestion about this warning? Should I upload a new
> patch to
> fix this compiler mis-warning or just ignore it ？ :-)

Arnd has already sent a fix it. I've picked that one.

Thanks
Kishon