convert the binding file extcon-usbc-cros-ec.txt to
yaml format extcon-usbc-cros-ec.yaml
This was tested and verified on ARM with:
make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
Signed-off-by: Dafna Hirschfeld <[email protected]>
Reviewed-by: Enric Balletbo i Serra <[email protected]>
---
Changes since v1:
1 - changing the license to (GPL-2.0-only OR BSD-2-Clause)
2 - changing the maintainers
3 - changing the google,usb-port-id property to have minimum 0 and maximum 255
Changes since v2:
1 - Changing the patch subject to start with "dt-bindings: extcon: usbc-cros-ec:"
2 - In the example, adding a parent isp node, a reg field to cros-ec@0
and adding nodes 'extcon0/1' instead of one node 'extcon'.
Changes since v3:
in the example, changing the node isp1 to spi0
.../bindings/extcon/extcon-usbc-cros-ec.txt | 24 --------
.../bindings/extcon/extcon-usbc-cros-ec.yaml | 56 +++++++++++++++++++
2 files changed, 56 insertions(+), 24 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
create mode 100644 Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
diff --git a/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
deleted file mode 100644
index 8e8625c00dfa..000000000000
--- a/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
+++ /dev/null
@@ -1,24 +0,0 @@
-ChromeOS EC USB Type-C cable and accessories detection
-
-On ChromeOS systems with USB Type C ports, the ChromeOS Embedded Controller is
-able to detect the state of external accessories such as display adapters
-or USB devices when said accessories are attached or detached.
-
-The node for this device must be under a cros-ec node like google,cros-ec-spi
-or google,cros-ec-i2c.
-
-Required properties:
-- compatible: Should be "google,extcon-usbc-cros-ec".
-- google,usb-port-id: Specifies the USB port ID to use.
-
-Example:
- cros-ec@0 {
- compatible = "google,cros-ec-i2c";
-
- ...
-
- extcon {
- compatible = "google,extcon-usbc-cros-ec";
- google,usb-port-id = <0>;
- };
- }
diff --git a/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
new file mode 100644
index 000000000000..9c5849b341ea
--- /dev/null
+++ b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/extcon/extcon-usbc-cros-ec.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ChromeOS EC USB Type-C cable and accessories detection
+
+maintainers:
+ - Benson Leung <[email protected]>
+ - Enric Balletbo i Serra <[email protected]>
+
+description: |
+ On ChromeOS systems with USB Type C ports, the ChromeOS Embedded Controller is
+ able to detect the state of external accessories such as display adapters
+ or USB devices when said accessories are attached or detached.
+ The node for this device must be under a cros-ec node like google,cros-ec-spi
+ or google,cros-ec-i2c.
+
+properties:
+ compatible:
+ const: google,extcon-usbc-cros-ec
+
+ google,usb-port-id:
+ allOf:
+ - $ref: /schemas/types.yaml#/definitions/uint32
+ description: the port id
+ minimum: 0
+ maximum: 255
+
+required:
+ - compatible
+ - google,usb-port-id
+
+additionalProperties: false
+
+examples:
+ - |
+ spi0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ cros-ec@0 {
+ compatible = "google,cros-ec-spi";
+ reg = <0>;
+
+ usbc_extcon0: extcon0 {
+ compatible = "google,extcon-usbc-cros-ec";
+ google,usb-port-id = <0>;
+ };
+
+ usbc_extcon1: extcon1 {
+ compatible = "google,extcon-usbc-cros-ec";
+ google,usb-port-id = <1>;
+ };
+ };
+ };
--
2.17.1
On 2/13/20 9:39 PM, Dafna Hirschfeld wrote:
> convert the binding file extcon-usbc-cros-ec.txt to
> yaml format extcon-usbc-cros-ec.yaml
>
> This was tested and verified on ARM with:
> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
>
> Signed-off-by: Dafna Hirschfeld <[email protected]>
> Reviewed-by: Enric Balletbo i Serra <[email protected]>
> ---
> Changes since v1:
> 1 - changing the license to (GPL-2.0-only OR BSD-2-Clause)
> 2 - changing the maintainers
> 3 - changing the google,usb-port-id property to have minimum 0 and maximum 255
>
> Changes since v2:
> 1 - Changing the patch subject to start with "dt-bindings: extcon: usbc-cros-ec:"
> 2 - In the example, adding a parent isp node, a reg field to cros-ec@0
> and adding nodes 'extcon0/1' instead of one node 'extcon'.
>
> Changes since v3:
> in the example, changing the node isp1 to spi0
>
> .../bindings/extcon/extcon-usbc-cros-ec.txt | 24 --------
> .../bindings/extcon/extcon-usbc-cros-ec.yaml | 56 +++++++++++++++++++
> 2 files changed, 56 insertions(+), 24 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
> create mode 100644 Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
>
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
> deleted file mode 100644
> index 8e8625c00dfa..000000000000
> --- a/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -ChromeOS EC USB Type-C cable and accessories detection
> -
> -On ChromeOS systems with USB Type C ports, the ChromeOS Embedded Controller is
> -able to detect the state of external accessories such as display adapters
> -or USB devices when said accessories are attached or detached.
> -
> -The node for this device must be under a cros-ec node like google,cros-ec-spi
> -or google,cros-ec-i2c.
> -
> -Required properties:
> -- compatible: Should be "google,extcon-usbc-cros-ec".
> -- google,usb-port-id: Specifies the USB port ID to use.
> -
> -Example:
> - cros-ec@0 {
> - compatible = "google,cros-ec-i2c";
> -
> - ...
> -
> - extcon {
> - compatible = "google,extcon-usbc-cros-ec";
> - google,usb-port-id = <0>;
> - };
> - }
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
> new file mode 100644
> index 000000000000..9c5849b341ea
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: https://protect2.fireeye.com/url?k=d3c63a24-8e5dc647-d3c7b16b-0cc47a31cdbc-e8d8e2b7806aed8e&u=http://devicetree.org/schemas/extcon/extcon-usbc-cros-ec.yaml#
> +$schema: https://protect2.fireeye.com/url?k=04f78247-596c7e24-04f60908-0cc47a31cdbc-1b9a3937c161a4b6&u=http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ChromeOS EC USB Type-C cable and accessories detection
> +
> +maintainers:
> + - Benson Leung <[email protected]>
> + - Enric Balletbo i Serra <[email protected]>
> +
> +description: |
> + On ChromeOS systems with USB Type C ports, the ChromeOS Embedded Controller is
> + able to detect the state of external accessories such as display adapters
> + or USB devices when said accessories are attached or detached.
> + The node for this device must be under a cros-ec node like google,cros-ec-spi
> + or google,cros-ec-i2c.
> +
> +properties:
> + compatible:
> + const: google,extcon-usbc-cros-ec
> +
> + google,usb-port-id:
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + description: the port id
> + minimum: 0
> + maximum: 255
> +
> +required:
> + - compatible
> + - google,usb-port-id
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + spi0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + cros-ec@0 {
> + compatible = "google,cros-ec-spi";
> + reg = <0>;
> +
> + usbc_extcon0: extcon0 {
> + compatible = "google,extcon-usbc-cros-ec";
> + google,usb-port-id = <0>;
> + };
> +
> + usbc_extcon1: extcon1 {
> + compatible = "google,extcon-usbc-cros-ec";
> + google,usb-port-id = <1>;
> + };
> + };
> + };
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
On Mon, Feb 17, 2020 at 4:30 AM Chanwoo Choi <[email protected]> wrote:
>
> On 2/13/20 9:39 PM, Dafna Hirschfeld wrote:
> > convert the binding file extcon-usbc-cros-ec.txt to
> > yaml format extcon-usbc-cros-ec.yaml
> >
> > This was tested and verified on ARM with:
> > make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
> > make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
> >
> > Signed-off-by: Dafna Hirschfeld <[email protected]>
> > Reviewed-by: Enric Balletbo i Serra <[email protected]>
> > ---
> > Changes since v1:
> > 1 - changing the license to (GPL-2.0-only OR BSD-2-Clause)
> > 2 - changing the maintainers
> > 3 - changing the google,usb-port-id property to have minimum 0 and maximum 255
> >
> > Changes since v2:
> > 1 - Changing the patch subject to start with "dt-bindings: extcon: usbc-cros-ec:"
> > 2 - In the example, adding a parent isp node, a reg field to cros-ec@0
> > and adding nodes 'extcon0/1' instead of one node 'extcon'.
> >
> > Changes since v3:
> > in the example, changing the node isp1 to spi0
> >
> > .../bindings/extcon/extcon-usbc-cros-ec.txt | 24 --------
> > .../bindings/extcon/extcon-usbc-cros-ec.yaml | 56 +++++++++++++++++++
> > 2 files changed, 56 insertions(+), 24 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
> > create mode 100644 Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
> > deleted file mode 100644
> > index 8e8625c00dfa..000000000000
> > --- a/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
> > +++ /dev/null
> > @@ -1,24 +0,0 @@
> > -ChromeOS EC USB Type-C cable and accessories detection
> > -
> > -On ChromeOS systems with USB Type C ports, the ChromeOS Embedded Controller is
> > -able to detect the state of external accessories such as display adapters
> > -or USB devices when said accessories are attached or detached.
> > -
> > -The node for this device must be under a cros-ec node like google,cros-ec-spi
> > -or google,cros-ec-i2c.
> > -
> > -Required properties:
> > -- compatible: Should be "google,extcon-usbc-cros-ec".
> > -- google,usb-port-id: Specifies the USB port ID to use.
> > -
> > -Example:
> > - cros-ec@0 {
> > - compatible = "google,cros-ec-i2c";
> > -
> > - ...
> > -
> > - extcon {
> > - compatible = "google,extcon-usbc-cros-ec";
> > - google,usb-port-id = <0>;
> > - };
> > - }
> > diff --git a/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
> > new file mode 100644
> > index 000000000000..9c5849b341ea
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
> > @@ -0,0 +1,56 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: https://protect2.fireeye.com/url?k=d3c63a24-8e5dc647-d3c7b16b-0cc47a31cdbc-e8d8e2b7806aed8e&u=http://devicetree.org/schemas/extcon/extcon-usbc-cros-ec.yaml#
> > +$schema: https://protect2.fireeye.com/url?k=04f78247-596c7e24-04f60908-0cc47a31cdbc-1b9a3937c161a4b6&u=http://devicetree.org/meta-schemas/core.yaml#
^^^
> > +
> > +title: ChromeOS EC USB Type-C cable and accessories detection
> > +
> > +maintainers:
> > + - Benson Leung <[email protected]>
> > + - Enric Balletbo i Serra <[email protected]>
> > +
> > +description: |
> > + On ChromeOS systems with USB Type C ports, the ChromeOS Embedded Controller is
> > + able to detect the state of external accessories such as display adapters
> > + or USB devices when said accessories are attached or detached.
> > + The node for this device must be under a cros-ec node like google,cros-ec-spi
> > + or google,cros-ec-i2c.
> > +
> > +properties:
> > + compatible:
> > + const: google,extcon-usbc-cros-ec
> > +
> > + google,usb-port-id:
> > + allOf:
> > + - $ref: /schemas/types.yaml#/definitions/uint32
> > + description: the port id
> > + minimum: 0
> > + maximum: 255
> > +
> > +required:
> > + - compatible
> > + - google,usb-port-id
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + spi0 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + cros-ec@0 {
> > + compatible = "google,cros-ec-spi";
> > + reg = <0>;
> > +
> > + usbc_extcon0: extcon0 {
> > + compatible = "google,extcon-usbc-cros-ec";
> > + google,usb-port-id = <0>;
> > + };
> > +
> > + usbc_extcon1: extcon1 {
> > + compatible = "google,extcon-usbc-cros-ec";
> > + google,usb-port-id = <1>;
> > + };
> > + };
> > + };
> >
>
> Applied it. Thanks.
And once again corrupted it when applying it:
Documentation/devicetree/bindings/Makefile:12: recipe for target
'Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.example.dts'
failed
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/jsonschema/validators.py",
line 774, in resolve_from_url
document = self.store[url]
File "/usr/local/lib/python3.6/dist-packages/jsonschema/_utils.py",
line 22, in __getitem__
return self.store[self.normalize(uri)]
KeyError: 'https://protect2.fireeye.com/url?k=04f78247-596c7e24-04f60908-0cc47a31cdbc-1b9a3937c161a4b6&u=http://devicetree.org/meta-schemas/core.yaml'
On 2/19/20 11:20 AM, Rob Herring wrote:
> On Mon, Feb 17, 2020 at 4:30 AM Chanwoo Choi <[email protected]> wrote:
>>
>> On 2/13/20 9:39 PM, Dafna Hirschfeld wrote:
>>> convert the binding file extcon-usbc-cros-ec.txt to
>>> yaml format extcon-usbc-cros-ec.yaml
>>>
>>> This was tested and verified on ARM with:
>>> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
>>> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
>>>
>>> Signed-off-by: Dafna Hirschfeld <[email protected]>
>>> Reviewed-by: Enric Balletbo i Serra <[email protected]>
>>> ---
>>> Changes since v1:
>>> 1 - changing the license to (GPL-2.0-only OR BSD-2-Clause)
>>> 2 - changing the maintainers
>>> 3 - changing the google,usb-port-id property to have minimum 0 and maximum 255
>>>
>>> Changes since v2:
>>> 1 - Changing the patch subject to start with "dt-bindings: extcon: usbc-cros-ec:"
>>> 2 - In the example, adding a parent isp node, a reg field to cros-ec@0
>>> and adding nodes 'extcon0/1' instead of one node 'extcon'.
>>>
>>> Changes since v3:
>>> in the example, changing the node isp1 to spi0
>>>
>>> .../bindings/extcon/extcon-usbc-cros-ec.txt | 24 --------
>>> .../bindings/extcon/extcon-usbc-cros-ec.yaml | 56 +++++++++++++++++++
>>> 2 files changed, 56 insertions(+), 24 deletions(-)
>>> delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
>>> create mode 100644 Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
>>> deleted file mode 100644
>>> index 8e8625c00dfa..000000000000
>>> --- a/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
>>> +++ /dev/null
>>> @@ -1,24 +0,0 @@
>>> -ChromeOS EC USB Type-C cable and accessories detection
>>> -
>>> -On ChromeOS systems with USB Type C ports, the ChromeOS Embedded Controller is
>>> -able to detect the state of external accessories such as display adapters
>>> -or USB devices when said accessories are attached or detached.
>>> -
>>> -The node for this device must be under a cros-ec node like google,cros-ec-spi
>>> -or google,cros-ec-i2c.
>>> -
>>> -Required properties:
>>> -- compatible: Should be "google,extcon-usbc-cros-ec".
>>> -- google,usb-port-id: Specifies the USB port ID to use.
>>> -
>>> -Example:
>>> - cros-ec@0 {
>>> - compatible = "google,cros-ec-i2c";
>>> -
>>> - ...
>>> -
>>> - extcon {
>>> - compatible = "google,extcon-usbc-cros-ec";
>>> - google,usb-port-id = <0>;
>>> - };
>>> - }
>>> diff --git a/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
>>> new file mode 100644
>>> index 000000000000..9c5849b341ea
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
>>> @@ -0,0 +1,56 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: https://protect2.fireeye.com/url?k=d3c63a24-8e5dc647-d3c7b16b-0cc47a31cdbc-e8d8e2b7806aed8e&u=http://devicetree.org/schemas/extcon/extcon-usbc-cros-ec.yaml#
>>> +$schema: https://protect2.fireeye.com/url?k=04f78247-596c7e24-04f60908-0cc47a31cdbc-1b9a3937c161a4b6&u=http://devicetree.org/meta-schemas/core.yaml#
>
> ^^^
>
>>> +
>>> +title: ChromeOS EC USB Type-C cable and accessories detection
>>> +
>>> +maintainers:
>>> + - Benson Leung <[email protected]>
>>> + - Enric Balletbo i Serra <[email protected]>
>>> +
>>> +description: |
>>> + On ChromeOS systems with USB Type C ports, the ChromeOS Embedded Controller is
>>> + able to detect the state of external accessories such as display adapters
>>> + or USB devices when said accessories are attached or detached.
>>> + The node for this device must be under a cros-ec node like google,cros-ec-spi
>>> + or google,cros-ec-i2c.
>>> +
>>> +properties:
>>> + compatible:
>>> + const: google,extcon-usbc-cros-ec
>>> +
>>> + google,usb-port-id:
>>> + allOf:
>>> + - $ref: /schemas/types.yaml#/definitions/uint32
>>> + description: the port id
>>> + minimum: 0
>>> + maximum: 255
>>> +
>>> +required:
>>> + - compatible
>>> + - google,usb-port-id
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> + - |
>>> + spi0 {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + cros-ec@0 {
>>> + compatible = "google,cros-ec-spi";
>>> + reg = <0>;
>>> +
>>> + usbc_extcon0: extcon0 {
>>> + compatible = "google,extcon-usbc-cros-ec";
>>> + google,usb-port-id = <0>;
>>> + };
>>> +
>>> + usbc_extcon1: extcon1 {
>>> + compatible = "google,extcon-usbc-cros-ec";
>>> + google,usb-port-id = <1>;
>>> + };
>>> + };
>>> + };
>>>
>>
>> Applied it. Thanks.
>
> And once again corrupted it when applying it:
>
> Documentation/devicetree/bindings/Makefile:12: recipe for target
> 'Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.example.dts'
> failed
> Traceback (most recent call last):
> File "/usr/local/lib/python3.6/dist-packages/jsonschema/validators.py",
> line 774, in resolve_from_url
> document = self.store[url]
> File "/usr/local/lib/python3.6/dist-packages/jsonschema/_utils.py",
> line 22, in __getitem__
> return self.store[self.normalize(uri)]
> KeyError: 'https://protect2.fireeye.com/url?k=04f78247-596c7e24-04f60908-0cc47a31cdbc-1b9a3937c161a4b6&u=http://devicetree.org/meta-schemas/core.yaml'
>
>
I'm sorry for that. It was added by company
firewall system automatically when I applied it to git.
It was my mistake. I'll edit them and pushed again.
Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics