2022-08-04 10:13:57

by Ming Qian

Subject: [PATCH] media: imx-jpeg: Disable useless interrupt to avoid kernel panic

There is a hardware bug that the interrupt STMBUF_HALF may be triggered
after or when disable interrupt.
It may led to unexpected kernel panic.
And interrupt STMBUF_HALF and STMBUF_RTND have no other effect.
So disable them and the unused interrupts.

meanwhile clear the interrupt status when disable interrupt.

Signed-off-by: Ming Qian <[email protected]>
---
drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
index 9418fcf740a8..ef28122a5ed4 100644
--- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
+++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
@@ -76,12 +76,14 @@ void print_wrapper_info(struct device *dev, void __iomem *reg)

void mxc_jpeg_enable_irq(void __iomem *reg, int slot)
{
- writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
+ writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_STATUS));
+ writel(0xF0C, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
}

void mxc_jpeg_disable_irq(void __iomem *reg, int slot)
{
writel(0x0, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
+ writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_STATUS));
}

void mxc_jpeg_sw_reset(void __iomem *reg)
--
2.37.1

2022-08-17 22:34:52

by Mirela Rabulea

Subject: Re: [PATCH] media: imx-jpeg: Disable useless interrupt to avoid kernel panic

On Thu, 2022-08-04 at 17:38 +0800, Ming Qian wrote:
> There is a hardware bug that the interrupt STMBUF_HALF may be
> triggered
> after or when disable interrupt.
> It may led to unexpected kernel panic.
> And interrupt STMBUF_HALF and STMBUF_RTND have no other effect.
> So disable them and the unused interrupts.
>
> meanwhile clear the interrupt status when disable interrupt.
>
> Signed-off-by: Ming Qian <[email protected]>

Reviewed-by: Mirela Rabulea <[email protected]>

> ---
> drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
> b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
> index 9418fcf740a8..ef28122a5ed4 100644
> --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
> +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c
> @@ -76,12 +76,14 @@ void print_wrapper_info(struct device *dev, void
> __iomem *reg)
>
> void mxc_jpeg_enable_irq(void __iomem *reg, int slot)
> {
> - writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
> + writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_STATUS));
> + writel(0xF0C, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
> }
>
> void mxc_jpeg_disable_irq(void __iomem *reg, int slot)
> {
> writel(0x0, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN));
> + writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_STATUS));
> }
>
> void mxc_jpeg_sw_reset(void __iomem *reg)