2024-03-07 09:46:03

by Xingui Yang

[permalink] [raw]
Subject: [PATCH v3 0/3] scsi: libsas: Fix disk not being scanned in after being removed

This patch series fixes an issue when do discovery on an empty PHY to
update PHY info after device unregister could cause newly connected device
to not be scanned.

Changes since v2:
- Based on John's suggestion, allow smp_execute_task() arguments to be on
the stack.
- Based on John's suggestion, add a helper sas_get_sas_addr_and_dev_type.
- Updated comments.

Changes since v1:
- Use sas_get_phy_discover() instead of sas_get_phy_attached_dev() in
sas_rediscover_dev() and use disc_resp to update phy info.

Xingui Yang (3):
scsi: libsas: Allow smp_execute_task() arguments to be on the stack
scsi: libsas: Add a helper sas_get_sas_addr_and_dev_type()
scsi: libsas: Fix disk not being scanned in after being removed

drivers/scsi/libsas/sas_expander.c | 64 ++++++++++++++++++++----------
1 file changed, 42 insertions(+), 22 deletions(-)

--
2.17.1



2024-03-07 10:15:15

by John Garry

[permalink] [raw]
Subject: Re: [PATCH v3 0/3] scsi: libsas: Fix disk not being scanned in after being removed

On 07/03/2024 09:37, Xingui Yang wrote:
> This patch series fixes an issue when do discovery on an empty PHY to
> update PHY info after device unregister could cause newly connected device
> to not be scanned.
>
> Changes since v2:
> - Based on John's suggestion, allow smp_execute_task() arguments to be on
> the stack.

You can't just change one particular smp_execute_task() callsite to put
the disc memories on the stack - they should all be changed.

Better yet, we should see how the changes look and then decide to change
at all.

Anyway, since you are simplifying the code, let's revisit the
smp_execute_task() change later.

Thanks,
John