Bindings expect UART/serial node names to be "serial".
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
index afba5f04c8ec..bf4d9e917925 100644
--- a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi
@@ -195,7 +195,7 @@ gic: interrupt-controller@ff100000 {
};
&iso {
- uart0: serial0@800 {
+ uart0: serial@800 {
compatible = "snps,dw-apb-uart";
reg = <0x800 0x400>;
reg-shift = <2>;
@@ -207,7 +207,7 @@ uart0: serial0@800 {
};
&misc {
- uart1: serial1@200 {
+ uart1: serial@200 {
compatible = "snps,dw-apb-uart";
reg = <0x200 0x400>;
reg-shift = <2>;
@@ -217,7 +217,7 @@ uart1: serial1@200 {
status = "disabled";
};
- uart2: serial2@400 {
+ uart2: serial@400 {
compatible = "snps,dw-apb-uart";
reg = <0x400 0x400>;
reg-shift = <2>;
--
2.34.1
On Mon, 23 Jan 2023 16:15:14 +0100, Krzysztof Kozlowski wrote:
> Bindings expect UART/serial node names to be "serial".
>
>
Applied, thanks!
Let me know if anyone preferred to take it via sub-arch/SoC maintainer tree.
I'll drop it then.
[1/1] arm64: dts: realtek: align UART node name with bindings
https://git.kernel.org/krzk/linux-dt/c/5ad30c5fc0a72c2aaa1d26f9e4061d8646231adb
Best regards,
--
Krzysztof Kozlowski <[email protected]>
On 27.01.23 10:46, Krzysztof Kozlowski wrote:
> On Mon, 23 Jan 2023 16:15:14 +0100, Krzysztof Kozlowski wrote:
>> Bindings expect UART/serial node names to be "serial".
>
> Applied, thanks!
>
> Let me know if anyone preferred to take it via sub-arch/SoC maintainer tree.
> I'll drop it then.
We did have an equivalent patch in '21, from Zhen Lei of Huawei, that I
gave a Reviewed-by for. So should you maybe apply that original patch
instead?
Reminder: My Realtek testing broke when someone removed upstream support
for adjusting the text offset (they have a boot ROM at start of memory).
Regards,
Andreas
>
> [1/1] arm64: dts: realtek: align UART node name with bindings
> https://git.kernel.org/krzk/linux-dt/c/5ad30c5fc0a72c2aaa1d26f9e4061d8646231adb
>
> Best regards,
--
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nürnberg)
On 27/01/2023 13:22, Andreas Färber wrote:
> On 27.01.23 10:46, Krzysztof Kozlowski wrote:
>> On Mon, 23 Jan 2023 16:15:14 +0100, Krzysztof Kozlowski wrote:
>>> Bindings expect UART/serial node names to be "serial".
>>
>> Applied, thanks!
>>
>> Let me know if anyone preferred to take it via sub-arch/SoC maintainer tree.
>> I'll drop it then.
>
> We did have an equivalent patch in '21, from Zhen Lei of Huawei, that I
> gave a Reviewed-by for. So should you maybe apply that original patch
> instead?
I don't have it in my inbox... but if you reviewed it, why didn't pick
it up? Or whoever is/was the maintainer? I personally do not care about
Realtek but I do care about bindings checks to succeed without warnings.
Best regards,
Krzysztof