2022-10-23 20:56:52

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Signed-off-by missing for commit in the kbuild-current tree

Hi all,

Commit

9a21115ca50e ("Documentation: kbuild: Add description of git for reproducible builds")

is missing a Signed-off-by from its committer.

Also, I am guessing (I haven't actually done the build, yet) that this
will produce a new build warning from (e.g.) "make htmldocs", as the
underlining of the new "Git" header line is longer than it should be.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2022-10-24 06:38:06

by Dan Li

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commit in the kbuild-current tree



On 10/22/22 18:48, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 9a21115ca50e ("Documentation: kbuild: Add description of git for reproducible builds")
>
> is missing a Signed-off-by from its committer.
>
> Also, I am guessing (I haven't actually done the build, yet) that this
> will produce a new build warning from (e.g.) "make htmldocs", as the
> underlining of the new "Git" header line is longer than it should be.

Oh yes, I didn't see a warning when compiling, but it should be aligned
here, sorry for the typo.

To Masahiro:
Do I need to submit a V2 to remove the extra underscore here? I'm willing
to if needed :)

Thanks, Dan.

>

2022-10-27 15:51:47

by Masahiro Yamada

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commit in the kbuild-current tree

On Mon, Oct 24, 2022 at 3:34 PM Dan Li <[email protected]> wrote:
>
>
>
> On 10/22/22 18:48, Stephen Rothwell wrote:
> > Hi all,
> >
> > Commit
> >
> > 9a21115ca50e ("Documentation: kbuild: Add description of git for reproducible builds")
> >
> > is missing a Signed-off-by from its committer.
> >
> > Also, I am guessing (I haven't actually done the build, yet) that this
> > will produce a new build warning from (e.g.) "make htmldocs", as the
> > underlining of the new "Git" header line is longer than it should be.
>
> Oh yes, I didn't see a warning when compiling, but it should be aligned
> here, sorry for the typo.
>
> To Masahiro:
> Do I need to submit a V2 to remove the extra underscore here? I'm willing
> to if needed :)
>
> Thanks, Dan.
>
> >


No, worry.


Just in case, the following is what I applied locally.



index 13397f38c358..f2dcc39044e6 100644
--- a/Documentation/kbuild/reproducible-builds.rst
+++ b/Documentation/kbuild/reproducible-builds.rst
@@ -120,7 +120,7 @@ kernel versions by including an arbitrary string
of "salt" in it.
This is specified by the Kconfig symbol ``CONFIG_BUILD_SALT``.

Git
------------------------
+---

Uncommitted changes or different commit ids in git can also lead
to different compilation results. For example, after executing






--
Best Regards
Masahiro Yamada