2017-12-12 17:19:40

by Cyrille Pitchen

Subject: [PATCH] Revert "dt-bindings: mtd: add sst25wf040b and en25s64 to sip-nor list"

This reverts commit b07815d4eaf658b683c345d6e643895a20d92f29.

The reverted commit was merged into v4-15-rc1 by mistake: it was taken
from the IMX tree but the patch has never been sent to linux-mtd nor
reviewed by any spi-nor maintainers.

Actually, it would have been rejected since we add new values for the
'compatible' DT property only for SPI NOR memories that don't support
the JEDEC READ ID op code (0x9F).

Both en25s64 and sst25wf040b support the JEDEC READ ID op code, hence
should use the "jedec,spi-nor" string alone as 'compatible' value.

See the following link for more details:
http://lists.infradead.org/pipermail/linux-mtd/2017-November/077425.html

Signed-off-by: Cyrille Pitchen <[email protected]>
---
Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt | 2 --
1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
index 376fa2f50e6b..956bb046e599 100644
--- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
+++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
@@ -13,7 +13,6 @@ Required properties:
at25df321a
at25df641
at26df081a
- en25s64
mr25h128
mr25h256
mr25h10
@@ -33,7 +32,6 @@ Required properties:
s25fl008k
s25fl064k
sst25vf040b
- sst25wf040b
m25p40
m25p80
m25p16
--
2.11.0

2017-12-12 16:05:02

by Marek Vasut

Subject: Re: [PATCH] Revert "dt-bindings: mtd: add sst25wf040b and en25s64 to sip-nor list"

On 12/12/2017 02:40 PM, Cyrille Pitchen wrote:
> This reverts commit b07815d4eaf658b683c345d6e643895a20d92f29.
>
> The reverted commit was merged into v4-15-rc1 by mistake: it was taken
> from the IMX tree but the patch has never been sent to linux-mtd nor
> reviewed by any spi-nor maintainers.
>
> Actually, it would have been rejected since we add new values for the
> 'compatible' DT property only for SPI NOR memories that don't support
> the JEDEC READ ID op code (0x9F).
>
> Both en25s64 and sst25wf040b support the JEDEC READ ID op code, hence
> should use the "jedec,spi-nor" string alone as 'compatible' value.
>
> See the following link for more details:
> http://lists.infradead.org/pipermail/linux-mtd/2017-November/077425.html
>
> Signed-off-by: Cyrille Pitchen <[email protected]>

Acked-by: Marek Vasut <[email protected]>

> ---
> Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
> index 376fa2f50e6b..956bb046e599 100644
> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
> @@ -13,7 +13,6 @@ Required properties:
> at25df321a
> at25df641
> at26df081a
> - en25s64
> mr25h128
> mr25h256
> mr25h10
> @@ -33,7 +32,6 @@ Required properties:
> s25fl008k
> s25fl064k
> sst25vf040b
> - sst25wf040b
> m25p40
> m25p80
> m25p16
>


--
Best regards,
Marek Vasut

2017-12-12 18:39:55

by Cyrille Pitchen

Subject: Re: [PATCH] Revert "dt-bindings: mtd: add sst25wf040b and en25s64 to sip-nor list"

Le 12/12/2017 à 16:58, Marek Vasut a écrit :
> On 12/12/2017 02:40 PM, Cyrille Pitchen wrote:
>> This reverts commit b07815d4eaf658b683c345d6e643895a20d92f29.
>>
>> The reverted commit was merged into v4-15-rc1 by mistake: it was taken
>> from the IMX tree but the patch has never been sent to linux-mtd nor
>> reviewed by any spi-nor maintainers.
>>
>> Actually, it would have been rejected since we add new values for the
>> 'compatible' DT property only for SPI NOR memories that don't support
>> the JEDEC READ ID op code (0x9F).
>>
>> Both en25s64 and sst25wf040b support the JEDEC READ ID op code, hence
>> should use the "jedec,spi-nor" string alone as 'compatible' value.
>>
>> See the following link for more details:
>> http://lists.infradead.org/pipermail/linux-mtd/2017-November/077425.html
>>
>> Signed-off-by: Cyrille Pitchen <[email protected]>
>
> Acked-by: Marek Vasut <[email protected]>
>

Applied on the spi-nor/fixes branch of linux-mtd

>> ---
>> Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
>> index 376fa2f50e6b..956bb046e599 100644
>> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
>> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
>> @@ -13,7 +13,6 @@ Required properties:
>> at25df321a
>> at25df641
>> at26df081a
>> - en25s64
>> mr25h128
>> mr25h256
>> mr25h10
>> @@ -33,7 +32,6 @@ Required properties:
>> s25fl008k
>> s25fl064k
>> sst25vf040b
>> - sst25wf040b
>> m25p40
>> m25p80
>> m25p16
>>
>
>