2021-03-04 11:05:40

by Pali Rohár

[permalink] [raw]
Subject: [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc()

IRQ domain alloc function should return zero on success. Non-zero value
indicates failure.

Signed-off-by: Pali Rohár <[email protected]>
Fixes: fc54bae28818 ("PCI: iproc: Allow allocation of multiple MSIs")
---
drivers/pci/controller/pcie-iproc-msi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pcie-iproc-msi.c b/drivers/pci/controller/pcie-iproc-msi.c
index 908475d27e0e..eede4e8f3f75 100644
--- a/drivers/pci/controller/pcie-iproc-msi.c
+++ b/drivers/pci/controller/pcie-iproc-msi.c
@@ -271,7 +271,7 @@ static int iproc_msi_irq_domain_alloc(struct irq_domain *domain,
NULL, NULL);
}

- return hwirq;
+ return 0;
}

static void iproc_msi_irq_domain_free(struct irq_domain *domain,
--
2.20.1


2021-03-04 11:33:08

by Marc Zyngier

[permalink] [raw]
Subject: Re: [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc()

On Wed, 03 Mar 2021 14:22:02 +0000,
Pali Rohár <[email protected]> wrote:
>
> IRQ domain alloc function should return zero on success. Non-zero value
> indicates failure.
>
> Signed-off-by: Pali Rohár <[email protected]>
> Fixes: fc54bae28818 ("PCI: iproc: Allow allocation of multiple MSIs")
> ---
> drivers/pci/controller/pcie-iproc-msi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-iproc-msi.c b/drivers/pci/controller/pcie-iproc-msi.c
> index 908475d27e0e..eede4e8f3f75 100644
> --- a/drivers/pci/controller/pcie-iproc-msi.c
> +++ b/drivers/pci/controller/pcie-iproc-msi.c
> @@ -271,7 +271,7 @@ static int iproc_msi_irq_domain_alloc(struct irq_domain *domain,
> NULL, NULL);
> }
>
> - return hwirq;
> + return 0;
> }
>
> static void iproc_msi_irq_domain_free(struct irq_domain *domain,

Acked-by: Marc Zyngier <[email protected]>

M.

--
Without deviation from the norm, progress is not possible.

2021-03-04 12:19:21

by Ray Jui

[permalink] [raw]
Subject: Re: [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc()



On 3/3/2021 6:22 AM, Pali Rohár wrote:
> IRQ domain alloc function should return zero on success. Non-zero value
> indicates failure.
>
> Signed-off-by: Pali Rohár <[email protected]>
> Fixes: fc54bae28818 ("PCI: iproc: Allow allocation of multiple MSIs")
> ---
> drivers/pci/controller/pcie-iproc-msi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-iproc-msi.c b/drivers/pci/controller/pcie-iproc-msi.c
> index 908475d27e0e..eede4e8f3f75 100644
> --- a/drivers/pci/controller/pcie-iproc-msi.c
> +++ b/drivers/pci/controller/pcie-iproc-msi.c
> @@ -271,7 +271,7 @@ static int iproc_msi_irq_domain_alloc(struct irq_domain *domain,
> NULL, NULL);
> }
>
> - return hwirq;
> + return 0;
> }
>
> static void iproc_msi_irq_domain_free(struct irq_domain *domain,
>

Looks good to me. Thanks for the fix.

Acked-by: Ray Jui <[email protected]>

Attachments:
smime.p7s (4.09 kB)
S/MIME Cryptographic Signature

2021-03-07 00:00:59

by Krzysztof Wilczyński

[permalink] [raw]
Subject: Re: [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc()

Hi Pali,

> IRQ domain alloc function should return zero on success. Non-zero value
> indicates failure.
>
> Signed-off-by: Pali Rohár <[email protected]>
> Fixes: fc54bae28818 ("PCI: iproc: Allow allocation of multiple MSIs")
[...]

Nice catch!

Reviewed-by: Krzysztof Wilczyński <[email protected]>

Krzysztof

2021-03-22 14:22:05

by Lorenzo Pieralisi

[permalink] [raw]
Subject: Re: [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc()

On Wed, 3 Mar 2021 15:22:02 +0100, Pali Rohár wrote:
> IRQ domain alloc function should return zero on success. Non-zero value
> indicates failure.

Applied to pci/iproc, thanks!

[1/1] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc()
https://git.kernel.org/lpieralisi/pci/c/1e83130f01

Thanks,
Lorenzo