2023-01-20 03:03:04

by Yang Yang

Subject: [PATCH linux-next] mm/hugetlb: replace get_hwpoison_huge_page() with get_hwpoison_hugetlb_folio() when !CONFIG_HUGETLBFS

From: Yang Yang <[email protected]>

When CONFIG_HUGETLBFS is not set, there are two problems. One
is implicit declaration of function get_hwpoison_hugetlb_folio(),
the other is get_hwpoison_huge_page() is defined but not used.
Fix them all by defining get_hwpoison_hugetlb_folio() instead of
get_hwpoison_huge_page() when !CONFIG_HUGETLB_PAGE.

Fixes: 92e109a2c5a7 ("mm/hugetlb: convert get_hwpoison_huge_page() to folios")
Signed-off-by: Yang Yang <[email protected]>
---
include/linux/hugetlb.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index f14a6bd2a6ed..9189cc359c64 100644
--- a/include/linux/hugetlb.h
+++ b/include/linux/hugetlb.h
@@ -417,7 +417,8 @@ static inline int isolate_hugetlb(struct folio *folio, struct list_head *list)
return -EBUSY;
}

-static inline int get_hwpoison_huge_page(struct page *page, bool *hugetlb, bool unpoison)
+static inline int get_hwpoison_hugetlb_folio(struct folio *folio, bool *hugetlb,
+ bool unpoison)
{
return 0;
}
--
2.25.1

2023-01-20 06:17:35

by Sidhartha Kumar

Subject: Re: [PATCH linux-next] mm/hugetlb: replace get_hwpoison_huge_page() with get_hwpoison_hugetlb_foli o() when !CONFIG_HUGETLBFS

On 1/19/23 6:36 PM, [email protected] wrote:
> From: Yang Yang <[email protected]>
>
> When CONFIG_HUGETLBFS is not set, there are two problems. One
> is implicit declaration of function get_hwpoison_hugetlb_folio(),
> the other is get_hwpoison_huge_page() is defined but not used.
> Fix them all by defining get_hwpoison_hugetlb_folio() instead of
> get_hwpoison_huge_page() when !CONFIG_HUGETLB_PAGE.
>
> Fixes: 92e109a2c5a7 ("mm/hugetlb: convert get_hwpoison_huge_page() to folios")
> Signed-off-by: Yang Yang <[email protected]>
> ---
> include/linux/hugetlb.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index f14a6bd2a6ed..9189cc359c64 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -417,7 +417,8 @@ static inline int isolate_hugetlb(struct folio *folio, struct list_head *list)
> return -EBUSY;
> }
>
> -static inline int get_hwpoison_huge_page(struct page *page, bool *hugetlb, bool unpoison)
> +static inline int get_hwpoison_hugetlb_folio(struct folio *folio, bool *hugetlb,
> + bool unpoison)
> {
> return 0;
> }

I believe this issue has been fixed by this patch:

https://lore.kernel.org/linux-mm/[email protected]/T/

which has been added to mm-unstable now.

Thanks,
Sidhartha Kumar