2021-10-26 11:09:36

by Colin Ian King

Subject: [PATCH][next] gve: Fix spelling mistake "droping" -> "dropping"

There is a spelling mistake in a netdev_warn message. Fix it.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/google/gve/gve_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/google/gve/gve_rx.c b/drivers/net/ethernet/google/gve/gve_rx.c
index c8500babbd1d..ef4aa6487c55 100644
--- a/drivers/net/ethernet/google/gve/gve_rx.c
+++ b/drivers/net/ethernet/google/gve/gve_rx.c
@@ -438,7 +438,7 @@ static bool gve_rx_ctx_init(struct gve_rx_ctx *ctx, struct gve_rx_ring *rx)
if (frag_size > rx->packet_buffer_size) {
packet_size_error = true;
netdev_warn(priv->dev,
- "RX fragment error: packet_buffer_size=%d, frag_size=%d, droping packet.",
+ "RX fragment error: packet_buffer_size=%d, frag_size=%d, dropping packet.",
rx->packet_buffer_size, be16_to_cpu(desc->len));
}
page_info = &rx->data.page_info[idx];
--
2.32.0

2021-10-26 12:42:53

by Denis Kirjanov

Subject: Re: [PATCH][next] gve: Fix spelling mistake "droping" -> "dropping"

10/26/21 12:22 PM, Colin Ian King пишет:
> There is a spelling mistake in a netdev_warn message. Fix it.
>
> Signed-off-by: Colin Ian King <[email protected]>

you could fix the second instance as well:

grep -nri droping drivers/net/
drivers/net/wireless/mac80211_hwsim.c:1279: /* Droping until WARN_QUEUE
level */
drivers/net/ethernet/google/gve/gve_rx.c:441: "RX fragment error:
packet_buffer_size=%d, frag_size=%d, droping packet.",


> ---
> drivers/net/ethernet/google/gve/gve_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/google/gve/gve_rx.c b/drivers/net/ethernet/google/gve/gve_rx.c
> index c8500babbd1d..ef4aa6487c55 100644
> --- a/drivers/net/ethernet/google/gve/gve_rx.c
> +++ b/drivers/net/ethernet/google/gve/gve_rx.c
> @@ -438,7 +438,7 @@ static bool gve_rx_ctx_init(struct gve_rx_ctx *ctx, struct gve_rx_ring *rx)
> if (frag_size > rx->packet_buffer_size) {
> packet_size_error = true;
> netdev_warn(priv->dev,
> - "RX fragment error: packet_buffer_size=%d, frag_size=%d, droping packet.",
> + "RX fragment error: packet_buffer_size=%d, frag_size=%d, dropping packet.",
> rx->packet_buffer_size, be16_to_cpu(desc->len));
> }
> page_info = &rx->data.page_info[idx];
>

2021-10-26 12:46:19

by Colin Ian King

Subject: Re: [PATCH][next] gve: Fix spelling mistake "droping" -> "dropping"

On 26/10/2021 10:32, Denis Kirjanov wrote:
>
>
> 10/26/21 12:22 PM, Colin Ian King пишет:
>> There is a spelling mistake in a netdev_warn message. Fix it.
>>
>> Signed-off-by: Colin Ian King <[email protected]>
>
> you could fix the second instance as well:

Will do. Thanks for noting that :-)

>
> grep -nri droping drivers/net/
> drivers/net/wireless/mac80211_hwsim.c:1279:        /* Droping until
> WARN_QUEUE level */
> drivers/net/ethernet/google/gve/gve_rx.c:441:                    "RX
> fragment error: packet_buffer_size=%d, frag_size=%d, droping packet.",
>
>
>> ---
>>   drivers/net/ethernet/google/gve/gve_rx.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/google/gve/gve_rx.c
>> b/drivers/net/ethernet/google/gve/gve_rx.c
>> index c8500babbd1d..ef4aa6487c55 100644
>> --- a/drivers/net/ethernet/google/gve/gve_rx.c
>> +++ b/drivers/net/ethernet/google/gve/gve_rx.c
>> @@ -438,7 +438,7 @@ static bool gve_rx_ctx_init(struct gve_rx_ctx
>> *ctx, struct gve_rx_ring *rx)
>>           if (frag_size > rx->packet_buffer_size) {
>>               packet_size_error = true;
>>               netdev_warn(priv->dev,
>> -                    "RX fragment error: packet_buffer_size=%d,
>> frag_size=%d, droping packet.",
>> +                    "RX fragment error: packet_buffer_size=%d,
>> frag_size=%d, dropping packet.",
>>                       rx->packet_buffer_size, be16_to_cpu(desc->len));
>>           }
>>           page_info = &rx->data.page_info[idx];
>>

2022-03-17 05:31:24

by patchwork-bot+netdevbpf

Subject: Re: [PATCH][next] gve: Fix spelling mistake "droping" -> "dropping"

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Tue, 15 Mar 2022 22:26:15 +0000 you wrote:
> There is a spelling mistake in a netdev_warn warning. Fix it.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/net/ethernet/google/gve/gve_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [next] gve: Fix spelling mistake "droping" -> "dropping"
https://git.kernel.org/netdev/net-next/c/2fc559c8cba0

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html