2022-05-14 04:06:49

by Gautam Menghani

Subject: [PATCH] kselftests/ir : Improve readability of modprobe error message

Improve the readability of error message which says module not found.
The new behaviour is consistent with the modprobe command.

Signed-off-by: Gautam Menghani <[email protected]>
---
tools/testing/selftests/ir/ir_loopback.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/ir/ir_loopback.sh b/tools/testing/selftests/ir/ir_loopback.sh
index b90dc9939f45..aff9299c9416 100755
--- a/tools/testing/selftests/ir/ir_loopback.sh
+++ b/tools/testing/selftests/ir/ir_loopback.sh
@@ -10,7 +10,7 @@ if [ $UID != 0 ]; then
fi

if ! /sbin/modprobe -q -n rc-loopback; then
- echo "ir_loopback: module rc-loopback is not found [SKIP]"
+ echo "ir_loopback: module rc-loopback is not found in /lib/modules/`uname -r` [SKIP]"
exit $ksft_skip
fi

--
2.25.1

2022-05-17 07:08:30

by Shuah Khan

Subject: Re: [PATCH] kselftests/ir : Improve readability of modprobe error message

On 5/13/22 1:07 PM, Gautam Menghani wrote:
> Improve the readability of error message which says module not found.
> The new behaviour is consistent with the modprobe command.
>
> Signed-off-by: Gautam Menghani <[email protected]>
> ---
> tools/testing/selftests/ir/ir_loopback.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ir/ir_loopback.sh b/tools/testing/selftests/ir/ir_loopback.sh
> index b90dc9939f45..aff9299c9416 100755
> --- a/tools/testing/selftests/ir/ir_loopback.sh
> +++ b/tools/testing/selftests/ir/ir_loopback.sh
> @@ -10,7 +10,7 @@ if [ $UID != 0 ]; then
> fi
>
> if ! /sbin/modprobe -q -n rc-loopback; then
> - echo "ir_loopback: module rc-loopback is not found [SKIP]"
> + echo "ir_loopback: module rc-loopback is not found in /lib/modules/`uname -r` [SKIP]"
> exit $ksft_skip
> fi
>
>

Applied to linux-kselftest next for 5.19-rc1

thanks,
-- Shuah