2020-12-07 16:59:47

by Rafael J. Wysocki

Subject: [PATCH] ACPI: scan: Drop INT3396 from acpi_ignore_dep_ids[]

From: Rafael J. Wysocki <[email protected]>

According to Hans, all device objects where the _HID returns
"INT3396" also have a _CID returning "PNP0D80", so the former
need not be present in acpi_ignore_dep_ids[] any more.

Link: https://lore.kernel.org/linux-acpi/[email protected]/
Suggested-by: Hans de Goede <[email protected]>
Signed-off-by: Rafael J. Wysocki <[email protected]>
---

On top of https://patchwork.kernel.org/project/linux-acpi/patch/3849919.JfvvSOo2yN@kreacher/

---
drivers/acpi/scan.c | 1 -
1 file changed, 1 deletion(-)

Index: linux-pm/drivers/acpi/scan.c
===================================================================
--- linux-pm.orig/drivers/acpi/scan.c
+++ linux-pm/drivers/acpi/scan.c
@@ -751,7 +751,6 @@ static bool acpi_info_matches_ids(struct

/* List of HIDs for which we ignore matching ACPI devices, when checking _DEP lists. */
static const char * const acpi_ignore_dep_ids[] = {
- "INT3396", /* Windows System Power Management Controller */
"PNP0D80", /* Windows-compatible System Power Management Controller */
NULL
};

2020-12-07 17:00:57

by Hans de Goede

Subject: Re: [PATCH] ACPI: scan: Drop INT3396 from acpi_ignore_dep_ids[]

Hi,

On 12/7/20 5:55 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <[email protected]>
>
> According to Hans, all device objects where the _HID returns
> "INT3396" also have a _CID returning "PNP0D80", so the former
> need not be present in acpi_ignore_dep_ids[] any more.
>
> Link: https://lore.kernel.org/linux-acpi/[email protected]/
> Suggested-by: Hans de Goede <[email protected]>
> Signed-off-by: Rafael J. Wysocki <[email protected]>

Thanks, patch looks good to me. FWIW:

Acked-by: Hans de Goede <[email protected]>

Regards,

Hans


> ---
>
> On top of https://patchwork.kernel.org/project/linux-acpi/patch/3849919.JfvvSOo2yN@kreacher/
>
> ---
> drivers/acpi/scan.c | 1 -
> 1 file changed, 1 deletion(-)
>
> Index: linux-pm/drivers/acpi/scan.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/scan.c
> +++ linux-pm/drivers/acpi/scan.c
> @@ -751,7 +751,6 @@ static bool acpi_info_matches_ids(struct
>
> /* List of HIDs for which we ignore matching ACPI devices, when checking _DEP lists. */
> static const char * const acpi_ignore_dep_ids[] = {
> - "INT3396", /* Windows System Power Management Controller */
> "PNP0D80", /* Windows-compatible System Power Management Controller */
> NULL
> };
>
>
>