2024-04-19 19:20:15

by Nam Cao

Subject: [PATCH] checkpatch: add "Reported-and-tested-by:" tag

The tag "Reported-and-tested-by:" is used all the time. Add this tag.

Signed-off-by: Nam Cao <[email protected]>
---
scripts/checkpatch.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9c4c4a61bc83..ff44720fcf23 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -618,6 +618,7 @@ our $signature_tags = qr{(?xi:
Tested-by:|
Reviewed-by:|
Reported-by:|
+ Reported-and-tested-by:|
Suggested-by:|
To:|
Cc:
@@ -712,7 +713,7 @@ sub find_standard_signature {
my ($sign_off) = @_;
my @standard_signature_tags = (
'Signed-off-by:', 'Co-developed-by:', 'Acked-by:', 'Tested-by:',
- 'Reviewed-by:', 'Reported-by:', 'Suggested-by:'
+ 'Reviewed-by:', 'Reported-by:', 'Suggested-by:', 'Reported-and-tested-by'
);
foreach my $signature (@standard_signature_tags) {
return $signature if (get_edit_distance($sign_off, $signature) <= 2);
--
2.39.2

2024-04-19 22:06:29

by Joe Perches

Subject: Re: [PATCH] checkpatch: add "Reported-and-tested-by:" tag

On 2024-04-19 12:19, Nam Cao wrote:
> The tag "Reported-and-tested-by:" is used all the time. Add this tag.
>
> Signed-off-by: Nam Cao <[email protected]>
> ---
> scripts/checkpatch.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 9c4c4a61bc83..ff44720fcf23 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -618,6 +618,7 @@ our $signature_tags = qr{(?xi:
> Tested-by:|
> Reviewed-by:|
> Reported-by:|
> + Reported-and-tested-by:|
> Suggested-by:|
> To:|
> Cc:
> @@ -712,7 +713,7 @@ sub find_standard_signature {
> my ($sign_off) = @_;
> my @standard_signature_tags = (
> 'Signed-off-by:', 'Co-developed-by:', 'Acked-by:', 'Tested-by:',
> - 'Reviewed-by:', 'Reported-by:', 'Suggested-by:'
> + 'Reviewed-by:', 'Reported-by:', 'Suggested-by:',
> 'Reported-and-tested-by'

Missing a colon
> );
> foreach my $signature (@standard_signature_tags) {
> return $signature if (get_edit_distance($sign_off, $signature) <=
> 2);