2024-04-25 09:38:10

by Xiu Jianfeng

Subject: [PATCH -next] cgroup/cpuset: Remove outdated comment in sched_partition_write()

The comment here is outdated and can cause confusion, from the code
perspective, there’s also no need for new comment, so just remove it.

Signed-off-by: Xiu Jianfeng <[email protected]>
---
kernel/cgroup/cpuset.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index f5443c039619..a10e4bd0c0c1 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -3774,9 +3774,6 @@ static ssize_t sched_partition_write(struct kernfs_open_file *of, char *buf,

buf = strstrip(buf);

- /*
- * Convert "root" to ENABLED, and convert "member" to DISABLED.
- */
if (!strcmp(buf, "root"))
val = PRS_ROOT;
else if (!strcmp(buf, "member"))
--
2.34.1

2024-04-25 12:25:03

by Waiman Long

Subject: Re: [PATCH -next] cgroup/cpuset: Remove outdated comment in sched_partition_write()

On 4/25/24 05:30, Xiu Jianfeng wrote:
> The comment here is outdated and can cause confusion, from the code
> perspective, there’s also no need for new comment, so just remove it.
>
> Signed-off-by: Xiu Jianfeng <[email protected]>
> ---
> kernel/cgroup/cpuset.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index f5443c039619..a10e4bd0c0c1 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -3774,9 +3774,6 @@ static ssize_t sched_partition_write(struct kernfs_open_file *of, char *buf,
>
> buf = strstrip(buf);
>
> - /*
> - * Convert "root" to ENABLED, and convert "member" to DISABLED.
> - */
> if (!strcmp(buf, "root"))
> val = PRS_ROOT;
> else if (!strcmp(buf, "member"))

Yes, that comment is now no longer relevant.

Acked-by: Waiman Long <[email protected]>

2024-04-25 17:39:03

by Tejun Heo

Subject: Re: [PATCH -next] cgroup/cpuset: Remove outdated comment in sched_partition_write()

On Thu, Apr 25, 2024 at 09:30:16AM +0000, Xiu Jianfeng wrote:
> The comment here is outdated and can cause confusion, from the code
> perspective, there’s also no need for new comment, so just remove it.
>
> Signed-off-by: Xiu Jianfeng <[email protected]>

Applied to cgroup/for-6.10.

Thanks.

--
tejun