2024-05-04 11:39:04

by Dan Carpenter

Subject: [PATCH] btrfs: fix array index in qgroup_auto_inherit()

The "i++" was accidentally left out so it just sets qgids[0] over and
over.

Fixes: 5343cd9364ea ("btrfs: qgroup: simple quota auto hierarchy for nested subvolumes")
Signed-off-by: Dan Carpenter <[email protected]>
---
From static analysis. Untested.

fs/btrfs/qgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index 2ca6bbc1bcc9..1284e78fffce 100644
--- a/fs/btrfs/qgroup.c
+++ b/fs/btrfs/qgroup.c
@@ -3121,7 +3121,7 @@ static int qgroup_auto_inherit(struct btrfs_fs_info *fs_info,
qgids = res->qgroups;

list_for_each_entry(qg_list, &inode_qg->groups, next_group)
- qgids[i] = qg_list->group->qgroupid;
+ qgids[i++] = qg_list->group->qgroupid;

*inherit = res;
return 0;
--
2.43.0

2024-05-06 17:46:06

by David Sterba

Subject: Re: [PATCH] btrfs: fix array index in qgroup_auto_inherit()

On Sat, May 04, 2024 at 02:38:41PM +0300, Dan Carpenter wrote:
> The "i++" was accidentally left out so it just sets qgids[0] over and
> over.
>
> Fixes: 5343cd9364ea ("btrfs: qgroup: simple quota auto hierarchy for nested subvolumes")
> Signed-off-by: Dan Carpenter <[email protected]>
> ---
> >From static analysis. Untested.

A real bug, thanks. Patch added to for-next.