2024-05-29 20:45:55

by Jeff Johnson

Subject: [PATCH] scftorture: make torture_type static

Fix the 'make C=1' warning:
kernel/scftorture.c:71:6: warning: symbol 'torture_type' was not declared. Should it be static?

Signed-off-by: Jeff Johnson <[email protected]>
---
kernel/scftorture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/scftorture.c b/kernel/scftorture.c
index 59032aaccd18..13ad348143ca 100644
--- a/kernel/scftorture.c
+++ b/kernel/scftorture.c
@@ -67,7 +67,7 @@ torture_param(int, weight_many_wait, -1, "Testing weight for multi-CPU operation
torture_param(int, weight_all, -1, "Testing weight for all-CPU no-wait operations.");
torture_param(int, weight_all_wait, -1, "Testing weight for all-CPU operations.");

-char *torture_type = "";
+static char *torture_type = "";

#ifdef MODULE
# define SCFTORT_SHUTDOWN 0

---
base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
change-id: 20240529-static-scftorture-c86eccd9e30e

2024-05-29 22:16:25

by Paul E. McKenney

Subject: Re: [PATCH] scftorture: make torture_type static

On Wed, May 29, 2024 at 01:45:40PM -0700, Jeff Johnson wrote:
> Fix the 'make C=1' warning:
> kernel/scftorture.c:71:6: warning: symbol 'torture_type' was not declared. Should it be static?
>
> Signed-off-by: Jeff Johnson <[email protected]>

I queued both this and the scftorture.c fix, thank you!!!

Thanx, Paul

> ---
> kernel/scftorture.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/scftorture.c b/kernel/scftorture.c
> index 59032aaccd18..13ad348143ca 100644
> --- a/kernel/scftorture.c
> +++ b/kernel/scftorture.c
> @@ -67,7 +67,7 @@ torture_param(int, weight_many_wait, -1, "Testing weight for multi-CPU operation
> torture_param(int, weight_all, -1, "Testing weight for all-CPU no-wait operations.");
> torture_param(int, weight_all_wait, -1, "Testing weight for all-CPU operations.");
>
> -char *torture_type = "";
> +static char *torture_type = "";
>
> #ifdef MODULE
> # define SCFTORT_SHUTDOWN 0
>
> ---
> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
> change-id: 20240529-static-scftorture-c86eccd9e30e
>