2022-12-09 14:49:30

by James Hurley

Subject: [PATCH v1 1/1] platform/mellanox: mlxbf-pmc: Fix event typo

Had a duplicate event typo, so just fixed the 1 character typo.

Fixes: 1a218d312e65 ("platform/mellanox: mlxbf-pmc: Add Mellanox BlueField PMC driver")
Signed-off-by: James Hurley <[email protected]>
Reviewed-by: David Thompson <[email protected]>
Reviewed-by: Shravan Kumar Ramani <[email protected]>
---
drivers/platform/mellanox/mlxbf-pmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/mellanox/mlxbf-pmc.c b/drivers/platform/mellanox/mlxbf-pmc.c
index 65b4a819f1bd..c2c9b0d3244c 100644
--- a/drivers/platform/mellanox/mlxbf-pmc.c
+++ b/drivers/platform/mellanox/mlxbf-pmc.c
@@ -358,7 +358,7 @@ static const struct mlxbf_pmc_events mlxbf_pmc_hnfnet_events[] = {
{ 0x32, "DDN_DIAG_W_INGRESS" },
{ 0x33, "DDN_DIAG_C_INGRESS" },
{ 0x34, "DDN_DIAG_CORE_SENT" },
- { 0x35, "NDN_DIAG_S_OUT_OF_CRED" },
+ { 0x35, "NDN_DIAG_N_OUT_OF_CRED" },
{ 0x36, "NDN_DIAG_S_OUT_OF_CRED" },
{ 0x37, "NDN_DIAG_E_OUT_OF_CRED" },
{ 0x38, "NDN_DIAG_W_OUT_OF_CRED" },
--
2.30.1

2022-12-12 10:34:49

by Hans de Goede

Subject: Re: [PATCH v1 1/1] platform/mellanox: mlxbf-pmc: Fix event typo

Hi,

On 12/9/22 15:35, James Hurley wrote:
> Had a duplicate event typo, so just fixed the 1 character typo.
>
> Fixes: 1a218d312e65 ("platform/mellanox: mlxbf-pmc: Add Mellanox BlueField PMC driver")
> Signed-off-by: James Hurley <[email protected]>
> Reviewed-by: David Thompson <[email protected]>
> Reviewed-by: Shravan Kumar Ramani <[email protected]>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
> drivers/platform/mellanox/mlxbf-pmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/mellanox/mlxbf-pmc.c b/drivers/platform/mellanox/mlxbf-pmc.c
> index 65b4a819f1bd..c2c9b0d3244c 100644
> --- a/drivers/platform/mellanox/mlxbf-pmc.c
> +++ b/drivers/platform/mellanox/mlxbf-pmc.c
> @@ -358,7 +358,7 @@ static const struct mlxbf_pmc_events mlxbf_pmc_hnfnet_events[] = {
> { 0x32, "DDN_DIAG_W_INGRESS" },
> { 0x33, "DDN_DIAG_C_INGRESS" },
> { 0x34, "DDN_DIAG_CORE_SENT" },
> - { 0x35, "NDN_DIAG_S_OUT_OF_CRED" },
> + { 0x35, "NDN_DIAG_N_OUT_OF_CRED" },
> { 0x36, "NDN_DIAG_S_OUT_OF_CRED" },
> { 0x37, "NDN_DIAG_E_OUT_OF_CRED" },
> { 0x38, "NDN_DIAG_W_OUT_OF_CRED" },