2023-03-03 12:52:47

by Muhammad Usama Anjum

Subject: [PATCH] accessibility: speakup: remove linux/version.h

make versioncheck reports the following:
./drivers/accessibility/speakup/genmap.c: 13 linux/version.h not needed.
./drivers/accessibility/speakup/makemapdata.c: 13 linux/version.h not needed.

So remove linux/version.h from both of these files.

Signed-off-by: Muhammad Usama Anjum <[email protected]>
---
drivers/accessibility/speakup/genmap.c | 1 -
drivers/accessibility/speakup/makemapdata.c | 1 -
2 files changed, 2 deletions(-)

diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
index 0125000e00d9..0882bab10fb8 100644
--- a/drivers/accessibility/speakup/genmap.c
+++ b/drivers/accessibility/speakup/genmap.c
@@ -10,7 +10,6 @@
#include <stdio.h>
#include <libgen.h>
#include <string.h>
-#include <linux/version.h>
#include <ctype.h>
#include "utils.h"

diff --git a/drivers/accessibility/speakup/makemapdata.c b/drivers/accessibility/speakup/makemapdata.c
index d7d41bb9b05f..55e4ef8a93dc 100644
--- a/drivers/accessibility/speakup/makemapdata.c
+++ b/drivers/accessibility/speakup/makemapdata.c
@@ -10,7 +10,6 @@
#include <stdio.h>
#include <libgen.h>
#include <string.h>
-#include <linux/version.h>
#include <ctype.h>
#include "utils.h"

--
2.39.2

2023-03-03 13:23:10

by Samuel Thibault

Subject: Re: [PATCH] accessibility: speakup: remove linux/version.h

Muhammad Usama Anjum, le ven. 03 mars 2023 17:51:51 +0500, a ecrit:
> make versioncheck reports the following:
> ./drivers/accessibility/speakup/genmap.c: 13 linux/version.h not needed.
> ./drivers/accessibility/speakup/makemapdata.c: 13 linux/version.h not needed.
>
> So remove linux/version.h from both of these files.
>
> Signed-off-by: Muhammad Usama Anjum <[email protected]>

Reviewed-by: Samuel Thibault <[email protected]>

Thanks!

> ---
> drivers/accessibility/speakup/genmap.c | 1 -
> drivers/accessibility/speakup/makemapdata.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
> index 0125000e00d9..0882bab10fb8 100644
> --- a/drivers/accessibility/speakup/genmap.c
> +++ b/drivers/accessibility/speakup/genmap.c
> @@ -10,7 +10,6 @@
> #include <stdio.h>
> #include <libgen.h>
> #include <string.h>
> -#include <linux/version.h>
> #include <ctype.h>
> #include "utils.h"
>
> diff --git a/drivers/accessibility/speakup/makemapdata.c b/drivers/accessibility/speakup/makemapdata.c
> index d7d41bb9b05f..55e4ef8a93dc 100644
> --- a/drivers/accessibility/speakup/makemapdata.c
> +++ b/drivers/accessibility/speakup/makemapdata.c
> @@ -10,7 +10,6 @@
> #include <stdio.h>
> #include <libgen.h>
> #include <string.h>
> -#include <linux/version.h>
> #include <ctype.h>
> #include "utils.h"
>
> --
> 2.39.2
>

--
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.

2023-06-16 13:34:20

by Muhammad Usama Anjum

Subject: Re: [PATCH] accessibility: speakup: remove linux/version.h

Soft reminder.

On 3/3/23 5:51 PM, Muhammad Usama Anjum wrote:
> make versioncheck reports the following:
> ./drivers/accessibility/speakup/genmap.c: 13 linux/version.h not needed.
> ./drivers/accessibility/speakup/makemapdata.c: 13 linux/version.h not needed.
>
> So remove linux/version.h from both of these files.
>
> Signed-off-by: Muhammad Usama Anjum <[email protected]>
> ---
> drivers/accessibility/speakup/genmap.c | 1 -
> drivers/accessibility/speakup/makemapdata.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
> index 0125000e00d9..0882bab10fb8 100644
> --- a/drivers/accessibility/speakup/genmap.c
> +++ b/drivers/accessibility/speakup/genmap.c
> @@ -10,7 +10,6 @@
> #include <stdio.h>
> #include <libgen.h>
> #include <string.h>
> -#include <linux/version.h>
> #include <ctype.h>
> #include "utils.h"
>
> diff --git a/drivers/accessibility/speakup/makemapdata.c b/drivers/accessibility/speakup/makemapdata.c
> index d7d41bb9b05f..55e4ef8a93dc 100644
> --- a/drivers/accessibility/speakup/makemapdata.c
> +++ b/drivers/accessibility/speakup/makemapdata.c
> @@ -10,7 +10,6 @@
> #include <stdio.h>
> #include <libgen.h>
> #include <string.h>
> -#include <linux/version.h>
> #include <ctype.h>
> #include "utils.h"
>

--
BR,
Muhammad Usama Anjum

2023-06-16 14:59:55

by Samuel Thibault

Subject: Re: [PATCH] accessibility: speakup: remove linux/version.h

Muhammad Usama Anjum, le ven. 16 juin 2023 17:53:12 +0500, a ecrit:
> Soft reminder.

It somehow hadn't appeared in my inbox.

> On 3/3/23 5:51 PM, Muhammad Usama Anjum wrote:
> > make versioncheck reports the following:
> > ./drivers/accessibility/speakup/genmap.c: 13 linux/version.h not needed.
> > ./drivers/accessibility/speakup/makemapdata.c: 13 linux/version.h not needed.
> >
> > So remove linux/version.h from both of these files.
> >
> > Signed-off-by: Muhammad Usama Anjum <[email protected]>

Reviewed-by: Samuel Thibault <[email protected]>

Thanks!

> > ---
> > drivers/accessibility/speakup/genmap.c | 1 -
> > drivers/accessibility/speakup/makemapdata.c | 1 -
> > 2 files changed, 2 deletions(-)
> >
> > diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
> > index 0125000e00d9..0882bab10fb8 100644
> > --- a/drivers/accessibility/speakup/genmap.c
> > +++ b/drivers/accessibility/speakup/genmap.c
> > @@ -10,7 +10,6 @@
> > #include <stdio.h>
> > #include <libgen.h>
> > #include <string.h>
> > -#include <linux/version.h>
> > #include <ctype.h>
> > #include "utils.h"
> >
> > diff --git a/drivers/accessibility/speakup/makemapdata.c b/drivers/accessibility/speakup/makemapdata.c
> > index d7d41bb9b05f..55e4ef8a93dc 100644
> > --- a/drivers/accessibility/speakup/makemapdata.c
> > +++ b/drivers/accessibility/speakup/makemapdata.c
> > @@ -10,7 +10,6 @@
> > #include <stdio.h>
> > #include <libgen.h>
> > #include <string.h>
> > -#include <linux/version.h>
> > #include <ctype.h>
> > #include "utils.h"
> >
>
> --
> BR,
> Muhammad Usama Anjum
>

--
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.

2023-06-28 10:58:19

by Muhammad Usama Anjum

Subject: Re: [PATCH] accessibility: speakup: remove linux/version.h

On 6/16/23 7:50 PM, Samuel Thibault wrote:
> Muhammad Usama Anjum, le ven. 16 juin 2023 17:53:12 +0500, a ecrit:
>> Soft reminder.
>
> It somehow hadn't appeared in my inbox.
This patch hasn't been accepted yet.

>
>> On 3/3/23 5:51 PM, Muhammad Usama Anjum wrote:
>>> make versioncheck reports the following:
>>> ./drivers/accessibility/speakup/genmap.c: 13 linux/version.h not needed.
>>> ./drivers/accessibility/speakup/makemapdata.c: 13 linux/version.h not needed.
>>>
>>> So remove linux/version.h from both of these files.
>>>
>>> Signed-off-by: Muhammad Usama Anjum <[email protected]>
>
> Reviewed-by: Samuel Thibault <[email protected]>
>
> Thanks!
>
>>> ---
>>> drivers/accessibility/speakup/genmap.c | 1 -
>>> drivers/accessibility/speakup/makemapdata.c | 1 -
>>> 2 files changed, 2 deletions(-)
>>>
>>> diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
>>> index 0125000e00d9..0882bab10fb8 100644
>>> --- a/drivers/accessibility/speakup/genmap.c
>>> +++ b/drivers/accessibility/speakup/genmap.c
>>> @@ -10,7 +10,6 @@
>>> #include <stdio.h>
>>> #include <libgen.h>
>>> #include <string.h>
>>> -#include <linux/version.h>
>>> #include <ctype.h>
>>> #include "utils.h"
>>>
>>> diff --git a/drivers/accessibility/speakup/makemapdata.c b/drivers/accessibility/speakup/makemapdata.c
>>> index d7d41bb9b05f..55e4ef8a93dc 100644
>>> --- a/drivers/accessibility/speakup/makemapdata.c
>>> +++ b/drivers/accessibility/speakup/makemapdata.c
>>> @@ -10,7 +10,6 @@
>>> #include <stdio.h>
>>> #include <libgen.h>
>>> #include <string.h>
>>> -#include <linux/version.h>
>>> #include <ctype.h>
>>> #include "utils.h"
>>>
>>
>> --
>> BR,
>> Muhammad Usama Anjum
>>
>

--
BR,
Muhammad Usama Anjum