2020-12-14 15:06:03

by Zheng Yongjun

Subject: [PATCH -next] drm: omapdrm: Delete useless kfree code

The parameter of kfree function is NULL, so kfree code is useless, delete it.

Signed-off-by: Zheng Yongjun <[email protected]>
---
drivers/gpu/drm/omapdrm/tcm-sita.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/omapdrm/tcm-sita.c b/drivers/gpu/drm/omapdrm/tcm-sita.c
index 817be3c41863..af59e9c03917 100644
--- a/drivers/gpu/drm/omapdrm/tcm-sita.c
+++ b/drivers/gpu/drm/omapdrm/tcm-sita.c
@@ -254,6 +254,5 @@ struct tcm *sita_init(u16 width, u16 height)
return tcm;

error:
- kfree(tcm);
return NULL;
}
--
2.22.0

2020-12-15 15:24:09

by Tomi Valkeinen

Subject: Re: [PATCH -next] drm: omapdrm: Delete useless kfree code

On 14/12/2020 15:46, Zheng Yongjun wrote:
> The parameter of kfree function is NULL, so kfree code is useless, delete it.
>
> Signed-off-by: Zheng Yongjun <[email protected]>
> ---
> drivers/gpu/drm/omapdrm/tcm-sita.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/tcm-sita.c b/drivers/gpu/drm/omapdrm/tcm-sita.c
> index 817be3c41863..af59e9c03917 100644
> --- a/drivers/gpu/drm/omapdrm/tcm-sita.c
> +++ b/drivers/gpu/drm/omapdrm/tcm-sita.c
> @@ -254,6 +254,5 @@ struct tcm *sita_init(u16 width, u16 height)
> return tcm;
>
> error:
> - kfree(tcm);
> return NULL;
> }

Thanks, I'll merge this.

Tomi

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki