2021-10-29 12:09:07

by Lin Feng

Subject: [PATCH] bcache: remove unused struct member in cache_stats

Commit 1616a4c2ab1a80893b6890ae93da40a2b1d0c691
("bcache: remove bcache device self-defined readahead")
remove stuffs for bcache self-defined readahead, but
cache_readaheads field in cache_stats is leftout, remove it.

Signed-off-by: Lin Feng <[email protected]>
---
drivers/md/bcache/stats.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/md/bcache/stats.h b/drivers/md/bcache/stats.h
index ca4f435f7216..b6bfea66c01f 100644
--- a/drivers/md/bcache/stats.h
+++ b/drivers/md/bcache/stats.h
@@ -18,7 +18,6 @@ struct cache_stats {
unsigned long cache_misses;
unsigned long cache_bypass_hits;
unsigned long cache_bypass_misses;
- unsigned long cache_readaheads;
unsigned long cache_miss_collisions;
unsigned long sectors_bypassed;

--
2.31.1

2021-10-30 15:01:08

by Coly Li

Subject: Re: [PATCH] bcache: remove unused struct member in cache_stats

On 10/29/21 7:59 PM, Lin Feng wrote:
> Commit 1616a4c2ab1a80893b6890ae93da40a2b1d0c691
> ("bcache: remove bcache device self-defined readahead")
> remove stuffs for bcache self-defined readahead, but
> cache_readaheads field in cache_stats is leftout, remove it.
>
> Signed-off-by: Lin Feng <[email protected]>

Nice catch. I add it into my testing queue. Thanks.

Coly Li

> ---
> drivers/md/bcache/stats.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/md/bcache/stats.h b/drivers/md/bcache/stats.h
> index ca4f435f7216..b6bfea66c01f 100644
> --- a/drivers/md/bcache/stats.h
> +++ b/drivers/md/bcache/stats.h
> @@ -18,7 +18,6 @@ struct cache_stats {
> unsigned long cache_misses;
> unsigned long cache_bypass_hits;
> unsigned long cache_bypass_misses;
> - unsigned long cache_readaheads;
> unsigned long cache_miss_collisions;
> unsigned long sectors_bypassed;
>